From: Rob Herring <robh@kernel.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: agross@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mgautam@codeaurora.org,
rojay@codeaurora.org, c_skakit@codeaurora.org, mka@chromium.org
Subject: Re: [PATCH V5 2/3] dt-bindings: geni-se: Add interconnect binding for GENI QUP
Date: Fri, 13 Mar 2020 17:06:38 -0500 [thread overview]
Message-ID: <20200313220638.GA30287@bogus> (raw)
In-Reply-To: <1584095350-841-3-git-send-email-akashast@codeaurora.org>
On Fri, Mar 13, 2020 at 03:59:09PM +0530, Akash Asthana wrote:
> Add documentation for the interconnect and interconnect-names properties
> for the GENI QUP.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V5:
> - Add interconnect property for QUP wrapper (parent node).
> - Add minItems = 2 for interconnect property in child nodes
>
> .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 23282ab..533400b 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -46,6 +46,12 @@ properties:
>
> ranges: true
>
> + interconnects:
> + maxItems: 1
> +
> + interconnect-names:
> + const: qup-core
> +
> required:
> - compatible
> - reg
> @@ -73,6 +79,16 @@ patternProperties:
> description: Serial engine core clock needed by the device.
> maxItems: 1
>
> + interconnects:
> + minItems: 2
> + maxItems: 3
> +
> + interconnect-names:
> + items:
> + - const: qup-core
> + - const: qup-config
> + - const: qup-memory
Don't you need 'minItems: 2' here?
Rob
next prev parent reply other threads:[~2020-03-13 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 10:29 [PATCH V5 0/3] Convert QUP bindings to YAML and add ICC, pin swap doc Akash Asthana
2020-03-13 10:29 ` [PATCH V5 1/3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML Akash Asthana
2020-03-13 10:29 ` [PATCH V5 2/3] dt-bindings: geni-se: Add interconnect binding for GENI QUP Akash Asthana
2020-03-13 22:06 ` Rob Herring [this message]
2020-05-07 15:00 ` Akash Asthana
2020-03-13 10:29 ` [PATCH V5 3/3] dt-bindings: geni-se: Add binding for UART pin swap Akash Asthana
2020-03-20 18:07 ` Rob Herring
2020-03-24 5:16 ` Akash Asthana
2020-04-24 20:57 ` Matthias Kaehlcke
2020-04-28 9:49 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313220638.GA30287@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=c_skakit@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=rojay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).