From: Thara Gopinath <thara.gopinath@linaro.org>
To: rui.zhang@intel.com, ulf.hansson@linaro.org,
daniel.lezcano@linaro.org, bjorn.andersson@linaro.org,
agross@kernel.org, robh@kernel.org
Cc: amit.kucheria@verdurent.com, mark.rutland@arm.com,
rjw@rjwysocki.net, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [Patch v5 4/6] soc: qcom: Extend RPMh power controller driver to register warming devices.
Date: Thu, 19 Mar 2020 21:41:05 -0400 [thread overview]
Message-ID: <20200320014107.26087-5-thara.gopinath@linaro.org> (raw)
In-Reply-To: <20200320014107.26087-1-thara.gopinath@linaro.org>
RPMh power control hosts power domains that can be used as
thermal warming devices. Register these power domains
with the generic power domain warming device thermal framework.
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
v3->v4:
- Introduce a boolean value is_warming_dev in rpmhpd structure to
indicate if a generic power domain can be used as a warming
device or not.With this change, device tree no longer has to
specify which power domain inside the rpmh power domain provider
is a warming device.
- Move registering of warming devices into a late initcall to
ensure that warming devices are registered after thermal
framework is initialized.
drivers/soc/qcom/rpmhpd.c | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 7142409a3b77..4e9c0bbb8826 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -11,6 +11,7 @@
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/pm_opp.h>
+#include <linux/pd_warming.h>
#include <soc/qcom/cmd-db.h>
#include <soc/qcom/rpmh.h>
#include <dt-bindings/power/qcom-rpmpd.h>
@@ -48,6 +49,7 @@ struct rpmhpd {
bool enabled;
const char *res_name;
u32 addr;
+ bool is_warming_dev;
};
struct rpmhpd_desc {
@@ -55,6 +57,8 @@ struct rpmhpd_desc {
size_t num_pds;
};
+const struct rpmhpd_desc *global_desc;
+
static DEFINE_MUTEX(rpmhpd_lock);
/* SDM845 RPMH powerdomains */
@@ -89,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
.pd = { .name = "mx", },
.peer = &sdm845_mx_ao,
.res_name = "mx.lvl",
+ .is_warming_dev = true,
};
static struct rpmhpd sdm845_mx_ao = {
@@ -452,7 +457,14 @@ static int rpmhpd_probe(struct platform_device *pdev)
&rpmhpds[i]->pd);
}
- return of_genpd_add_provider_onecell(pdev->dev.of_node, data);
+ ret = of_genpd_add_provider_onecell(pdev->dev.of_node, data);
+
+ if (ret)
+ return ret;
+
+ global_desc = desc;
+
+ return 0;
}
static struct platform_driver rpmhpd_driver = {
@@ -469,3 +481,26 @@ static int __init rpmhpd_init(void)
return platform_driver_register(&rpmhpd_driver);
}
core_initcall(rpmhpd_init);
+
+static int __init rpmhpd_init_warming_device(void)
+{
+ size_t num_pds;
+ struct rpmhpd **rpmhpds;
+ int i;
+
+ if (!global_desc)
+ return -EINVAL;
+
+ rpmhpds = global_desc->rpmhpds;
+ num_pds = global_desc->num_pds;
+
+ if (!of_find_property(rpmhpds[0]->dev->of_node, "#cooling-cells", NULL))
+ return 0;
+
+ for (i = 0; i < num_pds; i++)
+ if (rpmhpds[i]->is_warming_dev)
+ of_pd_warming_register(rpmhpds[i]->dev, i);
+
+ return 0;
+}
+late_initcall(rpmhpd_init_warming_device);
--
2.20.1
next prev parent reply other threads:[~2020-03-20 1:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 1:41 [Patch v5 0/6] Introduce Power domain based warming device driver Thara Gopinath
2020-03-20 1:41 ` [Patch v5 1/6] PM/Domains: Add support for retrieving genpd performance states information Thara Gopinath
2020-03-27 22:33 ` Bjorn Andersson
2020-03-20 1:41 ` [Patch v5 2/6] soc: qcom: rpmhpd: Introduce function to retrieve power domain performance state count Thara Gopinath
2020-03-27 22:15 ` Bjorn Andersson
2020-03-30 14:41 ` Thara Gopinath
2020-03-20 1:41 ` [Patch v5 3/6] thermal: Add generic power domain warming device driver Thara Gopinath
2020-03-23 15:57 ` Ulf Hansson
2020-03-25 14:35 ` Thara Gopinath
2020-03-20 1:41 ` Thara Gopinath [this message]
2020-03-27 22:53 ` [Patch v5 4/6] soc: qcom: Extend RPMh power controller driver to register warming devices Bjorn Andersson
2020-03-30 14:53 ` Thara Gopinath
2020-03-30 22:29 ` Bjorn Andersson
2020-03-20 1:41 ` [Patch v5 5/6] dt-bindings: power: Extend RPMh power controller binding to describe thermal warming device Thara Gopinath
2020-03-20 22:56 ` Rob Herring
2020-03-20 1:41 ` [Patch v5 6/6] arm64: dts: qcom: Indicate rpmhpd hosts a power domain that can be used as a " Thara Gopinath
2020-03-27 22:54 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320014107.26087-5-thara.gopinath@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).