From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH 2/4] clk: qcom: mmcc-msm8996: Properly describe GPU_GX gdsc
Date: Fri, 20 Mar 2020 22:16:12 -0700 [thread overview]
Message-ID: <20200321051612.GA5063@builder> (raw)
In-Reply-To: <158474710844.125146.15515925711513283888@swboyd.mtv.corp.google.com>
On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2020-03-18 22:39:00)
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > index 85518494ce43..65d9aa790581 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> > @@ -67,6 +67,10 @@ properties:
> > description:
> > Protected clock specifier list as per common clock binding
> >
> > + vdd_gfx-supply:
>
> Why not vdd-gfx-supply? What's with the underscore?
>
The pad is named "VDD_GFX" in the datasheet and the schematics. I see
that we've started y/_/-/ in some of the newly added bindings, would you
prefer I follow this?
Regards,
Bjorn
> > + description:
> > + Regulator supply for the GPU_GX GDSC
> > +
> > required:
> > - compatible
> > - reg
next prev parent reply other threads:[~2020-03-21 5:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 5:38 [PATCH 0/4] clk: qcom: gdsc: Handle supply regulators Bjorn Andersson
2020-03-19 5:38 ` [PATCH 1/4] clk: qcom: gdsc: Handle GDSC regulator supplies Bjorn Andersson
2020-03-20 23:31 ` Stephen Boyd
2020-03-31 5:35 ` Taniya Das
2020-03-31 6:08 ` Bjorn Andersson
2020-03-19 5:39 ` [PATCH 2/4] clk: qcom: mmcc-msm8996: Properly describe GPU_GX gdsc Bjorn Andersson
2020-03-20 23:31 ` Stephen Boyd
2020-03-21 5:16 ` Bjorn Andersson [this message]
2020-03-21 18:43 ` Stephen Boyd
2020-03-30 23:10 ` Rob Herring
2020-03-19 5:39 ` [PATCH 3/4] arm64: dts: qcom: db820c: Add s2 regulator in pmi8994 Bjorn Andersson
2020-03-20 23:33 ` Stephen Boyd
2020-03-21 5:19 ` Bjorn Andersson
2020-03-19 5:39 ` [PATCH 4/4] arm64: dts: qcom: msm8996: Make GPU node control GPU_GX GDSC Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321051612.GA5063@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).