Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next/-mmotm] bus/mhi: fix printk format for size_t
@ 2020-03-22  4:17 Randy Dunlap
  2020-03-22  4:49 ` Manivannan Sadhasivam
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-03-22  4:17 UTC (permalink / raw)
  To: LKML, Andrew Morton, Stephen Rothwell, Manivannan Sadhasivam,
	Hemant Kumar, linux-arm-msm

From: Randy Dunlap <rdunlap@infradead.org>

Fix printk format warning by using %z for size_t modifier:

../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
  dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",


Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Hemant Kumar <hemantk@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
---
Found in mmotm, but in its linux-next.patch file.

 drivers/bus/mhi/core/boot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm-2020-0321-1517.orig/drivers/bus/mhi/core/boot.c
+++ mmotm-2020-0321-1517/drivers/bus/mhi/core/boot.c
@@ -52,7 +52,7 @@ void mhi_rddm_prepare(struct mhi_control
 			    BHIE_RXVECDB_SEQNUM_BMSK, BHIE_RXVECDB_SEQNUM_SHFT,
 			    sequence_id);
 
-	dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
+	dev_dbg(dev, "Address: %p and len: 0x%zx sequence: %u\n",
 		&mhi_buf->dma_addr, mhi_buf->len, sequence_id);
 }
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next/-mmotm] bus/mhi: fix printk format for size_t
  2020-03-22  4:17 [PATCH -next/-mmotm] bus/mhi: fix printk format for size_t Randy Dunlap
@ 2020-03-22  4:49 ` Manivannan Sadhasivam
  2020-03-24  2:24   ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-03-22  4:49 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, Andrew Morton, Stephen Rothwell, Hemant Kumar, linux-arm-msm

On Sat, Mar 21, 2020 at 09:17:52PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix printk format warning by using %z for size_t modifier:
> 
> ../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
> ../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
>   dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> 
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Hemant Kumar <hemantk@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> ---
> Found in mmotm, but in its linux-next.patch file.
> 
>  drivers/bus/mhi/core/boot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm-2020-0321-1517.orig/drivers/bus/mhi/core/boot.c
> +++ mmotm-2020-0321-1517/drivers/bus/mhi/core/boot.c
> @@ -52,7 +52,7 @@ void mhi_rddm_prepare(struct mhi_control
>  			    BHIE_RXVECDB_SEQNUM_BMSK, BHIE_RXVECDB_SEQNUM_SHFT,
>  			    sequence_id);
>  
> -	dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> +	dev_dbg(dev, "Address: %p and len: 0x%zx sequence: %u\n",
>  		&mhi_buf->dma_addr, mhi_buf->len, sequence_id);
>  }
>  
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next/-mmotm] bus/mhi: fix printk format for size_t
  2020-03-22  4:49 ` Manivannan Sadhasivam
@ 2020-03-24  2:24   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2020-03-24  2:24 UTC (permalink / raw)
  To: Manivannan Sadhasivam
  Cc: Randy Dunlap, LKML, Stephen Rothwell, Hemant Kumar,
	linux-arm-msm, Greg Kroah-Hartman

On Sun, 22 Mar 2020 10:19:52 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:

> On Sat, Mar 21, 2020 at 09:17:52PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix printk format warning by using %z for size_t modifier:
> > 
> > ../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
> > ../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
> >   dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> > 
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks.  I guess we should tell Greg, who presently holds the offending
patch.  I shall add 

Fixes: 6fdfdd27328ce ("bus: mhi: core: Add support for downloading RDDM image du
ring panic")

and send it over.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22  4:17 [PATCH -next/-mmotm] bus/mhi: fix printk format for size_t Randy Dunlap
2020-03-22  4:49 ` Manivannan Sadhasivam
2020-03-24  2:24   ` Andrew Morton

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git