linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: john@phrozen.org, agross@kernel.org,
	linux-arm-msm@vger.kernel.org,
	Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH v3 3/3] ARM: dts: qcom: ipq4019: add USB devicetree nodes
Date: Fri, 27 Mar 2020 15:12:13 -0700	[thread overview]
Message-ID: <20200327221213.GD5063@builder> (raw)
In-Reply-To: <20200127212319.1544222-3-robert.marko@sartura.hr>

On Mon 27 Jan 13:23 PST 2020, Robert Marko wrote:

> From: John Crispin <john@phrozen.org>
> 
> Since we now have driver for the USB PHY, lets add the necessary nodes to DTSI.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Tested-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Robert, I'm missing your Signed-off-by here (and I would like Kishon to
take the PHY before merging this).

Regards,
Bjorn

> ---
>  arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 20 +++++
>  arch/arm/boot/dts/qcom-ipq4019.dtsi           | 74 +++++++++++++++++++
>  2 files changed, 94 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> index 418f9a022336..2ee5f05d5a43 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
> @@ -109,5 +109,25 @@
>  		wifi@a800000 {
>  			status = "ok";
>  		};
> +
> +		usb3_ss_phy: ssphy@9a000 {
> +			status = "ok";
> +		};
> +
> +		usb3_hs_phy: hsphy@a6000 {
> +			status = "ok";
> +		};
> +
> +		usb3: usb3@8af8800 {
> +			status = "ok";
> +		};
> +
> +		usb2_hs_phy: hsphy@a8000 {
> +			status = "ok";
> +		};
> +
> +		usb2: usb2@60f8800 {
> +			status = "ok";
> +		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index b6e5203a210b..18e9c639514c 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -564,5 +564,79 @@
>  					  "legacy";
>  			status = "disabled";
>  		};
> +
> +		usb3_ss_phy: ssphy@9a000 {
> +			compatible = "qcom,usb-ss-ipq4019-phy";
> +			#phy-cells = <0>;
> +			reg = <0x9a000 0x800>;
> +			reg-names = "phy_base";
> +			resets = <&gcc USB3_UNIPHY_PHY_ARES>;
> +			reset-names = "por_rst";
> +			status = "disabled";
> +		};
> +
> +		usb3_hs_phy: hsphy@a6000 {
> +			compatible = "qcom,usb-hs-ipq4019-phy";
> +			#phy-cells = <0>;
> +			reg = <0xa6000 0x40>;
> +			reg-names = "phy_base";
> +			resets = <&gcc USB3_HSPHY_POR_ARES>, <&gcc USB3_HSPHY_S_ARES>;
> +			reset-names = "por_rst", "srif_rst";
> +			status = "disabled";
> +		};
> +
> +		usb3@8af8800 {
> +			compatible = "qcom,dwc3";
> +			reg = <0x8af8800 0x100>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			clocks = <&gcc GCC_USB3_MASTER_CLK>,
> +				 <&gcc GCC_USB3_SLEEP_CLK>,
> +				 <&gcc GCC_USB3_MOCK_UTMI_CLK>;
> +			clock-names = "master", "sleep", "mock_utmi";
> +			ranges;
> +			status = "disabled";
> +
> +			dwc3@8a00000 {
> +				compatible = "snps,dwc3";
> +				reg = <0x8a00000 0xf8000>;
> +				interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
> +				phys = <&usb3_hs_phy>, <&usb3_ss_phy>;
> +				phy-names = "usb2-phy", "usb3-phy";
> +				dr_mode = "host";
> +			};
> +		};
> +
> +		usb2_hs_phy: hsphy@a8000 {
> +			compatible = "qcom,usb-hs-ipq4019-phy";
> +			#phy-cells = <0>;
> +			reg = <0xa8000 0x40>;
> +			reg-names = "phy_base";
> +			resets = <&gcc USB2_HSPHY_POR_ARES>, <&gcc USB2_HSPHY_S_ARES>;
> +			reset-names = "por_rst", "srif_rst";
> +			status = "disabled";
> +		};
> +
> +		usb2@60f8800 {
> +			compatible = "qcom,dwc3";
> +			reg = <0x60f8800 0x100>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			clocks = <&gcc GCC_USB2_MASTER_CLK>,
> +				 <&gcc GCC_USB2_SLEEP_CLK>,
> +				 <&gcc GCC_USB2_MOCK_UTMI_CLK>;
> +			clock-names = "master", "sleep", "mock_utmi";
> +			ranges;
> +			status = "disabled";
> +
> +			dwc3@6000000 {
> +				compatible = "snps,dwc3";
> +				reg = <0x6000000 0xf8000>;
> +				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> +				phys = <&usb2_hs_phy>;
> +				phy-names = "usb2-phy";
> +				dr_mode = "host";
> +			};
> +		};
>  	};
>  };
> -- 
> 2.24.1
> 

  reply	other threads:[~2020-03-27 22:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 21:23 [PATCH v3 1/3] phy: add driver for Qualcomm IPQ40xx USB PHY Robert Marko
2020-01-27 21:23 ` [PATCH v3 2/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document Robert Marko
2020-01-27 21:23 ` [PATCH v3 3/3] ARM: dts: qcom: ipq4019: add USB devicetree nodes Robert Marko
2020-03-27 22:12   ` Bjorn Andersson [this message]
2020-03-28 13:58     ` Robert Marko
2020-03-08 18:55 ` [PATCH v3 1/3] phy: add driver for Qualcomm IPQ40xx USB PHY Robert Marko
2020-03-25 10:24 ` Robert Marko
2020-03-25 10:45   ` John Crispin
2020-03-27 22:14 ` Bjorn Andersson
2020-03-28 13:57   ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327221213.GD5063@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=john@phrozen.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=luka.perkov@sartura.hr \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).