From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4A1C2D0F0 for ; Mon, 30 Mar 2020 22:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F78620784 for ; Mon, 30 Mar 2020 22:29:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="enaoigUV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728987AbgC3W3i (ORCPT ); Mon, 30 Mar 2020 18:29:38 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34784 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729429AbgC3W3i (ORCPT ); Mon, 30 Mar 2020 18:29:38 -0400 Received: by mail-pl1-f195.google.com with SMTP id a23so7334731plm.1 for ; Mon, 30 Mar 2020 15:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O8vQmmg7hNSl880dzS5U4D8ylPA2t24t6PDXIkjFhyw=; b=enaoigUVvJO5lyNNbZ/eEngJDp3NLSbXaOW8jZMXRUmub8ne5NS0p2geytGwCNQhNo XgeGgxBkDSUWgWGKpRxnhHWbYuC+j6er51oCUnB/RC16US6Q+bgZj2EVcsUFu4QdmJKz VNedjGXM3sPPcxywmqhCVBX9zf2x5RN+C5cPU59YLceEVi8oVO9idqlgMe8G0fipax4l OThjTm38AALbmpbzI/QhQM9SxvoafBFBUMqK0mC4pzNkrxdCOZNZQDs/Y7JhASw8hKIv 4NB+RAvstoycLWvAu/duRBk1nRUqYutikF6uLdIJ7WqN8UoEs/7TFZkf0Y5vuEOk88NH vx0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O8vQmmg7hNSl880dzS5U4D8ylPA2t24t6PDXIkjFhyw=; b=RshZsiuEhPW/yq9WKOdCSbg8AHBTV7e0vLGo5m/t9ddRLa+iwhmI+EXjGPBMbx6kAJ HgATSLMFUGCLfh5/5gSfF8YlnyKYCLRR28tApS9qSQNqmfTFWVWLuBiGgg486oJt6jxl IzqtfXe3NzRELGrn9GlFqN4b1P4tZ/e8osjiOUM2FBa09py6/d4/4d/8ew52EVdWkba+ 0LKRJ5C9HcUkKLcaKnX2UOyXbm80yTh4ZotqfbOMqT8dJEQtQQSlVazVyyO/P2ILxBHs azSAMjMEe6algcDqvcYD8khhSLn17a/eMLj6ANdLa8Hp0ZWLMFwtbKIZwqptxlVvpMpm nFEg== X-Gm-Message-State: AGi0Pub/7t5u9G2287X9WrouyCk4CydxR//ztEMzXLcfPjnED7CT8Luu 1enFQjxIKKZloLdq67sKjqlHwA== X-Google-Smtp-Source: APiQypIuHql86lAYhHEvBXzOmE/e8Yj/bcnvY6jji2FWWAq4h5Q8oF0rrqf1mUeI/PTcQXDLTyv2kA== X-Received: by 2002:a17:90a:8087:: with SMTP id c7mr346640pjn.148.1585607376669; Mon, 30 Mar 2020 15:29:36 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id v42sm10448437pgn.6.2020.03.30.15.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 15:29:36 -0700 (PDT) Date: Mon, 30 Mar 2020 15:29:33 -0700 From: Bjorn Andersson To: Thara Gopinath Cc: rui.zhang@intel.com, ulf.hansson@linaro.org, daniel.lezcano@linaro.org, agross@kernel.org, robh@kernel.org, amit.kucheria@verdurent.com, mark.rutland@arm.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v5 4/6] soc: qcom: Extend RPMh power controller driver to register warming devices. Message-ID: <20200330222933.GC215915@minitux> References: <20200320014107.26087-1-thara.gopinath@linaro.org> <20200320014107.26087-5-thara.gopinath@linaro.org> <20200327225345.GH5063@builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 30 Mar 07:53 PDT 2020, Thara Gopinath wrote: > On 3/27/20 6:53 PM, Bjorn Andersson wrote: > > On Thu 19 Mar 18:41 PDT 2020, Thara Gopinath wrote: [..] > > > +static int __init rpmhpd_init_warming_device(void) > > > +{ > > > + size_t num_pds; > > > + struct rpmhpd **rpmhpds; > > > + int i; > > > + > > > + if (!global_desc) > > > + return -EINVAL; > > > + > > > + rpmhpds = global_desc->rpmhpds; > > > + num_pds = global_desc->num_pds; > > > + > > > + if (!of_find_property(rpmhpds[0]->dev->of_node, "#cooling-cells", NULL)) > > > + return 0; > > > + > > > + for (i = 0; i < num_pds; i++) > > > + if (rpmhpds[i]->is_warming_dev) > > > + of_pd_warming_register(rpmhpds[i]->dev, i); > > > + > > > + return 0; > > > +} > > > +late_initcall(rpmhpd_init_warming_device); > > > > ...why can't this be done in rpmhpd_probe()? > > > > In particular with the recent patches from John Stultz to allow rpmhpd > > to be built as a module I don't think there's any guarantees that > > rpmh_probe() will have succeeded before rpmhpd_init_warming_device() > > executes. > > It is to take care of boot order. Understood. > So this has to happen after the thermal framework is initialized. Thermal > framework is initialized with core_initcall. Can I move the rpmhpd init as a > postcore_initcall ? Then I can get rid of this separate function and keep it > as part of probe. > So I presume the problem is that if this is called from probe, you might of_pd_warming_register(), which ends up in __thermal_cooling_device_register() before thermal_init() has been invoked? Which is bad because e.g. thermal_class is not yet initialized. I don't want to rely on the order of initcalls for things to work, so could we make this more robust by having thermal_of_cooling_device_register() return -EPROBE_DEFER is thermal_init() isn't done? Regards, Bjorn