From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7FDC43331 for ; Tue, 31 Mar 2020 17:56:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93D3B212CC for ; Tue, 31 Mar 2020 17:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585677386; bh=yVjEro7Vq5Q1XoCkLOTo6NB94st8CQF18vxoDX2BR/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lI2PvZDC5VWDyiq9305I8D2l/qgeUBMurZlx7ZE36+tR2v53i/yInnu2sTlEFPYxk BCne2rRZhkzlTShTiu1VzNO2x59oBmPEibmAhrkPwvguflu4BuAnkP87OxccAP+Cw5 NHcKKGM5kL8xuniIN2uDQTKUMNdOXjH/IVN+nGuI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbgCaR4X (ORCPT ); Tue, 31 Mar 2020 13:56:23 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:41618 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbgCaR4X (ORCPT ); Tue, 31 Mar 2020 13:56:23 -0400 Received: by mail-il1-f194.google.com with SMTP id t6so16724137ilj.8; Tue, 31 Mar 2020 10:56:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0Yp77BX0CNsI0E9W0U3Z3mSHpIexs+AJy6eqRXEJQU0=; b=B1GDjomFsIguNX7u5ig6d7O9ctxoGqf5jc9PgWFWXiCfBP26efSsq7ShChVMjCE/vi 6qizsSu1/ENs4cj3b+EAOnd6rOHyNFhrs4OMOOWnX/7G9izb9jDizCUdGeDPG2tsOfm6 19l7QT5YifrmVSsVSa0XlhnoLgXEmOsxJ6ZCZgkF2WeYTxgMnagR+Jsy3RZO7ENqUxFw QSl2jCQlA6MVAF9CepySPnGRAJ0bM+8/MrT/twdKVj0814p8qujNTnGfJyCDht8ix2ZL SHIDdVyqaLneoI6BZWRYT18RwKZ8kbrEwHDCvncs2kK+HOmECUfKuorRYb5HOuQeaRe1 TFSQ== X-Gm-Message-State: ANhLgQ2ja4eDqaRtYkXvBPGRVkd7OOYH4Il5aIpBo10OjWYPmx/qSO3Z Pd8jgMUfMGR+h6QpTeR9TA== X-Google-Smtp-Source: ADFU+vtpX68rVrNJUeA4Xd7HfNw0GlkZdMwR56tGbxSge2H9UtVNk87hzwLKVeKvE6Buoj/X3b/XtA== X-Received: by 2002:a92:5e14:: with SMTP id s20mr18027047ilb.101.1585677381521; Tue, 31 Mar 2020 10:56:21 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id x4sm4742966ilj.6.2020.03.31.10.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:56:20 -0700 (PDT) Received: (nullmailer pid 27986 invoked by uid 1000); Tue, 31 Mar 2020 17:56:19 -0000 Date: Tue, 31 Mar 2020 11:56:19 -0600 From: Rob Herring To: Kiran Gunda Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy Subject: Re: [PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings Message-ID: <20200331175619.GA25466@bogus> References: <1584985618-25689-1-git-send-email-kgunda@codeaurora.org> <1584985618-25689-4-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584985618-25689-4-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Mar 23, 2020 at 11:16:57PM +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > More of the same comments here... > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > --- > .../bindings/leds/backlight/qcom-wled.yaml | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index 8a388bf..159115f 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -20,6 +20,7 @@ properties: > - qcom,pm8941-wled > - qcom,pmi8998-wled > - qcom,pm660l-wled > + - qcom,pm8150l-wled > > reg: > maxItems: 1 > @@ -28,10 +29,23 @@ properties: > maxItems: 1 > description: > brightness value on boot, value from 0-4095. > + For pm8150l this value vary from 0-4095 or 0-32767 > + depending on the brightness control mode. If CABC is > + enabled 0-4095 range is used. Constraints. > allOf: > - $ref: /schemas/types.yaml#/definitions/uint32 > default: 2048 > > + max-brightness: > + maxItems: 1 > + description: > + Maximum brightness level. Allowed values are, > + for pmi8998 it is 0-4095. > + For pm8150l, this can be either 4095 or 32767. Constraints! > + If CABC is enabled, this is capped to 4095. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 Standard property. Assume it has a type definition.' > + > label: > maxItems: 1 > description: > @@ -124,6 +138,31 @@ properties: > value for PM8941 from 1 to 3. Default 2 > For PMI8998 from 1 to 4. > > + qcom,modulator-sel: > + maxItems: 1 > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Selects the modulator used for brightness modulation. > + Allowed values are, > + 0 - Modulator A > + 1 - Modulator B > + If not specified, then modulator A will be used by default. > + This property is applicable only to WLED5 peripheral. > + > + qcom,cabc-sel: > + maxItems: 1 > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Selects the CABC pin signal used for brightness modulation. > + Allowed values are, > + 0 - CABC disabled > + 1 - CABC 1 > + 2 - CABC 2 > + 3 - External signal (e.g. LPG) is used for dimming > + This property is applicable only to WLED5 peripheral. > + > interrupts: > maxItems: 2 > description: > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >