From: Dan Carpenter <dan.carpenter@oracle.com>
To: manivannan.sadhasivam@linaro.org
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [bug report] bus: mhi: core: Add support for data transfer
Date: Tue, 7 Apr 2020 16:56:08 +0300 [thread overview]
Message-ID: <20200407135608.GA109647@mwanda> (raw)
Hello Manivannan Sadhasivam,
The patch 189ff97cca53: "bus: mhi: core: Add support for data
transfer" from Feb 20, 2020, leads to the following static checker
warning:
drivers/bus/mhi/core/main.c:1093 mhi_gen_tre()
warn: bitwise AND condition is false here
drivers/bus/mhi/core/main.c
1088
1089 ret = mhi_cntrl->map_single(mhi_cntrl, buf_info);
1090 if (ret)
1091 return ret;
1092
1093 eob = !!(flags & MHI_EOB);
^^^^^^^
This is zero. Was BIT(0) intended?
1094 eot = !!(flags & MHI_EOT);
1095 chain = !!(flags & MHI_CHAIN);
1096 bei = !!(mhi_chan->intmod);
1097
1098 mhi_tre = tre_ring->wp;
1099 mhi_tre->ptr = MHI_TRE_DATA_PTR(buf_info->p_addr);
regards,
dan carpenter
next reply other threads:[~2020-04-07 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 13:56 Dan Carpenter [this message]
2020-04-07 14:31 ` [bug report] bus: mhi: core: Add support for data transfer Manivannan Sadhasivam
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 13:55 Dan Carpenter
2020-04-07 14:33 ` Manivannan Sadhasivam
2020-04-17 3:37 ` Hemant Kumar
2020-04-17 10:14 ` Manivannan Sadhasivam
2020-04-17 10:24 ` Dan Carpenter
2020-04-18 7:10 ` Hemant Kumar
2020-04-18 19:19 ` Manivannan Sadhasivam
2020-04-20 22:57 ` Hemant Kumar
2020-04-21 5:52 ` Manivannan Sadhasivam
2020-04-21 6:03 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407135608.GA109647@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).