From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Wang Wenhu <wenhu.wang@vivo.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rdunlap@infradead.org, kernel@vivo.com, agross@kernel.org,
ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3,0/3] drivers: rpmon: new driver Remote Processor Monitor
Date: Tue, 14 Apr 2020 15:58:23 -0700 [thread overview]
Message-ID: <20200414225823.GH892431@yoga> (raw)
In-Reply-To: <20200414035949.107225-1-wenhu.wang@vivo.com>
On Mon 13 Apr 20:59 PDT 2020, Wang Wenhu wrote:
> RPMON is a driver framework. It supports remote processor monitor
> from user level. The basic components are a character device
> with sysfs interfaces for user space communication and different
> kinds of message drivers introduced modularly, which are used to
> communicate with remote processors.
>
> As for user space, one can get notifications of different events
> of remote processors, like their registrations, through standard
> file read operation of the file descriptors related to the exported
> character devices. Actions can also be taken into account via
> standard write operations to the devices. Besides, the sysfs class
> attributes could be accessed conveniently.
>
> Message drivers act as engines to communicate with remote processors.
> Currently RPMON_QMI is available which uses QMI infrastructures
> on Qualcomm SoC Platforms.
>
> RPMON_QMI implements a kind of communication routine for RPMON to
> communicate with remote processors through QMI infrastructure.
> RPMON_QMI itself is designed as a modular framework that would
> introduce different kind of message sets which are binding to
> different services.
>
> RPMON_QMI creates a device of rpmon_device type for each remote
> processor endpoint. All the endpoint devices share an unique set
> of QMI suite.
>
> RPMON_QMI_MSG_V01 implements a RPMON_QMI message set for connection check.
> RPMON_QMI defines its message types modularly. Each rpmon service
> binds to a message set and introduced as a module. This version 1.0
> message set could be used for connection checking of remote processors.
>
> RPMON_QMI messages depend on QCOM_QMI_HELPERS and should be updated
> together with QMI related modules.
>
Hi Wang,
What additional transports do you expect for this to be a framework and
not just a driver? Why not implement the rpmon client directly in
userspace?
Regards,
Bjorn
> Changes since v1:
> - Addressed review comments from Randy
> Changes since v2:
> - Added Cc list
> - Commit log typo fixing
> - Use the ARRAY_SIZE instead of calculations of multiple sizeof()
> - Use micros for qmi message tly_type fields
>
> Wang Wenhu (3):
> driver: rpmon: new driver Remote Processor Monitor
> driver: rpmon: qmi message version 01
> driver: rpmon: add rpmon_qmi driver
>
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/rpmon/Kconfig | 54 ++++
> drivers/rpmon/Makefile | 3 +
> drivers/rpmon/rpmon.c | 506 +++++++++++++++++++++++++++++++
> drivers/rpmon/rpmon_qmi.c | 431 ++++++++++++++++++++++++++
> drivers/rpmon/rpmon_qmi.h | 76 +++++
> drivers/rpmon/rpmon_qmi_msg_v1.c | 258 ++++++++++++++++
> include/linux/rpmon.h | 68 +++++
> 9 files changed, 1399 insertions(+)
> create mode 100644 drivers/rpmon/Kconfig
> create mode 100644 drivers/rpmon/Makefile
> create mode 100644 drivers/rpmon/rpmon.c
> create mode 100644 drivers/rpmon/rpmon_qmi.c
> create mode 100644 drivers/rpmon/rpmon_qmi.h
> create mode 100644 drivers/rpmon/rpmon_qmi_msg_v1.c
> create mode 100644 include/linux/rpmon.h
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-04-14 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200412112405.24116-1-wenhu.wang@vivo.com>
2020-04-14 3:59 ` [PATCH v3,0/3] drivers: rpmon: new driver Remote Processor Monitor Wang Wenhu
2020-04-14 3:59 ` [PATCH v3,1/3] driver: " Wang Wenhu
2020-04-28 12:57 ` Greg KH
2020-04-14 3:59 ` [PATCH v3,2/3] driver: rpmon: qmi message version 01 Wang Wenhu
2020-04-14 3:59 ` [PATCH v3,3/3] driver: rpmon: add rpmon_qmi driver Wang Wenhu
2020-04-14 22:58 ` Bjorn Andersson [this message]
2020-04-15 15:16 ` [PATCH v3,0/3] drivers: rpmon: new driver Remote Processor Monitor Wang Wenhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414225823.GH892431@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@vivo.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=rdunlap@infradead.org \
--cc=wenhu.wang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).