From: Luis Chamberlain <mcgrof@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Scott Branden <scott.branden@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Brown <david.brown@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shuah Khan <shuah@kernel.org>,
bjorn.andersson@linaro.org,
Shuah Khan <skhan@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Colin Ian King <colin.king@canonical.com>,
Takashi Iwai <tiwai@suse.de>,
linux-kselftest@vger.kernel.org, Andy Gross <agross@kernel.org>
Subject: Re: [PATCH] test_firmware: remove unnecessary test_fw_mutex in test_dev_config_show_xxx
Date: Thu, 16 Apr 2020 06:00:11 +0000 [thread overview]
Message-ID: <20200416060011.GK11244@42.do-not-panic.com> (raw)
In-Reply-To: <202004150943.01DF9E85@keescook>
On Wed, Apr 15, 2020 at 09:44:31AM -0700, Kees Cook wrote:
> On Wed, Apr 15, 2020 at 09:28:18AM -0700, Scott Branden wrote:
> > Hi Kees,
> >
> > On 2020-04-14 8:10 p.m., Kees Cook wrote:
> > > On Tue, Apr 14, 2020 at 05:25:17PM -0700, Scott Branden wrote:
> > > > Remove unnecessary use of test_fw_mutex in test_dev_config_show_xxx
> > > > functions that show simple bool, int, and u8.
> > > I would expect at least a READ_ONCE(), yes?
> > I don't understand why you need a READ_ONCE when removing a mutex around an
> > assignment
> > of a parameter passed into a function being assigned to a local variable.
> >
> > Could you please explain your expectations.
>
> Oops, yes, you're right. I misread and was thinking this was reading
> from a global. This looks fine.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
prev parent reply other threads:[~2020-04-16 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:25 [PATCH] test_firmware: remove unnecessary test_fw_mutex in test_dev_config_show_xxx Scott Branden
2020-04-15 3:10 ` Kees Cook
2020-04-15 16:28 ` Scott Branden
2020-04-15 16:44 ` Kees Cook
2020-04-16 6:00 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416060011.GK11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).