From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84322C5518A for ; Fri, 24 Apr 2020 05:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 611382076C for ; Fri, 24 Apr 2020 05:36:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KNv6T2Oi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbgDXFgA (ORCPT ); Fri, 24 Apr 2020 01:36:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726587AbgDXFgA (ORCPT ); Fri, 24 Apr 2020 01:36:00 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6F81C09B046 for ; Thu, 23 Apr 2020 22:35:58 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id f7so4259836pfa.9 for ; Thu, 23 Apr 2020 22:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dqig/XiGz6oT5fWLHEXeMBJ/eQ9XUL/AW33WV/oOKxg=; b=KNv6T2OiqKrnPO4YQNWL1XDTyopOqUxnMhJfKYP5y8qML+U7mBJ1zLAVrDXnPqb1f7 xNi7j4Rajhrebj4O6XR1Eguq/aUJ/MXj+BzH6PJzF3zDrlp9oyqMu0c+pNBaV7yjAz9c ZTrdGb/cjoIjm8HU59QMDIt9dKhfH2CgdVlsHH56y0uArXOz1pSFPhs5iaIE2YgrqeB5 Plyjmx6C9JdSpnuy9PyLJ6tHzXKxg/IWGBrlo1LNlA2WIj6bFgNKJf9vjAzBVwNcmXBG +oLbIZB8Kw0+8Wyzxj2e1lYBbaPds3tNysdEQ85rRhrcfoBJfEPVnjpawhGDP4E7VP4Z Mo1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dqig/XiGz6oT5fWLHEXeMBJ/eQ9XUL/AW33WV/oOKxg=; b=pGIwgYB3vIMtPBD7VY9K23NHn+OluwSsncutQBgbKeDOxF+2SB5ZDtzEX6Prvsx/z/ 4V7nXejbj+P/E5cj9vthqKW2ASTFqDmq/+ljfepyWz0JYITcKxeLs2Ckah0Gur+HZ5pV s4To7LJ62FnP+B4r2CjGI50LpelpqjRwxLsfUIWTmHI4+mMkAGQcu6b9XZnJ+l8+L1EJ aMsA74+MWWUJSIwroa0zFw7FljeR2uJwG/WIdgT870mzZVPfdBCIBtydDyoLE5DaAcgu sFOasT1H0axbTxEQM2C5ZmXAjG3zldXyQOuw/krtHt4/nc5KquTAj2ytCXLsE9ml04uD Rqmw== X-Gm-Message-State: AGi0PuZbSeVHEnVb6NZXBrLguPk2UpM/AL0ATK9uniTbXvacDUB0jdz6 8ehzVS3moG7HEq8EjE3CXCmpsw== X-Google-Smtp-Source: APiQypJQcY8gkBpJbRvI1oKpLHbp9dlCRrYLr4knvswvyn1V27N2KSyhTlTtJWQsxSYFzxa9wdA8mA== X-Received: by 2002:a63:fd4a:: with SMTP id m10mr1460347pgj.28.1587706557937; Thu, 23 Apr 2020 22:35:57 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t3sm4411982pfq.110.2020.04.23.22.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 22:35:57 -0700 (PDT) Date: Thu, 23 Apr 2020 22:36:26 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Andy Gross , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Maulik Shah , Douglas Anderson Subject: Re: [PATCH 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API Message-ID: <20200424053626.GV20625@builder.lan> References: <20200424045414.133381-1-swboyd@chromium.org> <20200424045414.133381-2-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424045414.133381-2-swboyd@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 23 Apr 21:54 PDT 2020, Stephen Boyd wrote: > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c [..] > static int find_free_tcs(struct tcs_group *tcs) > { > - int i; > + const struct rsc_drv *drv = tcs->drv; > + unsigned long i; > > - for (i = 0; i < tcs->num_tcs; i++) { > - if (tcs_is_free(tcs->drv, tcs->offset + i)) > - return tcs->offset + i; > - } > + i = find_next_zero_bit(drv->tcs_in_use, MAX_TCS_NR, tcs->offset); > + if (i > tcs->offset + tcs->num_tcs) Afaict this should be >= Regards, Bjorn