From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails
Date: Thu, 30 Apr 2020 22:25:48 +0530 [thread overview]
Message-ID: <20200430165548.GE9449@Mani-XPS-13-9360> (raw)
In-Reply-To: <1588003153-13139-2-git-send-email-jhugo@codeaurora.org>
On Mon, Apr 27, 2020 at 09:59:08AM -0600, Jeffrey Hugo wrote:
> Powerdown is necessary if mhi_sync_power_up fails due to a timeout, to
> clean up the resources. Otherwise a BUG could be triggered when
> attempting to clean up MSIs because the IRQ is still active from a
> request_irq().
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/pm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index 52690cb..dc83d65 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -902,7 +902,11 @@ int mhi_sync_power_up(struct mhi_controller *mhi_cntrl)
> MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state),
> msecs_to_jiffies(mhi_cntrl->timeout_ms));
>
> - return (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
> + ret = (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -ETIMEDOUT;
> + if (ret)
> + mhi_power_down(mhi_cntrl, false);
> +
> + return ret;
> }
> EXPORT_SYMBOL(mhi_sync_power_up);
>
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-04-30 16:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:59 [PATCH v3 0/6] Misc MHI fixes Jeffrey Hugo
2020-04-27 15:59 ` [PATCH v3 1/6] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails Jeffrey Hugo
2020-04-28 18:52 ` Hemant Kumar
2020-04-30 16:55 ` Manivannan Sadhasivam [this message]
2020-04-27 15:59 ` [PATCH v3 2/6] bus: mhi: core: Remove link_status() callback Jeffrey Hugo
2020-04-28 18:54 ` Hemant Kumar
2020-04-27 15:59 ` [PATCH v3 3/6] bus: mhi: core: Offload register accesses to the controller Jeffrey Hugo
2020-04-28 18:56 ` Hemant Kumar
2020-04-30 16:57 ` Manivannan Sadhasivam
2020-04-27 15:59 ` [PATCH v3 4/6] bus: mhi: core: Fix typo in comment Jeffrey Hugo
2020-04-28 18:56 ` Hemant Kumar
2020-04-30 16:59 ` Manivannan Sadhasivam
2020-04-27 15:59 ` [PATCH v3 5/6] bus: mhi: core: Handle syserr during power_up Jeffrey Hugo
2020-04-27 15:59 ` [PATCH v3 6/6] bus: mhi: core: Fix channel device name conflict Jeffrey Hugo
2020-04-28 18:57 ` Hemant Kumar
2020-04-30 17:01 ` Manivannan Sadhasivam
2020-04-30 17:20 ` [PATCH v3 0/6] Misc MHI fixes Manivannan Sadhasivam
2020-04-30 17:54 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430165548.GE9449@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).