From: Douglas Anderson <dianders@chromium.org>
To: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: robdclark@chromium.org, seanpaul@chromium.org,
swboyd@chromium.org, linux-arm-msm@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] dt-bindings: drm/bridge: ti-sn65dsi86: Improve the yaml validation
Date: Wed, 6 May 2020 14:02:42 -0700 [thread overview]
Message-ID: <20200506140208.v2.2.I0a2bca02b09c1fcb6b09479b489736d600b3e57f@changeid> (raw)
In-Reply-To: <20200506140208.v2.1.Ibc8eeddcee94984a608d6900b46f9ffde4045da4@changeid>
This patch adds the following checks to the yaml:
- Remapping of the eDP output lanes is now limited to the subset of
remappings that the hardware supports.
- No more additional properties can be added under 'ports'.
This patch fixes the following bugs in the original yaml conversion:
- Fixed dependency between 'data-lanes' and 'lane-polarities', which
was backwards. Now you can only specify 'lane-polarities' if you
specified 'data-lanes'. I could have sworn I tried this before.
- We can't remap input lanes in this hardware.
This patch doesn't do, but if someone knew how I'd love to:
- Make sure if we have both 'lane-polarities' and 'data-lanes' that
they have the same number of elements.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
This patch could be squashed atop the patch adding the yaml [1]. I'm
sending separately for now to avoid churning the series another time.
[1] https://lore.kernel.org/r/20200430124442.v4.4.Ifcdc4ecb12742a27862744ee1e8753cb95a38a7f@changeid
Changes in v2:
- ("... Improve the yaml validation") new for v2.
.../bindings/display/bridge/ti,sn65dsi86.yaml | 74 ++++++++++---------
1 file changed, 40 insertions(+), 34 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
index 75c4e8b8e4b7..be10e8cf31e1 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
@@ -72,6 +72,7 @@ properties:
ports:
type: object
+ additionalProperties: false
properties:
"#address-cells":
@@ -94,33 +95,9 @@ properties:
endpoint:
type: object
additionalProperties: false
-
properties:
remote-endpoint: true
- data-lanes:
- minItems: 1
- maxItems: 4
- items:
- enum:
- - 0
- - 1
- - 2
- - 3
- description: See ../../media/video-interface.txt
-
- lane-polarities:
- minItems: 1
- maxItems: 4
- items:
- enum:
- - 0
- - 1
- description: See ../../media/video-interface.txt
-
- dependencies:
- data-lanes: [lane-polarities]
-
required:
- reg
@@ -143,15 +120,44 @@ properties:
remote-endpoint: true
data-lanes:
- minItems: 1
- maxItems: 4
- items:
- enum:
- - 0
- - 1
- - 2
- - 3
- description: See ../../media/video-interface.txt
+ oneOf:
+ - minItems: 1
+ maxItems: 1
+ uniqueItems: true
+ items:
+ enum:
+ - 0
+ - 1
+ description:
+ If you have 1 logical lane the bridge supports routing
+ to either port 0 or port 1. Port 0 is suggested.
+ See ../../media/video-interface.txt for details.
+
+ - minItems: 2
+ maxItems: 2
+ uniqueItems: true
+ items:
+ enum:
+ - 0
+ - 1
+ description:
+ If you have 2 logical lanes the bridge supports
+ reordering but only on physical ports 0 and 1.
+ See ../../media/video-interface.txt for details.
+
+ - minItems: 4
+ maxItems: 4
+ uniqueItems: true
+ items:
+ enum:
+ - 0
+ - 1
+ - 2
+ - 3
+ description:
+ If you have 4 logical lanes the bridge supports
+ reordering in any way.
+ See ../../media/video-interface.txt for details.
lane-polarities:
minItems: 1
@@ -163,7 +169,7 @@ properties:
description: See ../../media/video-interface.txt
dependencies:
- data-lanes: [lane-polarities]
+ lane-polarities: [data-lanes]
required:
- reg
--
2.26.2.645.ge9eca65c58-goog
next prev parent reply other threads:[~2020-05-06 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 21:02 [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity Douglas Anderson
2020-05-06 21:02 ` Douglas Anderson [this message]
2020-05-07 21:39 ` [PATCH v2 2/2] dt-bindings: drm/bridge: ti-sn65dsi86: Improve the yaml validation Doug Anderson
2020-05-15 21:43 ` [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity Rob Clark
2020-05-18 18:22 ` Doug Anderson
2020-05-18 18:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506140208.v2.2.I0a2bca02b09c1fcb6b09479b489736d600b3e57f@changeid \
--to=dianders@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).