From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D873DC433DF for ; Mon, 18 May 2020 10:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C055320709 for ; Mon, 18 May 2020 10:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbgERKQX (ORCPT ); Mon, 18 May 2020 06:16:23 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:39208 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgERKQX (ORCPT ); Mon, 18 May 2020 06:16:23 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 55002804CE; Mon, 18 May 2020 12:16:13 +0200 (CEST) Date: Mon, 18 May 2020 12:16:09 +0200 From: Sam Ravnborg To: Linus Walleij Cc: "open list:DRM PANEL DRIVERS" , Jingoo Han , Lee Jones , Daniel Thompson , Peter Ujfalusi , Tomi Valkeinen , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Douglas Anderson , Jani Nikula , Jonathan Corbet , MSM , linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Russell King , Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig Subject: Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight Message-ID: <20200518101609.GA759699@ravnborg.org> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=PHq6YzTAAAAA:8 a=hD80L64hAAAA:8 a=sozttTNsAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=cm27Pg_UAAAA:8 a=RYpW3c0wQFxx2xuxHgkA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=ZKzU8r6zoKMcqsNulkmm:22 a=aeg5Gbbo78KNqacMgKqU:22 a=cvBusfyB2V15izCimMoJ:22 a=xmb-EsYY8bH0VWELuYED:22 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Linus. On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote: > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg wrote: > > > Look up backlight device using devm_of_find_backlight(). > > This simplifies the code and prevents us from hardcoding > > the node name in the driver. > > > > v2: > > - Added Cc: Peter Ujfalusi > > > > Signed-off-by: Sam Ravnborg > > Cc: Russell King > > Cc: Sam Ravnborg > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Peter Ujfalusi > > Cc: Daniel Vetter > > Cc: Linus Walleij > > Cc: Jani Nikula > > Cc: Douglas Anderson > > Acked-by: Linus Walleij Thanks. I went ahead and applied this now, so we could kill the last user of of_find_backlight_by_node(). I hope we can make of_find_backlight_by_node() static after the merge window so no new users appears. Sam