From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C53C433DF for ; Mon, 18 May 2020 16:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F1DD207E8 for ; Mon, 18 May 2020 16:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X9m00R+U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbgERQRZ (ORCPT ); Mon, 18 May 2020 12:17:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbgERQRZ (ORCPT ); Mon, 18 May 2020 12:17:25 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F772C061A0C for ; Mon, 18 May 2020 09:17:24 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id z72so136175wmc.2 for ; Mon, 18 May 2020 09:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z0f8x9O/zHxL58ErQekbYNbB+b0vXLeqYxeXczK2D84=; b=X9m00R+UtvJhbdc65EwBUp0wWDlzW8rz2XmMcC8a28tr6jEv9pyePujvfNfy+RJCv9 nccW4XHCOE54s3k8pXYVj8QBvdz8jhXU+GeUCnYNEZTfs6QpbfBeUIKteNxmah7P3gbk CqMncb9KiPgsFSylDsCr+bCfq4HTO6J2JbbDsm5yuZkyOYm3SIayVnIaYIWmGncrfMRG 0pEo9pb75uwX9lKfCCurSdJvKE1047JChQCT4nlMPC7JpLAw25YtnWMbJTF+WEqOxBiU zzKimUBAETQI/K5OIUHZ9OkhzOrhcRGBPjuQvepCunnuox2dBun/UXWzZ4qK+3n1rMag dFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z0f8x9O/zHxL58ErQekbYNbB+b0vXLeqYxeXczK2D84=; b=ChFeG/QpIktmBXWC4DAu4M8TZuYJSXHt2nu1xQ+hTPqW7M7WrnoJdmAXRpEtoAUh0O VyBLdbvY5QJAocwYESr2EZznUqZNA9eey+2pAP9XfpoQITx28VRIVrIbFO7X3FKxI37h B+KeyGWmxrJU9TJfVUqxKc6/ISCRYxPfd7XRZH7YQrVRQOt2e2VdVbtIqDm+lj7eI+xl bgO3WX6Nmnl2nNHVqp1RsTKVtx9+Lr3QsBk2odJu5dNb43PoOcWiRlyI8nN6Ppr+9l16 Vl2n+Ge3hAx9s2dzYAysuTbuMiRYn8TBt71TKbdghKYJ5mklQjNiH4CZULI17aulZN2Y pl7g== X-Gm-Message-State: AOAM530VLKOE1vUgM0KcpOqTbRb3MnHqT+hwDnQrsxOUpyAr0me8nfHt Clo+w1YzCMfKlJ6zbBHugSdLxQ== X-Google-Smtp-Source: ABdhPJwvj56IQBaQRCPFjp1p3Oj55LJxes0VYp96LUjQ87Yns3LqD49oYT7muIAPMbyivQ9KBLcJbQ== X-Received: by 2002:a1c:e908:: with SMTP id q8mr154811wmc.116.1589818643067; Mon, 18 May 2020 09:17:23 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id o26sm17630940wro.83.2020.05.18.09.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 09:17:22 -0700 (PDT) Date: Mon, 18 May 2020 17:17:20 +0100 From: Daniel Thompson To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Peter Ujfalusi , Tomi Valkeinen , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Douglas Anderson , Jani Nikula , Jonathan Corbet , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Russell King , Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig Subject: Re: [PATCH v2 09/16] backlight: remove the unused backlight_bl driver Message-ID: <20200518161720.n4pjjhiomv7bd27x@holly.lan> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-10-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200517190139.740249-10-sam@ravnborg.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, May 17, 2020 at 09:01:32PM +0200, Sam Ravnborg wrote: > The driver required initialization using struct generic_bl_info. > As there are no more references to this struct there is no users left. > So it is safe to delete the driver. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/Kconfig | 8 -- > drivers/video/backlight/Makefile | 1 - > drivers/video/backlight/generic_bl.c | 110 --------------------------- > include/linux/backlight.h | 9 --- > 4 files changed, 128 deletions(-) > delete mode 100644 drivers/video/backlight/generic_bl.c > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 7d22d7377606..14abfeee8868 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -173,14 +173,6 @@ config BACKLIGHT_EP93XX > To compile this driver as a module, choose M here: the module will > be called ep93xx_bl. > > -config BACKLIGHT_GENERIC > - tristate "Generic (aka Sharp Corgi) Backlight Driver" > - default y > - help > - Say y to enable the generic platform backlight driver previously > - known as the Corgi backlight driver. If you have a Sharp Zaurus > - SL-C7xx, SL-Cxx00 or SL-6000x say y. > - > config BACKLIGHT_IPAQ_MICRO > tristate "iPAQ microcontroller backlight driver" > depends on MFD_IPAQ_MICRO > diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile > index 0c1a1524627a..9b998cfdc56d 100644 > --- a/drivers/video/backlight/Makefile > +++ b/drivers/video/backlight/Makefile > @@ -31,7 +31,6 @@ obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o > obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o > obj-$(CONFIG_BACKLIGHT_DA9052) += da9052_bl.o > obj-$(CONFIG_BACKLIGHT_EP93XX) += ep93xx_bl.o > -obj-$(CONFIG_BACKLIGHT_GENERIC) += generic_bl.o > obj-$(CONFIG_BACKLIGHT_GPIO) += gpio_backlight.o > obj-$(CONFIG_BACKLIGHT_HP680) += hp680_bl.o > obj-$(CONFIG_BACKLIGHT_HP700) += jornada720_bl.o > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > deleted file mode 100644 > index 8fe63dbc8590..000000000000 > --- a/drivers/video/backlight/generic_bl.c > +++ /dev/null > @@ -1,110 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * Generic Backlight Driver > - * > - * Copyright (c) 2004-2008 Richard Purdie > - */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -static int genericbl_intensity; > -static struct backlight_device *generic_backlight_device; > -static struct generic_bl_info *bl_machinfo; > - > -static int genericbl_send_intensity(struct backlight_device *bd) > -{ > - int intensity = bd->props.brightness; > - > - if (bd->props.power != FB_BLANK_UNBLANK) > - intensity = 0; > - if (bd->props.state & BL_CORE_FBBLANK) > - intensity = 0; > - if (bd->props.state & BL_CORE_SUSPENDED) > - intensity = 0; > - > - bl_machinfo->set_bl_intensity(intensity); > - > - genericbl_intensity = intensity; > - > - if (bl_machinfo->kick_battery) > - bl_machinfo->kick_battery(); > - > - return 0; > -} > - > -static int genericbl_get_intensity(struct backlight_device *bd) > -{ > - return genericbl_intensity; > -} > - > -static const struct backlight_ops genericbl_ops = { > - .options = BL_CORE_SUSPENDRESUME, > - .get_brightness = genericbl_get_intensity, > - .update_status = genericbl_send_intensity, > -}; > - > -static int genericbl_probe(struct platform_device *pdev) > -{ > - struct backlight_properties props; > - struct generic_bl_info *machinfo = dev_get_platdata(&pdev->dev); > - const char *name = "generic-bl"; > - struct backlight_device *bd; > - > - bl_machinfo = machinfo; > - if (!machinfo->limit_mask) > - machinfo->limit_mask = -1; > - > - if (machinfo->name) > - name = machinfo->name; > - > - memset(&props, 0, sizeof(struct backlight_properties)); > - props.type = BACKLIGHT_RAW; > - props.max_brightness = machinfo->max_intensity; > - bd = devm_backlight_device_register(&pdev->dev, name, &pdev->dev, > - NULL, &genericbl_ops, &props); > - if (IS_ERR(bd)) > - return PTR_ERR(bd); > - > - platform_set_drvdata(pdev, bd); > - > - bd->props.power = FB_BLANK_UNBLANK; > - bd->props.brightness = machinfo->default_intensity; > - backlight_update_status(bd); > - > - generic_backlight_device = bd; > - > - dev_info(&pdev->dev, "Generic Backlight Driver Initialized.\n"); > - return 0; > -} > - > -static int genericbl_remove(struct platform_device *pdev) > -{ > - struct backlight_device *bd = platform_get_drvdata(pdev); > - > - bd->props.power = 0; > - bd->props.brightness = 0; > - backlight_update_status(bd); > - > - dev_info(&pdev->dev, "Generic Backlight Driver Unloaded\n"); > - return 0; > -} > - > -static struct platform_driver genericbl_driver = { > - .probe = genericbl_probe, > - .remove = genericbl_remove, > - .driver = { > - .name = "generic-bl", > - }, > -}; > - > -module_platform_driver(genericbl_driver); > - > -MODULE_AUTHOR("Richard Purdie "); > -MODULE_DESCRIPTION("Generic Backlight Driver"); > -MODULE_LICENSE("GPL"); > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index b779c29142fd..eae7a5e66248 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -480,15 +480,6 @@ static inline void * bl_get_data(struct backlight_device *bl_dev) > return dev_get_drvdata(&bl_dev->dev); > } > > -struct generic_bl_info { > - const char *name; > - int max_intensity; > - int default_intensity; > - int limit_mask; > - void (*set_bl_intensity)(int intensity); > - void (*kick_battery)(void); > -}; > - > #ifdef CONFIG_OF > struct backlight_device *of_find_backlight_by_node(struct device_node *node); > #else > -- > 2.25.1 >