From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91ECCC433E0 for ; Mon, 18 May 2020 16:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 680AC207ED for ; Mon, 18 May 2020 16:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hZzUaez0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727782AbgERQxz (ORCPT ); Mon, 18 May 2020 12:53:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgERQxy (ORCPT ); Mon, 18 May 2020 12:53:54 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61CD6C05BD09 for ; Mon, 18 May 2020 09:53:54 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id z4so218137wmi.2 for ; Mon, 18 May 2020 09:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JZljDjXdGvVcob0eXcjhvZ4PFqonlurPBCPzjrXqKZA=; b=hZzUaez0ovSogobBcHeVE3JqvDDeQMiT2oySUlSbDtmIyawYcpRbOxI8hmJl6s0c7y SMDE9ezNqr+N/9vHDKmKtscSIV3/46SmW1u6Vq++dUh+uhgOUuHX6Xj04Q3aVGrwaB5m iazdzARoDWGjOdFQArlRlraF18SoTNOim4fkNXz02bTpTJFWq05pigk2PHK4c1Y7ujnx l71NFbdDYj1OEGBd+ZaW3ES3Yxcyjj1cCXJf7RofcMVwCMaPoGKxjOXhIp3vvjlx8Pok 5DsBbZ0E3vC9mwPJTNG/O57sHnsAYbhj+DxU62Dq0t1KXAYfdrvDIXb0PEw3ZP81v+7Y 0ryA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JZljDjXdGvVcob0eXcjhvZ4PFqonlurPBCPzjrXqKZA=; b=SRW0VydbIjdM+Vt5SCRYxA43BJ6J5qschiyOda7ovd0dcoJfA8FtLPYZZshxvxft3c 2kx1gkfbYFuqBR6X0ndT36V66xfA2FGOS8N33I6IEFZpyqapEypqAeL8fJENuwZyO2U1 uvylSwa973GpVAVFxt5eBwwhMJP7sm1Z4etg/Ef+Bry7tKmCxSWv6jF7+JZKB3FOKKfl EjvX3/REBBMvFhHYNO+0D8/jNyK3xcrzpyEJISbJMdSOLWDx8WoBybDeVqQzc+LOGYoR HprMfLWtNDRY4HvEzfvnMoY7nOraTNvfXFcR1cOFx4wV0lXujkmLz7mpwWeL75CL0QG2 hO9Q== X-Gm-Message-State: AOAM533jmXjOIAqvEZMLGfTH4/lQvO2sWuIxBNrNALjBNR7Kjv0FNVeu sM8o6dE0xTLS9N+/pKtcUzROdw== X-Google-Smtp-Source: ABdhPJwhRx8RRhwphNyGm2WHfgeB6JDjOUORJEh8rgps117/wjR+DQtjjESzr3UU9vVN/OuGBYL+hg== X-Received: by 2002:a05:600c:147:: with SMTP id w7mr273163wmm.89.1589820833064; Mon, 18 May 2020 09:53:53 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id m23sm146314wmg.45.2020.05.18.09.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 09:53:52 -0700 (PDT) Date: Mon, 18 May 2020 17:53:50 +0100 From: Daniel Thompson To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Peter Ujfalusi , Tomi Valkeinen , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Douglas Anderson , Jani Nikula , Jonathan Corbet , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Russell King , Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig Subject: Re: [PATCH v2 14/16] backlight: drop backlight_put() Message-ID: <20200518165350.batfdp2tp4rvamzb@holly.lan> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-15-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200517190139.740249-15-sam@ravnborg.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, May 17, 2020 at 09:01:37PM +0200, Sam Ravnborg wrote: > There are no external users of backlight_put(). > Drop it and open code the two users in backlight.c. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/backlight.c | 7 +++++-- > include/linux/backlight.h | 10 ---------- > 2 files changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index e23b09d03a65..7f3eecaf8317 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -679,7 +679,10 @@ static struct backlight_device *of_find_backlight(struct device *dev) > > static void devm_backlight_release(void *data) > { > - backlight_put(data); > + struct backlight_device *bd = data; > + > + if (bd) > + put_device(&bd->dev); > } > > /** > @@ -707,7 +710,7 @@ struct backlight_device *devm_of_find_backlight(struct device *dev) > return bd; > ret = devm_add_action(dev, devm_backlight_release, bd); > if (ret) { > - backlight_put(bd); > + put_device(&bd->dev); > return ERR_PTR(ret); > } > return bd; > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index 99e7cdace2be..d92e523650ec 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -415,16 +415,6 @@ static inline int backlight_disable(struct backlight_device *bd) > return backlight_update_status(bd); > } > > -/** > - * backlight_put - Drop backlight reference > - * @bd: the backlight device to put > - */ > -static inline void backlight_put(struct backlight_device *bd) > -{ > - if (bd) > - put_device(&bd->dev); > -} > - > /** > * backlight_is_blank - Return true if display is expected to be blank > * @bd: the backlight device > -- > 2.25.1 >