From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4693CC433E0 for ; Mon, 18 May 2020 19:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EDD020715 for ; Mon, 18 May 2020 19:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589831848; bh=DRz4DAY0Mnx2npyUdBsc9qwGVxIZLo1A/yWb9iqMvwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TSRCmGTwIzkyT+Tnvli50kv8Ty90oejqkSeh2K05o0c2VSxOsG01/zEz4AJgEuDRp oVW/DHPmwSmgxHyvXZULYhBf8FC1itWVVvdRPMGH+8FDOwg7uJUKrHMaW58YW5dc+W sY50vPHrxOwsw6iJo0wUL0R8V2WrLBPbNB6YFJ1Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbgERT50 (ORCPT ); Mon, 18 May 2020 15:57:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:41980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgERT50 (ORCPT ); Mon, 18 May 2020 15:57:26 -0400 Received: from localhost (unknown [122.178.242.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E35B320657; Mon, 18 May 2020 19:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589831845; bh=DRz4DAY0Mnx2npyUdBsc9qwGVxIZLo1A/yWb9iqMvwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qc0a6OQvdCAEnO3CUTnrYxiYhaPyQTi55+IhPmvKayJnYlwQi4oxEdbuCAAoaqMDa dFImllZ7cfaCePbe7ebGoK91XABYlDlmrHmwm9ncKc6LY2DAeuS62km5DMrPTVNXnA BpsvtV7X7O3awzJsEdsD90yUG11JfNCxNl9brLZE= Date: Tue, 19 May 2020 01:27:19 +0530 From: Vinod Koul To: Anders Roxell , Arnd Bergmann Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v13 3/5] usb: xhci: Add support for Renesas controller with memory Message-ID: <20200518195719.GG374218@vkoul-mobl.Dlink> References: <20200506060025.1535960-1-vkoul@kernel.org> <20200506060025.1535960-4-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Anders, On 18-05-20, 19:53, Anders Roxell wrote: > On Wed, 6 May 2020 at 08:01, Vinod Koul wrote: > > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > loaded. Add these devices in pci table and invoke renesas firmware loader > > functions to check and load the firmware into device memory when > > required. > > > > Signed-off-by: Vinod Koul > > Hi, I got a build error when I built an arm64 allmodconfig kernel. Thanks for this. This is happening as we have default y for USB_XHCI_PCI and then we make USB_XHCI_PCI_RENESAS=m. That should be not allowed as we export as symbol so both can be inbuilt or modules but USB_XHCI_PCI=y and USB_XHCI_PCI_RENESAS=m cant. While it is valid that USB_XHCI_PCI=y|m and USB_XHCI_PCI_RENESAS=n So this seems to get fixed by below for me. I have tested with - both y and m (easy) - make USB_XHCI_PCI_RENESAS=n, USB_XHCI_PCI=y|m works - try making USB_XHCI_PCI=y and USB_XHCI_PCI_RENESAS=m, then USB_XHCI_PCI=m by kbuild :) - try making USB_XHCI_PCI=m and USB_XHCI_PCI_RENESAS=y, kbuild gives error prompt that it will be m due to depends Thanks to all the fixes done by Arnd which pointed me to this. Pls verify and I will send the fix with you as reported :) ---- >8 ---- diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index b5c542d6a1c5..92783d175b3f 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -40,11 +40,11 @@ config USB_XHCI_DBGCAP config USB_XHCI_PCI tristate depends on USB_PCI + depends on USB_XHCI_PCI_RENESAS || !USB_XHCI_PCI_RENESAS default y config USB_XHCI_PCI_RENESAS tristate "Support for additional Renesas xHCI controller with firwmare" - depends on USB_XHCI_PCI ---help--- Say 'Y' to enable the support for the Renesas xHCI controller with firwmare. Make sure you have the firwmare for the device and -- ~Vinod