From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE73C433DF for ; Fri, 22 May 2020 00:05:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C444206BE for ; Fri, 22 May 2020 00:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730105AbgEVAFj (ORCPT ); Thu, 21 May 2020 20:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729771AbgEVAFj (ORCPT ); Thu, 21 May 2020 20:05:39 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 784B6C061A0E; Thu, 21 May 2020 17:05:39 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1CF83120ED486; Thu, 21 May 2020 17:05:39 -0700 (PDT) Date: Thu, 21 May 2020 17:05:38 -0700 (PDT) Message-Id: <20200521.170538.966530806675679298.davem@davemloft.net> To: manivannan.sadhasivam@linaro.org Cc: kuba@kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue() From: David Miller In-Reply-To: <20200519181416.4235-1-manivannan.sadhasivam@linaro.org> References: <20200519181416.4235-1-manivannan.sadhasivam@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 May 2020 17:05:39 -0700 (PDT) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Manivannan Sadhasivam Date: Tue, 19 May 2020 23:44:16 +0530 > Once the traversal of the list is completed with list_for_each_entry(), > the iterator (node) will point to an invalid object. So passing this to > qrtr_local_enqueue() which is outside of the iterator block is erroneous > eventhough the object is not used. > > So fix this by passing NULL to qrtr_local_enqueue(). > > Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Signed-off-by: Manivannan Sadhasivam Applied and queued up for -stable, thanks.