From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: gregkh@linuxfoundation.org
Cc: hemantk@codeaurora.org, jhugo@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [RESEND PATCH 00/14] MHI patches for v5.8
Date: Thu, 21 May 2020 22:32:35 +0530 [thread overview]
Message-ID: <20200521170249.21795-1-manivannan.sadhasivam@linaro.org> (raw)
Hi Greg,
Here is the set of MHI patches for v5.8. Most of the patches are cleanup and
refactoring ones. All of them are reviewed by myself and Jeff and also
verified on x86 and ARM64 architectures for functionality.
Here is the short summary:
-------------------------------------------------------------
- The firmware download was handled by a worker thread which gets scheduled
when the device powers up. But this thread waits until the device gets into
PBL state (notified using PM state worker). Sometimes, there might be delay for
the device to enter PBL state and due to that the firmware worker thread will
timeout. So in order to handle this situation effectively, the firmware load
is now directly called by PM state worker instead of scheduling the thread.
- Return proper error codes incase of error while loading the AMSS firmware
through BHIE protocol
- The MHI register space of the device accepts only non-zero values for the
sequence identifier. But there is a possibility that the host might write zero
(due to the use of prandom_u32() API). Hence, a macro is introduced which
provides non-zero sequence identifiers and used them in all places.
- Moved all common TRE generation code to mhi_gen_tre() function
- The MHI host reads channel ID from the event ring element of the client
device. This ID can be of any value between 0 to 255 but the host may not
support all those IDs. So reject the event ring elements whose channel IDs
are not within the limits of the controller.
- Limit the transfer length read from the client device. This value should
be within the size of the MHI host buffer but there are chances this can
be larger.
- Remove the system worker thread for processing the SYS_ERR condition and
instead call the function directly from EE worker. This is done to avoid
any possible race while MHI shutting down.
- Handle MHI power off in the state worker thread as like MISSION_MODE. This
helps in preventing a possible race condition where a power off is issued by
the controller while processing mission mode.
- Skip the handling of BHI interrupt when the register access is not allowed
due to the device in wrong PM state.
- The write_lock of 'mhi_chan->lock' should only protect 'db_mode'. Hence, use
it properly in places where it is protecting other unwanted regions.
- Reset the client device if it is in SYS_ERR state during power up.
-------------------------------------------------------------
Please consider merging!
Thanks,
Mani
Bhaumik Bhatt (4):
bus: mhi: core: Handle firmware load using state worker
bus: mhi: core: Return appropriate error codes for AMSS load failure
bus: mhi: core: Improve debug logs for loading firmware
bus: mhi: core: Ensure non-zero session or sequence ID values are used
Hemant Kumar (9):
bus: mhi: core: Refactor mhi queue APIs
bus: mhi: core: Cache intmod from mhi event to mhi channel
bus: mhi: core: Add range check for channel id received in event ring
bus: mhi: core: Read transfer length from an event properly
bus: mhi: core: Remove the system error worker thread
bus: mhi: core: Handle disable transitions in state worker
bus: mhi: core: Skip handling BHI irq if MHI reg access is not allowed
bus: mhi: core: Do not process SYS_ERROR if RDDM is supported
bus: mhi: core: Handle write lock properly in mhi_pm_m0_transition
Jeffrey Hugo (1):
bus: mhi: core: Handle syserr during power_up
drivers/bus/mhi/core/boot.c | 75 ++++++------
drivers/bus/mhi/core/init.c | 8 +-
drivers/bus/mhi/core/internal.h | 9 +-
drivers/bus/mhi/core/main.c | 194 ++++++++++++++++++--------------
drivers/bus/mhi/core/pm.c | 86 +++++++++-----
include/linux/mhi.h | 4 -
6 files changed, 217 insertions(+), 159 deletions(-)
--
2.17.1
next reply other threads:[~2020-05-21 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 17:02 Manivannan Sadhasivam [this message]
2020-05-21 17:02 ` [RESEND PATCH 01/14] bus: mhi: core: Refactor mhi queue APIs Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 02/14] bus: mhi: core: Cache intmod from mhi event to mhi channel Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 03/14] bus: mhi: core: Add range check for channel id received in event ring Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 04/14] bus: mhi: core: Read transfer length from an event properly Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 05/14] bus: mhi: core: Handle firmware load using state worker Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 06/14] bus: mhi: core: Return appropriate error codes for AMSS load failure Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 07/14] bus: mhi: core: Improve debug logs for loading firmware Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 08/14] bus: mhi: core: Ensure non-zero session or sequence ID values are used Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 09/14] bus: mhi: core: Remove the system error worker thread Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 10/14] bus: mhi: core: Handle disable transitions in state worker Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 11/14] bus: mhi: core: Skip handling BHI irq if MHI reg access is not allowed Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 12/14] bus: mhi: core: Do not process SYS_ERROR if RDDM is supported Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 13/14] bus: mhi: core: Handle write lock properly in mhi_pm_m0_transition Manivannan Sadhasivam
2020-05-21 17:02 ` [RESEND PATCH 14/14] bus: mhi: core: Handle syserr during power_up Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521170249.21795-1-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).