From: David Miller <davem@davemloft.net>
To: noodles@earth.li
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
adron@yapic.net, marcel@ziswiler.com
Subject: Re: [PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x
Date: Fri, 22 May 2020 16:07:23 -0700 (PDT) [thread overview]
Message-ID: <20200522.160723.1511383489001652430.davem@davemloft.net> (raw)
In-Reply-To: <20200521114934.GY311@earth.li>
From: Jonathan McDowell <noodles@earth.li>
Date: Thu, 21 May 2020 12:49:34 +0100
> The ipq806x_gmac_probe() function enables the PTP clock but not the
> appropriate interface clocks. This means that if the bootloader hasn't
> done so attempting to bring up the interface will fail with an error
> like:
>
> [ 59.028131] ipq806x-gmac-dwmac 37600000.ethernet: Failed to reset the dma
> [ 59.028196] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_hw_setup: DMA engine initialization failed
> [ 59.034056] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_open: Hw setup failed
>
> This patch, a slightly cleaned up version of one posted by Sergey
> Sergeev in:
>
> https://forum.openwrt.org/t/support-for-mikrotik-rb3011uias-rm/4064/257
>
> correctly enables the clock; we have already configured the source just
> before this.
>
> Tested on a MikroTik RB3011.
>
> Signed-off-by: Jonathan McDowell <noodles@earth.li>
Applied, thanks.
prev parent reply other threads:[~2020-05-22 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 11:49 [PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x Jonathan McDowell
2020-05-22 23:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522.160723.1511383489001652430.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adron@yapic.net \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=netdev@vger.kernel.org \
--cc=noodles@earth.li \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).