From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FF9C433E0 for ; Tue, 2 Jun 2020 12:26:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2255620772 for ; Tue, 2 Jun 2020 12:26:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="N4u5fBWe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbgFBM0p (ORCPT ); Tue, 2 Jun 2020 08:26:45 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:36531 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727946AbgFBM0o (ORCPT ); Tue, 2 Jun 2020 08:26:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591100804; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=C4vFOy2XJsfD6EIUJxjhKj637Wme6MC/O/edb1rZV9s=; b=N4u5fBWeOZKcWDONbymnyFpLdd9xKtSZUemVwzTSJyFj6P5X9LRC6A67ePrk87WKg+MLfSq3 37xt2dlh2OOycWE4rX4z+U2Ed/kJjU2pVjv/jYhm9fdnXgESkeCCcp9sNN/i3Cs1AuNiJyOS kQTlOyUl3lwv/jMmhsG1zrc55Uk= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-west-2.postgun.com with SMTP id 5ed6456eeca06aba7ef97483 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 02 Jun 2020 12:26:22 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8F03CC43387; Tue, 2 Jun 2020 12:26:21 +0000 (UTC) Received: from codeaurora.org (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: groverm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 875C2C433C6; Tue, 2 Jun 2020 12:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 875C2C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=groverm@codeaurora.org Date: Tue, 2 Jun 2020 17:56:00 +0530 From: Mayank Grover To: Linus Walleij , Bjorn Andersson Cc: Andy Gross , "open list:GPIO SUBSYSTEM" , MSM , "linux-kernel@vger.kernel.org" , Neeraj Upadhyay Subject: Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid Message-ID: <20200602122600.GA10584@codeaurora.org> References: <1589817025-21886-1-git-send-email-groverm@codeaurora.org> <20200519013813.GU2165@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, May 25, 2020 at 11:02:14AM +0200, Linus Walleij wrote: > On Tue, May 19, 2020 at 3:39 AM Bjorn Andersson > wrote: > > > @Linus, we started off with something similar for GPIOs and ended up > > with the logic in the core code. Should we somehow try to do the same > > for pinctrl? > > msm_pingroup_is_valid() looks very reusable but I'm afraid I do not > understand the implicit assumptions around it, but I guess yes, > if it can be properly documented etc. > > Yours, > Linus Walleij Hi Bjorn, Can you please help guide further on this ? we can validate group using request calls similar to pinmux_ops here. -Mayank