From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20474C433E1 for ; Sun, 21 Jun 2020 07:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E95E224875 for ; Sun, 21 Jun 2020 07:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uClYwbC8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729467AbgFUH6a (ORCPT ); Sun, 21 Jun 2020 03:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729443AbgFUH63 (ORCPT ); Sun, 21 Jun 2020 03:58:29 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66DB7C061796 for ; Sun, 21 Jun 2020 00:58:28 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id d6so6873639pjs.3 for ; Sun, 21 Jun 2020 00:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3KPoOm+bLmC1v50pog5fL9P6LrRZAUQ+2yrNP8FscHk=; b=uClYwbC88vxgeN/XT3nnqSsi99mXsXx7ojH/vj7BsASRLl/1OSX16DO3qjAgjwUXlW NO2c6vjdEKZp9y0wUEeNy2TXN/noDCc8TAeDcj2uBnAbNioTFFCXmuwSnPpBhi8tOJm+ ZFlOGKL2zgYdL7zemvAdWgVw7yu+HG5A1P1UOyAqCYKVVmGs512K+iGxl5Dfj16Zf4cd BlghMbYZN8BlrukCS7rPqEvb9L9rft4Kfk01ZJVKYJSOqbHCdl1dxuDtzBI/gC0GrLco 4IKdaK9YiR2neltB+CWcALTR9hkwoRiFIMpV0iA7/UhY8lIfng7vtOt7UaIQZ3oL7nHh XXqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3KPoOm+bLmC1v50pog5fL9P6LrRZAUQ+2yrNP8FscHk=; b=fX/l90WH9s247QD7VAH9ngjaX/GlNuH2n8xRKE1fqyoFIakBo5/kdoqUwvOQo6ypZ3 HgfFDBngxicI1iJAkoNirinPIt3k9koStiACDkpUPPfWmAKMCcq9AO3Ku9hbPuY9AyQv kjly5utNXpo5/cQ1PnnnU+6jCR8lg1sIcnwk9AQJhKkrqQX5cxkzTW+vbUe+f/P1mPsZ N6eWrMRCwylcWlvdSst04BFTNr0WjoKTuAChM/H22FlK+85c6Qj0kEch/jC8seiDwQIE A9YvnWibvIgx4n9SOKEIY5haG5Kt3ohdZ0KplPIo60ekMezvSQoOBIng7yQacPuELElb knkg== X-Gm-Message-State: AOAM531Ohy2BGXNS0DfAgRDRaeYEA9RIunf8adV8EOKAdCOX65bPUryW evL7zSQZQOoEdwwex9b7fAPqEA== X-Google-Smtp-Source: ABdhPJyYgyRKuQgyEvPMVmdcQi9PG+cATUzGiqQ36JN7poB94jEHsF8HcBDs5rU+G+S7sj/19/hoxA== X-Received: by 2002:a17:90a:308c:: with SMTP id h12mr12261894pjb.194.1592726307108; Sun, 21 Jun 2020 00:58:27 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y6sm10675608pfp.144.2020.06.21.00.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 00:58:26 -0700 (PDT) Date: Sun, 21 Jun 2020 00:55:39 -0700 From: Bjorn Andersson To: Avri Altman Cc: Rob Clark , Asutosh Das , "cang@codeaurora.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , linux-arm-msm , Subhash Jadavani , Alim Akhtar , "James E.J. Bottomley" , Bean Huo , Stanley Chu , Tomas Winkler , Colin Ian King , Bart Van Assche , open list Subject: Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support Message-ID: <20200621075539.GK128451@builder.lan> References: <3c186284280c37c76cf77bf482dde725359b8a8a.1586382357.git.asutoshd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 21 Jun 00:40 PDT 2020, Avri Altman wrote: > > > > > On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das > > wrote: > > > > > > The write performance of TLC NAND is considerably > > > lower than SLC NAND. Using SLC NAND as a WriteBooster > > > Buffer enables the write request to be processed with > > > lower latency and improves the overall write performance. > > > > > > Adds support for shared-buffer mode WriteBooster. > > > > > > WriteBooster enable: SW enables it when clocks are > > > scaled up, thus it's enabled only in high load conditions. > > > > > > WriteBooster disable: SW will disable the feature, > > > when clocks are scaled down. Thus writes would go as normal > > > writes. > > > > btw, in v5.8-rc1 (plus handful of remaining patches for lenovo c630 > > laptop (sdm850)), I'm seeing a lot of: > > > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > idn 14 failed, err = 253 > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > idn 14 failed, err = 253 > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag_retry: query attribute, > > opcode 6, idn 14, failed with error 253 after 3 retires > > ufshcd-qcom 1d84000.ufshc: ufshcd_wb_ctrl write booster enable failed 253 > > > > and at least subjectively, compiling mesa seems slower, which seems > > like it might be related? > This looks like a device issue to be taken with the flash vendor: There's no way for a end-user to file a bug report with the flash vendor on a device bought from an OEM and even if they would accept the bug report they wouldn't re-provision the flash in an shipped device. So you will have to work around this in the driver. Regards, Bjorn > The device reports that it supports wd, but returns inalid idn for flag 0xe... > > Thanks, > Avri