From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: rishabhb@codeaurora.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
tsoni@codeaurora.org, sidgup@codeaurora.org,
stable@vger.kernel.org
Subject: Re: [RESEND v1] soc: qcom: pdr: Reorder the PD state indication ack
Date: Mon, 27 Jul 2020 23:08:57 -0700 [thread overview]
Message-ID: <20200728060857.GB202429@builder.lan> (raw)
In-Reply-To: <20200701195954.9007-1-sibis@codeaurora.org>
On Wed 01 Jul 12:59 PDT 2020, Sibi Sankar wrote:
> The Protection Domains (PD) have a mechanism to keep its resources
> enabled until the PD down indication is acked. Reorder the PD state
> indication ack so that clients get to release the relevant resources
> before the PD goes down.
>
> Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
> Reported-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> I couldn't find the previous patch on patchworks. Resending the patch
> since it would need to land on stable trees as well
>
> drivers/soc/qcom/pdr_interface.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interface.c
> index a90d707da6894..088dc99f77f3f 100644
> --- a/drivers/soc/qcom/pdr_interface.c
> +++ b/drivers/soc/qcom/pdr_interface.c
> @@ -279,13 +279,15 @@ static void pdr_indack_work(struct work_struct *work)
>
> list_for_each_entry_safe(ind, tmp, &pdr->indack_list, node) {
> pds = ind->pds;
> - pdr_send_indack_msg(pdr, pds, ind->transaction_id);
>
> mutex_lock(&pdr->status_lock);
> pds->state = ind->curr_state;
> pdr->status(pds->state, pds->service_path, pdr->priv);
> mutex_unlock(&pdr->status_lock);
>
> + /* Ack the indication after clients release the PD resources */
> + pdr_send_indack_msg(pdr, pds, ind->transaction_id);
> +
> mutex_lock(&pdr->list_lock);
> list_del(&ind->node);
> mutex_unlock(&pdr->list_lock);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2020-07-28 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 19:59 [RESEND v1] soc: qcom: pdr: Reorder the PD state indication ack Sibi Sankar
2020-07-09 16:09 ` rishabhb
2020-07-28 6:08 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728060857.GB202429@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).