Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc
@ 2020-07-29  7:44 Krzysztof Kozlowski
  2020-07-29  7:44 ` [PATCH 2/2] soc: qcom: smd-rpm: " Krzysztof Kozlowski
  2020-07-29  7:53 ` [PATCH 1/2] soc: mediatek: mtk-infracfg: " Matthias Brugger
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-29  7:44 UTC (permalink / raw)
  To: Matthias Brugger, Andy Gross, Bjorn Andersson, linux-arm-kernel,
	linux-mediatek, linux-kernel, linux-arm-msm
  Cc: Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

    drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection'
    drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/soc/mediatek/mtk-infracfg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-infracfg.c b/drivers/soc/mediatek/mtk-infracfg.c
index 341c7ac250e3..4a123796aad3 100644
--- a/drivers/soc/mediatek/mtk-infracfg.c
+++ b/drivers/soc/mediatek/mtk-infracfg.c
@@ -19,7 +19,7 @@
 
 /**
  * mtk_infracfg_set_bus_protection - enable bus protection
- * @regmap: The infracfg regmap
+ * @infracfg: The infracfg regmap
  * @mask: The mask containing the protection bits to be enabled.
  * @reg_update: The boolean flag determines to set the protection bits
  *              by regmap_update_bits with enable register(PROTECTEN) or
@@ -50,7 +50,7 @@ int mtk_infracfg_set_bus_protection(struct regmap *infracfg, u32 mask,
 
 /**
  * mtk_infracfg_clear_bus_protection - disable bus protection
- * @regmap: The infracfg regmap
+ * @infracfg: The infracfg regmap
  * @mask: The mask containing the protection bits to be disabled.
  * @reg_update: The boolean flag determines to clear the protection bits
  *              by regmap_update_bits with enable register(PROTECTEN) or
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc
  2020-07-29  7:44 [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc Krzysztof Kozlowski
@ 2020-07-29  7:44 ` Krzysztof Kozlowski
  2020-07-29 20:46   ` Bjorn Andersson
  2020-07-29  7:53 ` [PATCH 1/2] soc: mediatek: mtk-infracfg: " Matthias Brugger
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-29  7:44 UTC (permalink / raw)
  To: Matthias Brugger, Andy Gross, Bjorn Andersson, linux-arm-kernel,
	linux-mediatek, linux-kernel, linux-arm-msm
  Cc: Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

    drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member 'dev' not described in 'qcom_smd_rpm'
    drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member 'state' not described in 'qcom_rpm_smd_write'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/soc/qcom/smd-rpm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
index 877b13850730..1d4eb46b417a 100644
--- a/drivers/soc/qcom/smd-rpm.c
+++ b/drivers/soc/qcom/smd-rpm.c
@@ -20,6 +20,7 @@
  * struct qcom_smd_rpm - state of the rpm device driver
  * @rpm_channel:	reference to the smd channel
  * @icc:		interconnect proxy device
+ * @dev:		rpm device
  * @ack:		completion for acks
  * @lock:		mutual exclusion around the send/complete pair
  * @ack_status:		result of the rpm request
@@ -86,6 +87,7 @@ struct qcom_rpm_message {
 /**
  * qcom_rpm_smd_write - write @buf to @type:@id
  * @rpm:	rpm handle
+ * @state:	active/sleep state flags
  * @type:	resource type
  * @id:		resource identifier
  * @buf:	the data to be written
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc
  2020-07-29  7:44 [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc Krzysztof Kozlowski
  2020-07-29  7:44 ` [PATCH 2/2] soc: qcom: smd-rpm: " Krzysztof Kozlowski
@ 2020-07-29  7:53 ` Matthias Brugger
  1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-07-29  7:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
	linux-arm-kernel, linux-mediatek, linux-kernel, linux-arm-msm



On 29/07/2020 09:44, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
> 
>      drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection'
>      drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Queued for v5.9-next/soc

Thanks
Matthias

> ---
>   drivers/soc/mediatek/mtk-infracfg.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-infracfg.c b/drivers/soc/mediatek/mtk-infracfg.c
> index 341c7ac250e3..4a123796aad3 100644
> --- a/drivers/soc/mediatek/mtk-infracfg.c
> +++ b/drivers/soc/mediatek/mtk-infracfg.c
> @@ -19,7 +19,7 @@
>   
>   /**
>    * mtk_infracfg_set_bus_protection - enable bus protection
> - * @regmap: The infracfg regmap
> + * @infracfg: The infracfg regmap
>    * @mask: The mask containing the protection bits to be enabled.
>    * @reg_update: The boolean flag determines to set the protection bits
>    *              by regmap_update_bits with enable register(PROTECTEN) or
> @@ -50,7 +50,7 @@ int mtk_infracfg_set_bus_protection(struct regmap *infracfg, u32 mask,
>   
>   /**
>    * mtk_infracfg_clear_bus_protection - disable bus protection
> - * @regmap: The infracfg regmap
> + * @infracfg: The infracfg regmap
>    * @mask: The mask containing the protection bits to be disabled.
>    * @reg_update: The boolean flag determines to clear the protection bits
>    *              by regmap_update_bits with enable register(PROTECTEN) or
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc
  2020-07-29  7:44 ` [PATCH 2/2] soc: qcom: smd-rpm: " Krzysztof Kozlowski
@ 2020-07-29 20:46   ` Bjorn Andersson
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-07-29 20:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Matthias Brugger, Andy Gross, linux-arm-kernel, linux-mediatek,
	linux-kernel, linux-arm-msm

On Wed 29 Jul 00:44 PDT 2020, Krzysztof Kozlowski wrote:

> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member 'dev' not described in 'qcom_smd_rpm'
>     drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member 'state' not described in 'qcom_rpm_smd_write'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thanks for spotting these, applied.

PS. This doesn't have any relationship with the Mediatek patch, the two
goes through different maintainer trees and my manual mailbox filter
almost discarded the series. So please send patches like this
individually in the future.

Thanks,
Bjorn

> ---
>  drivers/soc/qcom/smd-rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
> index 877b13850730..1d4eb46b417a 100644
> --- a/drivers/soc/qcom/smd-rpm.c
> +++ b/drivers/soc/qcom/smd-rpm.c
> @@ -20,6 +20,7 @@
>   * struct qcom_smd_rpm - state of the rpm device driver
>   * @rpm_channel:	reference to the smd channel
>   * @icc:		interconnect proxy device
> + * @dev:		rpm device
>   * @ack:		completion for acks
>   * @lock:		mutual exclusion around the send/complete pair
>   * @ack_status:		result of the rpm request
> @@ -86,6 +87,7 @@ struct qcom_rpm_message {
>  /**
>   * qcom_rpm_smd_write - write @buf to @type:@id
>   * @rpm:	rpm handle
> + * @state:	active/sleep state flags
>   * @type:	resource type
>   * @id:		resource identifier
>   * @buf:	the data to be written
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29  7:44 [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc Krzysztof Kozlowski
2020-07-29  7:44 ` [PATCH 2/2] soc: qcom: smd-rpm: " Krzysztof Kozlowski
2020-07-29 20:46   ` Bjorn Andersson
2020-07-29  7:53 ` [PATCH 1/2] soc: mediatek: mtk-infracfg: " Matthias Brugger

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git