From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C97EC433E1 for ; Fri, 31 Jul 2020 18:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3CB621744 for ; Fri, 31 Jul 2020 18:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596220376; bh=V94zdN5H+e3SBeRoUvNUIb+YtxH496y/vXGq3vfRfWg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gGBR526wmVn6TRirjfhXoyO+phil1sMUm7DeLuTr1DpxW+uy7MCDxXwBSlpoy4Om4 LhnhPh2jKfEkMhCLDF/OL2KCffXCyA0HLBz2YXo6Z0/qxQjR9MRgS5FqMjbp/JN5zN kXK49Ieiik+ws3paPtVNYmGMOQhO0PChEbipUVEw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387796AbgGaScw (ORCPT ); Fri, 31 Jul 2020 14:32:52 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:42999 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730040AbgGaScw (ORCPT ); Fri, 31 Jul 2020 14:32:52 -0400 Received: by mail-il1-f194.google.com with SMTP id i138so20207057ild.9; Fri, 31 Jul 2020 11:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EowHBI4dMeGjG0e5BJ+8WQXeSAJSfhXVUUltMQUkAHk=; b=BeCj8lP5ss1j7OCimCq7XgBPaNitajuugE63xDMXHJq2tdUBMbVs0ABM/w9atGqfkW hUhVNCj25D9iT58Dygzu+o0HzJmgpm2P3wHOaPbS2EzdxqLvWFrL4CdUy4HiJeR4fyuX zso5Yga4bspXmdveiYHHKhcnPjmrwvGwFZTOeIHn9gpeOv+lK2wk0iBh2VC6GOuKTnJ8 qd9STP4MFYD9YM0Gc+3x9nLRUYH1TZLCeb0KNT+fo9qV/tt19Ne2M+rVvVDrLs4DmkZz w3Fr2zRItV5Bdi5gX74wCPjh9md+xwDlUZPq4tlSddEKX2wUYYD7a7jhgwK+kPyEP2lm sFug== X-Gm-Message-State: AOAM531QcqbXsvUrzAqV5ky7HNI7alU7eU3brfU6dIsZJsxv9zfjEkES HogumDVgT6P4TFMYtfuLsxHlFx3udg== X-Google-Smtp-Source: ABdhPJyRXrrrBCybFoJ4FQVs6g+pcQdN2eOBcJP56L5uwDXTsMph9xwyQUcqO122bYXED9rj7MLeUg== X-Received: by 2002:a92:9687:: with SMTP id g129mr4824817ilh.219.1596220371327; Fri, 31 Jul 2020 11:32:51 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id y8sm5097640ilq.21.2020.07.31.11.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 11:32:50 -0700 (PDT) Received: (nullmailer pid 540647 invoked by uid 1000); Fri, 31 Jul 2020 18:32:48 -0000 Date: Fri, 31 Jul 2020 12:32:48 -0600 From: Rob Herring To: Cheng-Yi Chiang Cc: linux-kernel@vger.kernel.org, Mark Brown , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Srini Kandagatla , Stephan Gerhold , dianders@chromium.org, dgreid@chromium.org, tzungbi@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Message-ID: <20200731183248.GB531472@bogus> References: <20200731084023.2678931-1-cychiang@chromium.org> <20200731084023.2678931-2-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731084023.2678931-2-cychiang@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jul 31, 2020 at 04:40:22PM +0800, Cheng-Yi Chiang wrote: > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/qcom,sc7180.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > new file mode 100644 > index 000000000000..ce8a5a2d9df9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +definitions: Please don't use 'definitions'. Either just duplicate it or you can do 'patternProperties'. > + > + dai: > + type: object > + properties: > + sound-dai: > + maxItems: 1 > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: phandle array of the codec or CPU DAI This is a common property. You can assume we have a common schema definition for it. IOW, 'sound-dai: true' is enough as it's always a single phandle+args. > + > + required: > + - sound-dai > + > +properties: > + compatible: > + contains: > + const: qcom,sc7180-sndcard > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + aux-dev: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the codec for headset detection > + > +patternProperties: > + "^dai-link(@[0-9]+)?$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + cpu: > + $ref: "#/definitions/dai" > + > + codec: > + $ref: "#/definitions/dai" > + > + required: > + - link-name > + - cpu > + - codec > + > + additionalProperties: false > + > +examples: > + > + - | > + sound { > + compatible = "qcom,sc7180-sndcard"; > + model = "sc7180-snd-card"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + aux-dev = <&alc5682>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + }; > -- > 2.28.0.163.g6104cc2f0b6-goog >