From: Viresh Kumar <viresh.kumar@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: rjw@rjwysocki.net, robh+dt@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, amitk@kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dmitry.baryshkov@linaro.org, tdas@codeaurora.org
Subject: Re: [PATCH 7/7] cpufreq: qcom-hw: Use devm_platform_ioremap_resource() to simplify code
Date: Tue, 8 Sep 2020 16:06:25 +0530 [thread overview]
Message-ID: <20200908103625.swla4uoxxb3hj2w2@vireshk-i7> (raw)
In-Reply-To: <20200908075716.30357-8-manivannan.sadhasivam@linaro.org>
On 08-09-20, 13:27, Manivannan Sadhasivam wrote:
> devm_platform_ioremap_resource() is the combination of
> platform_get_resource() and devm_ioremap_resource(). Hence, use it to
> simplify the code a bit.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/cpufreq/qcom-cpufreq-hw.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> index c3c397cc3dc6..6eeeb2bd4dfa 100644
> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> @@ -307,7 +307,6 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
> struct of_phandle_args args;
> struct device_node *cpu_np;
> struct device *cpu_dev;
> - struct resource *res;
> void __iomem *base;
> struct qcom_cpufreq_data *data;
> const struct of_device_id *match;
> @@ -333,13 +332,9 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
>
> index = args.args[0];
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, index);
> - if (!res)
> - return -ENODEV;
> -
> - base = devm_ioremap(dev, res->start, resource_size(res));
> - if (!base)
> - return -ENOMEM;
> + base = devm_platform_ioremap_resource(pdev, index);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
>
> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> if (!data) {
Keep such patches at the top, so they could be independently applied.
--
viresh
next prev parent reply other threads:[~2020-09-08 10:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 7:57 [PATCH 0/7] Add CPUFreq support for SM8250 SoC Manivannan Sadhasivam
2020-09-08 7:57 ` [PATCH 1/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8250 compatible Manivannan Sadhasivam
2020-09-08 11:56 ` Amit Kucheria
2020-09-08 14:58 ` Bjorn Andersson
2020-09-08 15:10 ` Manivannan Sadhasivam
2020-09-15 16:38 ` Rob Herring
2020-09-08 7:57 ` [PATCH 2/7] arm64: dts: qcom: sm8250: Add cpufreq hw node Manivannan Sadhasivam
2020-09-08 10:39 ` Viresh Kumar
2020-09-08 11:08 ` Manivannan Sadhasivam
2020-09-08 11:12 ` Viresh Kumar
2020-09-08 11:56 ` Amit Kucheria
2020-09-08 7:57 ` [PATCH 3/7] cpufreq: qcom-hw: Make use of cpufreq driver_data for passing pdev Manivannan Sadhasivam
2020-09-08 10:31 ` Viresh Kumar
2020-09-08 7:57 ` [PATCH 4/7] cpufreq: qcom-hw: Make use of of_match data for offsets and row size Manivannan Sadhasivam
2020-09-08 12:18 ` Amit Kucheria
2020-09-08 15:09 ` Manivannan Sadhasivam
2020-09-08 17:06 ` Amit Kucheria
2020-09-08 15:31 ` Bjorn Andersson
2020-09-08 7:57 ` [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers Manivannan Sadhasivam
2020-09-08 10:34 ` Viresh Kumar
2020-09-08 11:11 ` Manivannan Sadhasivam
2020-09-08 11:18 ` Viresh Kumar
2020-09-08 11:28 ` Manivannan Sadhasivam
2020-09-08 11:48 ` Amit Kucheria
2020-09-08 12:08 ` Amit Kucheria
2020-09-08 15:03 ` Manivannan Sadhasivam
2020-09-09 4:35 ` Viresh Kumar
2020-09-08 14:08 ` Sudeep Holla
2020-09-08 15:39 ` Bjorn Andersson
2020-09-08 7:57 ` [PATCH 6/7] cpufreq: qcom-hw: Add cpufreq support for SM8250 SoC Manivannan Sadhasivam
2020-09-08 12:10 ` Amit Kucheria
2020-09-08 15:22 ` Bjorn Andersson
2020-09-08 15:29 ` Manivannan Sadhasivam
2020-09-08 7:57 ` [PATCH 7/7] cpufreq: qcom-hw: Use devm_platform_ioremap_resource() to simplify code Manivannan Sadhasivam
2020-09-08 10:36 ` Viresh Kumar [this message]
2020-09-08 11:12 ` Manivannan Sadhasivam
2020-09-08 12:00 ` Amit Kucheria
2020-09-08 15:35 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908103625.swla4uoxxb3hj2w2@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).