* [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk
@ 2020-09-14 9:18 Dmitry Baryshkov
2020-09-14 10:29 ` Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2020-09-14 9:18 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Linus Walleij
Cc: linux-arm-msm, linux-gpio, Manivannan Sadhasivam
Correct sdc2_clk pin definition (register offset is wrong, verified by
the msm-4.19 driver).
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a
---
drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
index a660f1274b66..826df0d637ea 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
@@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = {
[178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _),
[179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _),
[180] = UFS_RESET(ufs_reset, 0xb8000),
- [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6),
+ [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6),
[182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3),
[183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0),
};
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk
2020-09-14 9:18 [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk Dmitry Baryshkov
@ 2020-09-14 10:29 ` Manivannan Sadhasivam
2020-09-14 14:35 ` Bjorn Andersson
2020-09-29 12:56 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-14 10:29 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Linus Walleij, linux-arm-msm, linux-gpio
On Mon, Sep 14, 2020 at 12:18:46PM +0300, Dmitry Baryshkov wrote:
> Correct sdc2_clk pin definition (register offset is wrong, verified by
> the msm-4.19 driver).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a
> ---
> drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> index a660f1274b66..826df0d637ea 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = {
> [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _),
> [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _),
> [180] = UFS_RESET(ufs_reset, 0xb8000),
> - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6),
> + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6),
> [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3),
> [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0),
> };
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk
2020-09-14 9:18 [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk Dmitry Baryshkov
2020-09-14 10:29 ` Manivannan Sadhasivam
@ 2020-09-14 14:35 ` Bjorn Andersson
2020-09-29 12:56 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-09-14 14:35 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Linus Walleij, linux-arm-msm, linux-gpio,
Manivannan Sadhasivam
On Mon 14 Sep 04:18 CDT 2020, Dmitry Baryshkov wrote:
> Correct sdc2_clk pin definition (register offset is wrong, verified by
> the msm-4.19 driver).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> index a660f1274b66..826df0d637ea 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = {
> [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _),
> [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _),
> [180] = UFS_RESET(ufs_reset, 0xb8000),
> - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6),
> + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6),
> [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3),
> [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0),
> };
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk
2020-09-14 9:18 [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk Dmitry Baryshkov
2020-09-14 10:29 ` Manivannan Sadhasivam
2020-09-14 14:35 ` Bjorn Andersson
@ 2020-09-29 12:56 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-09-29 12:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, MSM, open list:GPIO SUBSYSTEM,
Manivannan Sadhasivam
On Mon, Sep 14, 2020 at 11:18 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
> Correct sdc2_clk pin definition (register offset is wrong, verified by
> the msm-4.19 driver).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a
Patch applied for fixes!
Thanks for sorting this out.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-29 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 9:18 [PATCH v3] pinctrl: qcom: sm8250: correct sdc2_clk Dmitry Baryshkov
2020-09-14 10:29 ` Manivannan Sadhasivam
2020-09-14 14:35 ` Bjorn Andersson
2020-09-29 12:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).