Re: [PATCH 1/3] media: venus: pm_helper: Commonize v3/v4 pmdomains and clocks management

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3639 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20200925]
[cannot apply to v5.9-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/kholk11-gmail-com/Qualcomm-Venus-enablement-for-SDM630-636-660/20200926-205558
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a002-20200925 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project a83eb048cb9a75da7a07a9d5318bbdbf54885c87)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/144283cb3c0b5f0dbd7083ea6eec2b5f049ca9c2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review kholk11-gmail-com/Qualcomm-Venus-enablement-for-SDM630-636-660/20200926-205558
        git checkout 144283cb3c0b5f0dbd7083ea6eec2b5f049ca9c2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/qcom/venus/pm_helpers.c:496:12: warning: address of array 'core->vcodec1_clks' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (core->vcodec1_clks) {
           ~~  ~~~~~~^~~~~~~~~~~~
   1 warning generated.

vim +496 drivers/media/platform/qcom/venus/pm_helpers.c

   476	
   477	static int core_get_v4(struct device *dev)
   478	{
   479		struct venus_core *core = dev_get_drvdata(dev);
   480		const struct venus_resources *res = core->res;
   481		int ret;
   482	
   483		ret = core_clks_get(core);
   484		if (ret)
   485			return ret;
   486	
   487		if (!res->vcodec_pmdomains_num)
   488			legacy_binding = true;
   489	
   490		dev_info(dev, "%s legacy binding\n", legacy_binding ? "" : "non");
   491	
   492		ret = vcodec_clks_get(core, dev, core->vcodec0_clks, res->vcodec0_clks);
   493		if (ret)
   494			return ret;
   495	
 > 496		if (core->vcodec1_clks) {
   497			ret = vcodec_clks_get(core, dev,
   498					      core->vcodec1_clks, res->vcodec1_clks);
   499			if (ret)
   500				return ret;
   501		}
   502	
   503		if (legacy_binding)
   504			return 0;
   505	
   506		core->opp_table = dev_pm_opp_set_clkname(dev, "core");
   507		if (IS_ERR(core->opp_table))
   508			return PTR_ERR(core->opp_table);
   509	
   510		if (core->res->opp_pmdomain) {
   511			ret = dev_pm_opp_of_add_table(dev);
   512			if (!ret) {
   513				core->has_opp_table = true;
   514			} else if (ret != -ENODEV) {
   515				dev_err(dev, "invalid OPP table in device tree\n");
   516				dev_pm_opp_put_clkname(core->opp_table);
   517				return ret;
   518			}
   519		}
   520	
   521		ret = vcodec_domains_get(dev);
   522		if (ret) {
   523			if (core->has_opp_table)
   524				dev_pm_opp_of_remove_table(dev);
   525			dev_pm_opp_put_clkname(core->opp_table);
   526			return ret;
   527		}
   528	
   529		return 0;
   530	}
   531	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36979 bytes --]