From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C7FC2D0A8 for ; Sun, 27 Sep 2020 03:12:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CECD239E7 for ; Sun, 27 Sep 2020 03:12:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ay95vNzZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730224AbgI0DMy (ORCPT ); Sat, 26 Sep 2020 23:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgI0DMw (ORCPT ); Sat, 26 Sep 2020 23:12:52 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3396FC0613D3 for ; Sat, 26 Sep 2020 20:12:51 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id jw11so1609923pjb.0 for ; Sat, 26 Sep 2020 20:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DcLFy45aJ1dojeOg6m9cm4hJQ4RA1hO34dYnxlEqMMs=; b=Ay95vNzZnLgsxMMnV0+jDP93YfiAN/5MKSmPbbqbrXFV/BxUp/2bhcOLvVLk0vkbJw D9IuA38+FlDMk2VM7FechUhOgt6MaEhB0v8LsEDvvXIlFnt9sDjo2QhzbjGC30fYy8KK u4XzZQG2VyURy3xHbgCGCcwJBG5l+GWEhp2/D6urC4CsNVsE+Cn8sCNoQ6yqhdXBoj88 4pTJrl+RuzoHN68TjHnSlBaApNpZdslKTaiycWBWNSbMGam0Yx8DBQxshitD+uA/ij21 PnvtfeIjJ0flqUTNGLlOMJ75xgi14yZknsLoWknISBt7Ix0BMHIOQbMHHa67AtMfMnmL c0dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DcLFy45aJ1dojeOg6m9cm4hJQ4RA1hO34dYnxlEqMMs=; b=LOUOUkFLAAHauZ0wOZkWMaYUjN3KxbZwFvIwpOf2ZxtX8LFjD9j9zAJHjc/1gSIMBw hCH9QDhH/QiWYPI+YxZBaBP5GGOFHamkwkq5/aZU4ARX/Xru3Qr7pyAnwP//jQRrU4Hn 78pcMIpeYwYnePVDcZ8Pq2X0258qHnU0nscT/ealqQOzCxgMKMckOlB3lmdwj4FJcfy9 e4vmiwFqT2TbnfWOtoeI2gw6Md7nv6n19jyEpUmz2qx2BZB1cuF8/Vz5Fl2RGFd9mKw6 H9yYk2Ij8jjBdoeoMiYAZjXiUWV+lK3iKYbVvm1qAiBtVlAOSMlzmm6BHLcoaiPgwugo 2mpA== X-Gm-Message-State: AOAM531cctk0J9+Ds6ktf/+DztbxLmpev0hpU3QmVWUmfDEwId44K2c1 QUsYRKSyuP9dWA9aqOIXUuORK24ZTKZg X-Google-Smtp-Source: ABdhPJxPRsomfxnafyvL2kOp2w1ggyU8sHr5P2UYeo/aA6azjFVw8D9asNXNk1uNy2Lr+y4ym5OIGA== X-Received: by 2002:a17:90b:209:: with SMTP id fy9mr4018429pjb.189.1601176370604; Sat, 26 Sep 2020 20:12:50 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:198:cd53:8f:5b5c:829a:cfde]) by smtp.gmail.com with ESMTPSA id q190sm7065351pfc.176.2020.09.26.20.12.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Sep 2020 20:12:49 -0700 (PDT) Date: Sun, 27 Sep 2020 08:42:43 +0530 From: Manivannan Sadhasivam To: Hemant Kumar Cc: gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jhugo@codeaurora.org, bbhatt@codeaurora.org Subject: Re: [PATCH v6 1/4] bus: mhi: core: Add helper API to return number of free TREs Message-ID: <20200927031243.GD3213@Mani-XPS-13-9360> References: <1600286167-4432-1-git-send-email-hemantk@codeaurora.org> <1600286167-4432-2-git-send-email-hemantk@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600286167-4432-2-git-send-email-hemantk@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Sep 16, 2020 at 12:56:04PM -0700, Hemant Kumar wrote: > Introduce mhi_get_no_free_descriptors() API to return number > of TREs available to queue buffer. MHI clients can use this > API to know before hand if ring is full without calling queue > API. > > Signed-off-by: Hemant Kumar > --- > drivers/bus/mhi/core/main.c | 12 ++++++++++++ > include/linux/mhi.h | 9 +++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2cff5dd..0599e7d 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -258,6 +258,18 @@ int mhi_destroy_device(struct device *dev, void *data) > return 0; > } > > +int mhi_get_no_free_descriptors(struct mhi_device *mhi_dev, > + enum dma_data_direction dir) > +{ > + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; > + struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ? > + mhi_dev->ul_chan : mhi_dev->dl_chan; > + struct mhi_ring *tre_ring = &mhi_chan->tre_ring; > + > + return get_nr_avail_ring_elements(mhi_cntrl, tre_ring); Hmm, so this is essentially a wrapper for get_nr_avail_ring_elements(). Why can't you call this API directly? > +} > +EXPORT_SYMBOL_GPL(mhi_get_no_free_descriptors); > + > void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason) > { > struct mhi_driver *mhi_drv; > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index a35d876..6565528 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -600,6 +600,15 @@ void mhi_set_mhi_state(struct mhi_controller *mhi_cntrl, > void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason); > > /** > + * mhi_get_no_free_descriptors - Get transfer ring length mhi_get_nr_free_descriptors? > + * Get # of TD available to queue buffers > + * @mhi_dev: Device associated with the channels > + * @dir: Direction of the channel > + */ > +int mhi_get_no_free_descriptors(struct mhi_device *mhi_dev, > + enum dma_data_direction dir); Align enum with start of "(" Thanks, Mani > + > +/** > * mhi_prepare_for_power_up - Do pre-initialization before power up. > * This is optional, call this before power up if > * the controller does not want bus framework to > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >