From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, Tejun Heo <tj@kernel.org>,
timmurray@google.com, Daniel Vetter <daniel@ffwll.ch>,
Qais Yousef <qais.yousef@arm.com>,
Rob Clark <robdclark@chromium.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2 1/3] drm/crtc: Introduce per-crtc kworker
Date: Wed, 30 Sep 2020 14:17:20 -0700 [thread overview]
Message-ID: <20200930211723.3028059-2-robdclark@gmail.com> (raw)
In-Reply-To: <20200930211723.3028059-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
This will be used for non-block atomic commits.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/drm_crtc.c | 11 +++++++++++
include/drm/drm_crtc.h | 8 ++++++++
2 files changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index aecdd7ea26dc..4f7c0bfce0a3 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -326,6 +326,14 @@ int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc,
config->prop_out_fence_ptr, 0);
drm_object_attach_property(&crtc->base,
config->prop_vrr_enabled, 0);
+
+ crtc->worker = kthread_create_worker(0, "%s-worker", crtc->name);
+ if (IS_ERR(crtc->worker)) {
+ drm_mode_object_unregister(dev, &crtc->base);
+ ret = PTR_ERR(crtc->worker);
+ crtc->worker = NULL;
+ return ret;
+ }
}
return 0;
@@ -366,6 +374,9 @@ void drm_crtc_cleanup(struct drm_crtc *crtc)
kfree(crtc->name);
+ if (crtc->worker)
+ kthread_destroy_worker(crtc->worker);
+
memset(crtc, 0, sizeof(*crtc));
}
EXPORT_SYMBOL(drm_crtc_cleanup);
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 59b51a09cae6..dfdb04619b0d 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -30,6 +30,7 @@
#include <linux/types.h>
#include <linux/fb.h>
#include <linux/hdmi.h>
+#include <linux/kthread.h>
#include <linux/media-bus-format.h>
#include <uapi/drm/drm_mode.h>
#include <uapi/drm/drm_fourcc.h>
@@ -1172,6 +1173,13 @@ struct drm_crtc {
* Initialized via drm_self_refresh_helper_init().
*/
struct drm_self_refresh_data *self_refresh_data;
+
+ /**
+ * @worker:
+ *
+ * Per-CRTC worker for nonblock atomic commits.
+ */
+ struct kthread_worker *worker;
};
/**
--
2.26.2
next prev parent reply other threads:[~2020-09-30 21:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 21:17 [PATCH v2 0/3] drm: commit_work scheduling Rob Clark
2020-09-30 21:17 ` Rob Clark [this message]
2020-09-30 21:17 ` [PATCH v2 2/3] drm/atomic: Use kthread worker for nonblocking commits Rob Clark
2020-09-30 21:17 ` [PATCH v2 3/3] drm: Expose CRTC's kworker task id Rob Clark
2020-10-01 7:25 ` [PATCH v2 0/3] drm: commit_work scheduling Daniel Vetter
2020-10-01 15:15 ` Rob Clark
2020-10-01 15:25 ` Daniel Vetter
2020-10-02 10:52 ` Ville Syrjälä
2020-10-02 11:05 ` Ville Syrjälä
2020-10-02 17:55 ` Rob Clark
2020-10-05 12:15 ` Ville Syrjälä
2020-10-05 14:15 ` Daniel Vetter
2020-10-05 22:58 ` Rob Clark
2020-10-07 16:44 ` Rob Clark
2020-10-08 8:24 ` Ville Syrjälä
2020-10-16 16:27 ` Rob Clark
2020-10-02 11:01 ` Qais Yousef
2020-10-02 18:07 ` Rob Clark
2020-10-05 15:00 ` Qais Yousef
2020-10-05 23:24 ` Rob Clark
2020-10-06 9:08 ` Daniel Vetter
2020-10-06 10:01 ` Peter Zijlstra
2020-10-06 10:59 ` Qais Yousef
2020-10-06 20:04 ` Rob Clark
2020-10-07 10:36 ` Qais Yousef
2020-10-07 15:57 ` Rob Clark
2020-10-07 16:30 ` Qais Yousef
2020-10-08 9:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930211723.3028059-2-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=qais.yousef@arm.com \
--cc=robdclark@chromium.org \
--cc=timmurray@google.com \
--cc=tj@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).