From: Wolfram Sang <wsa@kernel.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Akash Asthana <akashast@codeaurora.org>,
Mukesh Savaliya <msavaliy@codeaurora.org>,
~postmarketos/upstreaming@lists.sr.ht, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
Date: Thu, 8 Oct 2020 12:03:52 +0200 [thread overview]
Message-ID: <20201008100352.GF76290@ninjato> (raw)
In-Reply-To: <20201007174736.292968-6-caleb@connolly.tech>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
> is used for i2c, so disable it.
>
> https://patchwork.kernel.org/patch/11133827/
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
May I ask for a quick review here, so we can get this into 5.9 if
qcom-geni maintainers agree this is good to go?
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..50a0674a6553 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
> struct geni_se *se = &gi2c->se;
> size_t len = msg->len;
>
> - if (!of_machine_is_compatible("lenovo,yoga-c630"))
> + if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> + !of_machine_is_compatible("oneplus,oneplus6"))
> dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>
> if (dma_buf)
> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
> struct geni_se *se = &gi2c->se;
> size_t len = msg->len;
>
> - if (!of_machine_is_compatible("lenovo,yoga-c630"))
> + if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> + !of_machine_is_compatible("oneplus,oneplus6"))
> dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>
> if (dma_buf)
> --
> 2.28.0
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-08 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 17:48 Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
2020-10-07 17:49 ` [PATCH 1/5] drm/panel/oneplus6: Add panel-oneplus6 Caleb Connolly
2020-10-18 13:35 ` Sam Ravnborg
2020-10-19 14:21 ` Caleb Connolly
2020-10-07 17:49 ` [PATCH 2/5] dt-bindings: panel: add documentation for oneplus6 panel Caleb Connolly
2020-10-09 14:02 ` Rob Herring
2020-10-09 14:05 ` Rob Herring
2020-10-18 12:33 ` Caleb Connolly
2020-10-07 17:49 ` [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Caleb Connolly
2020-10-07 17:49 ` [PATCH 4/5] dt-bindings: add vendor bindings for OnePlus Caleb Connolly
2020-10-07 17:49 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Caleb Connolly
2020-10-08 10:03 ` Wolfram Sang [this message]
2020-10-08 10:46 ` Caleb Connolly
2020-10-08 12:19 ` Wolfram Sang
2020-10-09 6:53 ` Mukesh, Savaliya
2020-10-09 5:26 ` Akash Asthana
2020-10-09 5:58 ` Wolfram Sang
2020-10-08 9:20 ` Add support for the OnePlus 6 and 6T SDM845 devices Caleb Connolly
-- strict thread matches above, loose matches on Subject: below --
2020-10-07 17:19 Caleb Connolly
2020-10-07 17:20 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008100352.GF76290@ninjato \
--to=wsa@kernel.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).