From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Akhil P Oommen <akhilpo@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
Rob Herring <robh@kernel.org>, Rob Clark <robdclark@gmail.com>,
dri-devel@freedesktop.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jordan Crouse <jcrouse@codeaurora.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Add gpu cooling support
Date: Fri, 9 Oct 2020 09:57:05 -0700 [thread overview]
Message-ID: <20201009165705.GA1292413@google.com> (raw)
In-Reply-To: <CAD=FV=WjWv040TyBaqU8ZAuxGi-YpJ2tsVcUbOV4Htv=_-n8fA@mail.gmail.com>
On Fri, Oct 09, 2020 at 08:05:10AM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Oct 8, 2020 at 10:10 AM Akhil P Oommen <akhilpo@codeaurora.org> wrote:
> >
> > Add cooling-cells property and the cooling maps for the gpu tzones
> > to support GPU cooling.
> >
> > Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 29 ++++++++++++++++++++++-------
> > 1 file changed, 22 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index d46b383..40d6a28 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -2,7 +2,7 @@
> > /*
> > * SC7180 SoC device tree source
> > *
> > - * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2019-20, The Linux Foundation. All rights reserved.
> > */
> >
> > #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> > @@ -1885,6 +1885,7 @@
> > iommus = <&adreno_smmu 0>;
> > operating-points-v2 = <&gpu_opp_table>;
> > qcom,gmu = <&gmu>;
> > + #cooling-cells = <2>;
>
> Presumably we should add this to the devicetree bindings, too?
>
>
> > interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>;
> > interconnect-names = "gfx-mem";
> > @@ -3825,16 +3826,16 @@
> > };
> >
> > gpuss0-thermal {
> > - polling-delay-passive = <0>;
> > + polling-delay-passive = <100>;
>
> Why did you make this change? I'm pretty sure that we _don't_ want
> this since we're using interrupts for the thermal sensor. See commit
> 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode in
> Thermal-zones node").
I was going to ask the same, this shouldn't be needed.
> > polling-delay = <0>;
> >
> > thermal-sensors = <&tsens0 13>;
> >
> > trips {
> > gpuss0_alert0: trip-point0 {
> > - temperature = <90000>;
> > + temperature = <95000>;
> > hysteresis = <2000>;
> > - type = "hot";
> > + type = "passive";
>
> Matthias probably knows better, but I wonder if we should be making
> two passive trip levels like we do with CPU. IIRC this is important
> if someone wants to be able to use this with IPA.
Yes, please introduce a second trip point and make both of them
'passive'.
next prev parent reply other threads:[~2020-10-09 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 17:09 [PATCH 1/2] arm64: dts: qcom: sc7180: Add gpu cooling support Akhil P Oommen
2020-10-08 17:09 ` [PATCH 2/2] drm/msm: Add support for GPU cooling Akhil P Oommen
2020-10-09 18:36 ` [2/2] " mka
2020-10-12 13:33 ` Akhil P Oommen
2020-10-12 17:40 ` mka
2020-10-13 13:53 ` Akhil P Oommen
2020-10-13 17:40 ` mka
2020-10-13 19:21 ` Akhil P Oommen
2020-10-14 1:09 ` mka
2020-10-09 15:05 ` [PATCH 1/2] arm64: dts: qcom: sc7180: Add gpu cooling support Doug Anderson
2020-10-09 16:57 ` Matthias Kaehlcke [this message]
2020-10-14 13:29 ` Akhil P Oommen
2020-10-14 18:37 ` manafm
2020-10-15 22:19 ` Matthias Kaehlcke
2020-10-16 13:46 ` Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009165705.GA1292413@google.com \
--to=mka@chromium.org \
--cc=akhilpo@codeaurora.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).