From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: kuba@kernel.org, davem@davemloft.net, hemantk@codeaurora.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bbhatt@codeaurora.org, willemdebruijn.kernel@gmail.com,
jhugo@codeaurora.org
Subject: Re: [PATCH v8 1/2] bus: mhi: Add mhi_queue_is_full function
Date: Fri, 30 Oct 2020 14:35:39 +0530 [thread overview]
Message-ID: <20201030090539.GB3818@Mani-XPS-13-9360> (raw)
In-Reply-To: <1603902898-25233-1-git-send-email-loic.poulain@linaro.org>
On Wed, Oct 28, 2020 at 05:34:57PM +0100, Loic Poulain wrote:
> This function can be used by client driver to determine whether it's
> possible to queue new elements in a channel ring.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> v1->v5: not part of the series
> v6: Add this commit, used for stopping TX queue
> v7: no change
> v8: remove static change (up to the compiler)
>
> drivers/bus/mhi/core/main.c | 11 +++++++++++
> include/linux/mhi.h | 7 +++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index a588eac..bab38d2 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir,
> }
> EXPORT_SYMBOL_GPL(mhi_queue_buf);
>
> +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir)
> +{
> + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> + struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ?
> + mhi_dev->ul_chan : mhi_dev->dl_chan;
> + struct mhi_ring *tre_ring = &mhi_chan->tre_ring;
> +
> + return mhi_is_ring_full(mhi_cntrl, tre_ring);
> +}
> +EXPORT_SYMBOL_GPL(mhi_queue_is_full);
> +
> int mhi_send_cmd(struct mhi_controller *mhi_cntrl,
> struct mhi_chan *mhi_chan,
> enum mhi_cmd_type cmd)
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 9d67e75..f72c3a4 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -745,4 +745,11 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir,
> int mhi_queue_skb(struct mhi_device *mhi_dev, enum dma_data_direction dir,
> struct sk_buff *skb, size_t len, enum mhi_flags mflags);
>
> +/**
> + * mhi_queue_is_full - Determine whether queueing new elements is possible
> + * @mhi_dev: Device associated with the channels
> + * @dir: DMA direction for the channel
> + */
> +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir);
> +
> #endif /* _MHI_H_ */
> --
> 2.7.4
>
prev parent reply other threads:[~2020-10-30 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 16:34 [PATCH v8 1/2] bus: mhi: Add mhi_queue_is_full function Loic Poulain
2020-10-28 16:34 ` [PATCH v8 2/2] net: Add mhi-net driver Loic Poulain
2020-10-30 8:13 ` Manivannan Sadhasivam
2020-10-30 9:27 ` Loic Poulain
2020-10-30 9:31 ` Manivannan Sadhasivam
2020-10-30 9:05 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030090539.GB3818@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).