From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FDEC2D0A3 for ; Mon, 9 Nov 2020 11:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6DDA207BC for ; Mon, 9 Nov 2020 11:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Azjcqpp4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbgKIL74 (ORCPT ); Mon, 9 Nov 2020 06:59:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726410AbgKIL7z (ORCPT ); Mon, 9 Nov 2020 06:59:55 -0500 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E51C0613CF for ; Mon, 9 Nov 2020 03:59:55 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id x13so7943350pfa.9 for ; Mon, 09 Nov 2020 03:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lr4Cz9thkO5BeHlwWTqxwoeU7qvgDXar1hvGAFKb8x0=; b=Azjcqpp4OiWVMYTCnFEPXlDTuJoPuD+JB7fGW2oTcslLq8s3d/IGt5sXjU98vnzNRq m1EiQPZ+OW/fQvONuPIUPvoyiTYsXQJ8sKPXE8671rdkFcSEFlGvmsh6VzNLg6KLz5qB rOJ9QKn+YTFiBPYOn6WP/Il5ltT/HK8kAV0JMBfP8SU78SxoPbr1Gt9urGAmjgztXZ23 zit7NYSyz9oTZlXM8GuEL3dY8zsLkiu38kVqHueYUt/P5UlZX7Bt8XvjHvxPsp7RNrTt CfrH9C3aLPgSVtBduWZWzbp/GdKeh8ml+xbfnC+FsPM38ef+QX0Liasq5jjSE3W50NCt 5ahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lr4Cz9thkO5BeHlwWTqxwoeU7qvgDXar1hvGAFKb8x0=; b=QPE+lyCt/yzW2uB7Uoc+TmNQtopdXaocqo9uWRKKdwK3VcGgxMfU/NhI94mvc8DRfN htfRqjxEdiMH/FJEevq6DMEvw7hWnPewhP1/HGdKh+ZX1TsWURQAbqJxtdl2s1uYrsQ6 Jv2dBvmf9WUFvkI4N2bNONb8kI1YswOmdhtDElE2ppqyhCREM/vJDtfiPlcRZ0Q5+lqr +ei3+DGb4dd2s2TTg+F78ZTgcxaGJb8jRqL5Dp8Bob/ni06W4Y5XyuO0SvySD6CBsaLN 0R1/4ejdac0zZsvK50FaDHCWOvAZlvD0iS0OP+9O9ABqk6hhBYfYGD+6EARUNK1TaYDy Atnw== X-Gm-Message-State: AOAM533jkz1dssR4j+VxDeSuk2ZooXhKf12k+vAHKW0W0pCeTur+5y22 T9m1rRuYxK1JCNeSuGHgGtI4 X-Google-Smtp-Source: ABdhPJzcrnwWYIb5L4wAFweAqmKGmbtjNFN3kwGCHOSAwypQDL8S2TPj/LKr+WG5y/YdWH5kSngw1g== X-Received: by 2002:a17:90a:d796:: with SMTP id z22mr13418546pju.2.1604923195399; Mon, 09 Nov 2020 03:59:55 -0800 (PST) Received: from work ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id z3sm10024582pgl.73.2020.11.09.03.59.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Nov 2020 03:59:54 -0800 (PST) Date: Mon, 9 Nov 2020 17:29:49 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH] bus: mhi: core: Remove double locking from mhi_driver_remove() Message-ID: <20201109115949.GD24289@work> References: <1602787671-9497-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602787671-9497-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 15, 2020 at 11:47:51AM -0700, Bhaumik Bhatt wrote: > There is double acquisition of the pm_lock from mhi_driver_remove() > function. Remove the read_lock_bh/read_unlock_bh calls for pm_lock > taken during a call to mhi_device_put() as the lock is acquired > within the function already. This will help avoid a potential > kernel panic. > > Fixes: 189ff97cca53 ("bus: mhi: core: Add support for data transfer") > Reported-by: Shuah Khan > Signed-off-by: Bhaumik Bhatt Applied to mhi-next! Thanks, Mani > --- > drivers/bus/mhi/core/init.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index 0ffdebd..0a09f82 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -1276,10 +1276,8 @@ static int mhi_driver_remove(struct device *dev) > mutex_unlock(&mhi_chan->mutex); > } > > - read_lock_bh(&mhi_cntrl->pm_lock); > while (mhi_dev->dev_wake) > mhi_device_put(mhi_dev); > - read_unlock_bh(&mhi_cntrl->pm_lock); > > return 0; > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >