From: kernel test robot <lkp@intel.com>
To: Shawn Guo <shawn.guo@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Felipe Balbi <balbi@kernel.org>
Cc: kbuild-all@lists.01.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] usb: dwc3: qcom: add URS Host support for sdm845 ACPI boot
Date: Thu, 31 Dec 2020 00:00:25 +0800 [thread overview]
Message-ID: <202012302301.ml5wrf97-lkp@intel.com> (raw)
In-Reply-To: <20201230124925.19260-1-shawn.guo@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2833 bytes --]
Hi Shawn,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shawn-Guo/usb-dwc3-qcom-add-URS-Host-support-for-sdm845-ACPI-boot/20201230-205430
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c3faeb501efb31e035beca1c0fee1cca6ec16392
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shawn-Guo/usb-dwc3-qcom-add-URS-Host-support-for-sdm845-ACPI-boot/20201230-205430
git checkout c3faeb501efb31e035beca1c0fee1cca6ec16392
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/usb/dwc3/dwc3-qcom.c: In function 'dwc3_qcom_create_urs_usb_platdev':
drivers/usb/dwc3/dwc3-qcom.c:675:9: error: implicit declaration of function 'acpi_create_platform_device' [-Werror=implicit-function-declaration]
675 | return acpi_create_platform_device(adev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/dwc3-qcom.c:675:9: warning: returning 'int' from a function with return type 'struct platform_device *' makes pointer from integer without a cast [-Wint-conversion]
675 | return acpi_create_platform_device(adev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +675 drivers/usb/dwc3/dwc3-qcom.c
659
660 static struct platform_device *
661 dwc3_qcom_create_urs_usb_platdev(struct device *dev)
662 {
663 struct fwnode_handle *fwh;
664 struct acpi_device *adev;
665
666 /* Find the first child of URS node */
667 fwh = fwnode_call_ptr_op(dev->fwnode, get_next_child_node, NULL);
668 if (!fwh)
669 return NULL;
670
671 adev = to_acpi_device_node(fwh);
672 if (!adev)
673 return NULL;
674
> 675 return acpi_create_platform_device(adev, NULL);
676 }
677
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66235 bytes --]
next prev parent reply other threads:[~2020-12-30 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 12:49 [PATCH] usb: dwc3: qcom: add URS Host support for sdm845 ACPI boot Shawn Guo
2020-12-30 16:00 ` kernel test robot [this message]
2020-12-31 13:47 ` Shawn Guo
2021-01-15 3:53 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012302301.ml5wrf97-lkp@intel.com \
--to=lkp@intel.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).