* [PATCH 00/40] [Set 11] Rid W=1 warnings from GPU
@ 2021-01-08 20:14 Lee Jones
2021-01-08 20:14 ` [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2021-01-08 20:14 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Anthony Koo, Ben Skeggs,
Bhawanpreet Lakha, Charlene Liu, Christian König,
Daniel Vetter, David Airlie, dri-devel, Eric Bernstein,
Eryk Brol, Evan Quan, Feifei Xu, Felix Kuehling, freedreno,
George Shen, Harry Wentland, Hawking Zhang, Igor Kravchenko,
Krunoslav Kovac, Kuogee Hsieh, Leo Li, Lewis Huang,
linux-arm-msm, Maarten Lankhorst, Mauro Rossi, Maxime Ripard,
Mikita Lipski, nouveau, Qinglang Miao, Rob Clark, Sean Paul,
Thomas Zimmermann, Wyatt Wood
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
300 out of 5000 left!
Lee Jones (40):
drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
drm/nouveau/dispnv50/disp: Remove unused variable 'ret'
drm/msm/dp/dp_display: Remove unused variable 'hpd'
drm/amd/amdgpu/amdgpu_ih: Update 'amdgpu_ih_decode_iv_helper()'s
function header
drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix
spelling error
drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Provide description
of 'call_back_func'
drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix documentation for
'mpll_param'
drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Fix legacy function header
formatting
drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Fix legacy function header
formatting
drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix formatting and spelling
issues
drm/amd/pm/powerplay/hwmgr/hwmgr: Move prototype into shared header
drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix a bunch of kernel-doc
formatting issues
drm/amd/display/dc/basics/conversion: Demote obvious kernel-doc abuse
drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs: Demote non-kernel-doc
comment blocks
drm/amd/display/dc/bios/command_table_helper: Fix kernel-doc
formatting
drm/amd/display/dc/bios/command_table_helper2: Fix legacy formatting
problems
drm/amd/display/dc/bios/bios_parser: Make local functions static
drm/amd/display/dc/bios/bios_parser: Fix a whole bunch of legacy doc
formatting
drm/amd/display/dc/bios/command_table: Remove unused variable
include: drm: drm_atomic: Make use of 'new_plane_state'
drm/amd/display/dc/calcs/dce_calcs: Remove unused variables
'v_filter_init_mode' and 'sclk_lvl'
drm/amd/display/dc/bios/bios_parser2: Fix some formatting issues and
missing parameter docs
drm/amd/display/dc/dce/dce_audio: Make function invoked by reference
static
drm/amd/display/dc/dce/dce_stream_encoder: Remove unused variable
'regval'
drm/amd/display/dc/dce/dce_link_encoder: Make functions invoked by
reference static
drm/amd/display/dc/dce/dce_clock_source: Fix formatting/spelling of
worthy function headers
drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers,
demote barely documented one
drm/amd/display/dc/dce/dce_transform: Remove 3 unused/legacy variables
drm/amd/display/dc/dce/dce_dmcu: Staticify local function call
'dce_dmcu_load_iram'
drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only
source file it's used in
drm/amd/display/dc/dce/dce_opp: Make local functions and ones invoked
by reference static
drm/amd/display/dc/dce/dce_aux: Remove unused function
'get_engine_type'
drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc
headers
drm/amd/display/dc/bios/bios_parser: Fix misspelling of function
parameter
drm/amd/display/dc/bios/command_table: Remove unused variable and
associated comment
drm/amd/display/dc/dce/dce_i2c_hw: Make functions called by reference
static
drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of local functions
static
drm/amd/display/dc/dce/dce_panel_cntl: Remove unused variables
'bl_pwm_cntl' and 'pwm_period_cntl'
drm/amd/display/dc/dce/dmub_psr: Demote non-conformant kernel-doc
headers
drm/amd/display/dc/gpio/hw_factory: Delete unused function
'dal_hw_factory_destroy'
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 2 +
drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 5 +-
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +-
.../drm/amd/display/dc/basics/conversion.c | 9 +-
.../gpu/drm/amd/display/dc/bios/bios_parser.c | 119 +++++-----
.../drm/amd/display/dc/bios/bios_parser2.c | 29 ++-
.../drm/amd/display/dc/bios/command_table.c | 16 +-
.../display/dc/bios/command_table_helper.c | 20 +-
.../display/dc/bios/command_table_helper2.c | 20 +-
.../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 8 +-
.../gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +-
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 6 -
.../drm/amd/display/dc/dce/dce_clock_source.c | 57 +++--
drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 6 +-
drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h | 2 -
.../gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 4 +-
.../gpu/drm/amd/display/dc/dce/dce_i2c_sw.c | 9 +-
.../drm/amd/display/dc/dce/dce_link_encoder.c | 6 +-
drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 8 +-
.../drm/amd/display/dc/dce/dce_panel_cntl.c | 8 +-
.../amd/display/dc/dce/dce_stream_encoder.c | 3 +-
.../drm/amd/display/dc/dce/dce_transform.c | 13 --
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 22 +-
.../gpu/drm/amd/display/dc/gpio/hw_factory.c | 14 --
.../gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 2 +-
.../drm/amd/pm/powerplay/hwmgr/ppatomctrl.c | 4 +-
.../powerplay/hwmgr/process_pptables_v1_0.c | 1 +
.../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 4 +-
.../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 137 ++++++------
.../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h | 1 +
.../drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c | 11 +-
.../drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c | 11 +-
drivers/gpu/drm/msm/dp/dp_display.c | 3 -
drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 204 ++++++------------
.../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
include/drm/drm_atomic.h | 3 +-
37 files changed, 325 insertions(+), 455 deletions(-)
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Anthony Koo <Anthony.Koo@amd.com>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Cc: Charlene Liu <Charlene.Liu@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eric Bernstein <eric.bernstein@amd.com>
Cc: Eryk Brol <eryk.brol@amd.com>
Cc: Evan Quan <evan.quan@amd.com>
Cc: Feifei Xu <Feifei.Xu@amd.com>
Cc: Felix Kuehling <Felix.Kuehling@amd.com>
Cc: freedreno@lists.freedesktop.org
Cc: George Shen <george.shen@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Igor Kravchenko <Igor.Kravchenko@amd.com>
Cc: Krunoslav Kovac <Krunoslav.Kovac@amd.com>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Lewis Huang <Lewis.Huang@amd.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mauro Rossi <issor.oruam@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Mikita Lipski <mikita.lipski@amd.com>
Cc: nouveau@lists.freedesktop.org
Cc: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Wyatt Wood <wyatt.wood@amd.com>
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'
2021-01-08 20:14 [PATCH 00/40] [Set 11] Rid W=1 warnings from GPU Lee Jones
@ 2021-01-08 20:14 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-01-08 20:14 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Kuogee Hsieh, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’:
drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable]
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 6e971d552911f..637a5585c2fd8 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
int rc = 0;
u32 sink_request;
struct dp_display_private *dp;
- struct dp_usbpd *hpd;
if (!dev) {
DRM_ERROR("invalid dev\n");
@@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
return -ENODEV;
}
- hpd = dp->usbpd;
-
/* check for any test request issued by sink */
rc = dp_link_process_request(dp->link);
if (!rc) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'
2021-04-16 14:36 [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU! Lee Jones
@ 2021-04-16 14:36 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-04-16 14:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Kuogee Hsieh, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’:
drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable]
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 5a39da6e1eaf2..31bf2a40a9eb2 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
int rc = 0;
u32 sink_request;
struct dp_display_private *dp;
- struct dp_usbpd *hpd;
if (!dev) {
DRM_ERROR("invalid dev\n");
@@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
return -ENODEV;
}
- hpd = dp->usbpd;
-
/* check for any test request issued by sink */
rc = dp_link_process_request(dp->link);
if (!rc) {
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-16 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 20:14 [PATCH 00/40] [Set 11] Rid W=1 warnings from GPU Lee Jones
2021-01-08 20:14 ` [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
2021-04-16 14:36 [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU! Lee Jones
2021-04-16 14:36 ` [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).