linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs
@ 2021-02-10 10:45 Vinod Koul
  2021-02-10 10:45 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8350 PAS remoteprocs Vinod Koul
  2021-02-11 18:52 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-10 10:45 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: linux-arm-msm, Vinod Koul, Andy Gross, Ohad Ben-Cohen,
	Rob Herring, linux-remoteproc, devicetree, linux-kernel

Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS
DT binding.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 .../devicetree/bindings/remoteproc/qcom,adsp.txt     | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
index 54737024da20..41eaa2466aab 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
@@ -25,6 +25,10 @@ on the Qualcomm ADSP Hexagon core.
 		    "qcom,sm8250-adsp-pas"
 		    "qcom,sm8250-cdsp-pas"
 		    "qcom,sm8250-slpi-pas"
+		    "qcom,sm8350-adsp-pas"
+		    "qcom,sm8350-cdsp-pas"
+		    "qcom,sm8350-slpi-pas"
+		    "qcom,sm8350-mpss-pas"
 
 - interrupts-extended:
 	Usage: required
@@ -51,10 +55,14 @@ on the Qualcomm ADSP Hexagon core.
 	qcom,sm8250-adsp-pas:
 	qcom,sm8250-cdsp-pas:
 	qcom,sm8250-slpi-pas:
+	qcom,sm8350-adsp-pas:
+	qcom,sm8350-cdsp-pas:
+	qcom,sm8350-slpi-pas:
 		    must be "wdog", "fatal", "ready", "handover", "stop-ack"
 	qcom,qcs404-wcss-pas:
 	qcom,sc7180-mpss-pas:
 	qcom,sm8150-mpss-pas:
+	qcom,sm8350-mpss-pas:
 		    must be "wdog", "fatal", "ready", "handover", "stop-ack",
 		    "shutdown-ack"
 
@@ -113,14 +121,18 @@ on the Qualcomm ADSP Hexagon core.
 	qcom,sdm845-cdsp-pas:
 	qcom,sm8150-adsp-pas:
 	qcom,sm8150-cdsp-pas:
+	qcom,sm8250-cdsp-pas:
 	qcom,sm8250-cdsp-pas:
 		    must be "cx", "load_state"
 	qcom,sc7180-mpss-pas:
 	qcom,sm8150-mpss-pas:
+	qcom,sm8350-mpss-pas:
 		    must be "cx", "load_state", "mss"
 	qcom,sm8250-adsp-pas:
+	qcom,sm8350-adsp-pas:
 	qcom,sm8150-slpi-pas:
 	qcom,sm8250-slpi-pas:
+	qcom,sm8350-slpi-pas:
 		    must be "lcx", "lmx", "load_state"
 
 - memory-region:
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] remoteproc: qcom: pas: Add SM8350 PAS remoteprocs
  2021-02-10 10:45 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Vinod Koul
@ 2021-02-10 10:45 ` Vinod Koul
  2021-02-11 18:52 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-10 10:45 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: linux-arm-msm, Vinod Koul, Andy Gross, Ohad Ben-Cohen,
	Rob Herring, linux-remoteproc, devicetree, linux-kernel

Add audio, compute, modem and sensor DSP resources to the Qualcomm PAS
driver.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 63 ++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index ee586226e438..e635454d6170 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -565,6 +565,26 @@ static const struct adsp_data sm8250_adsp_resource = {
 	.ssctl_id = 0x14,
 };
 
+static const struct adsp_data sm8350_adsp_resource = {
+	.crash_reason_smem = 423,
+	.firmware_name = "adsp.mdt",
+	.pas_id = 1,
+	.has_aggre2_clk = false,
+	.auto_boot = true,
+	.active_pd_names = (char*[]){
+		"load_state",
+		NULL
+	},
+	.proxy_pd_names = (char*[]){
+		"lcx",
+		"lmx",
+		NULL
+	},
+	.ssr_name = "lpass",
+	.sysmon_name = "adsp",
+	.ssctl_id = 0x14,
+};
+
 static const struct adsp_data msm8998_adsp_resource = {
 		.crash_reason_smem = 423,
 		.firmware_name = "adsp.mdt",
@@ -629,6 +649,25 @@ static const struct adsp_data sm8250_cdsp_resource = {
 	.ssctl_id = 0x17,
 };
 
+static const struct adsp_data sm8350_cdsp_resource = {
+	.crash_reason_smem = 601,
+	.firmware_name = "cdsp.mdt",
+	.pas_id = 18,
+	.has_aggre2_clk = false,
+	.auto_boot = true,
+	.active_pd_names = (char*[]){
+		"load_state",
+		NULL
+	},
+	.proxy_pd_names = (char*[]){
+		"cx",
+		NULL
+	},
+	.ssr_name = "cdsp",
+	.sysmon_name = "cdsp",
+	.ssctl_id = 0x17,
+};
+
 static const struct adsp_data mpss_resource_init = {
 	.crash_reason_smem = 421,
 	.firmware_name = "modem.mdt",
@@ -701,6 +740,26 @@ static const struct adsp_data sm8250_slpi_resource = {
 	.ssctl_id = 0x16,
 };
 
+static const struct adsp_data sm8350_slpi_resource = {
+	.crash_reason_smem = 424,
+	.firmware_name = "slpi.mdt",
+	.pas_id = 12,
+	.has_aggre2_clk = false,
+	.auto_boot = true,
+	.active_pd_names = (char*[]){
+		"load_state",
+		NULL
+	},
+	.proxy_pd_names = (char*[]){
+		"lcx",
+		"lmx",
+		NULL
+	},
+	.ssr_name = "dsps",
+	.sysmon_name = "slpi",
+	.ssctl_id = 0x16,
+};
+
 static const struct adsp_data msm8998_slpi_resource = {
 		.crash_reason_smem = 424,
 		.firmware_name = "slpi.mdt",
@@ -745,6 +804,10 @@ static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,sm8250-adsp-pas", .data = &sm8250_adsp_resource},
 	{ .compatible = "qcom,sm8250-cdsp-pas", .data = &sm8250_cdsp_resource},
 	{ .compatible = "qcom,sm8250-slpi-pas", .data = &sm8250_slpi_resource},
+	{ .compatible = "qcom,sm8350-adsp-pas", .data = &sm8350_adsp_resource},
+	{ .compatible = "qcom,sm8350-cdsp-pas", .data = &sm8350_cdsp_resource},
+	{ .compatible = "qcom,sm8350-slpi-pas", .data = &sm8350_slpi_resource},
+	{ .compatible = "qcom,sm8350-mpss-pas", .data = &mpss_resource_init},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, adsp_of_match);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs
  2021-02-10 10:45 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Vinod Koul
  2021-02-10 10:45 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8350 PAS remoteprocs Vinod Koul
@ 2021-02-11 18:52 ` Bjorn Andersson
  2021-02-12  4:37   ` Vinod Koul
  1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2021-02-11 18:52 UTC (permalink / raw)
  To: Vinod Koul
  Cc: linux-arm-msm, Andy Gross, Ohad Ben-Cohen, Rob Herring,
	linux-remoteproc, devicetree, linux-kernel

On Wed 10 Feb 04:45 CST 2021, Vinod Koul wrote:

> Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS
> DT binding.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  .../devicetree/bindings/remoteproc/qcom,adsp.txt     | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 54737024da20..41eaa2466aab 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -25,6 +25,10 @@ on the Qualcomm ADSP Hexagon core.
>  		    "qcom,sm8250-adsp-pas"
>  		    "qcom,sm8250-cdsp-pas"
>  		    "qcom,sm8250-slpi-pas"
> +		    "qcom,sm8350-adsp-pas"
> +		    "qcom,sm8350-cdsp-pas"
> +		    "qcom,sm8350-slpi-pas"
> +		    "qcom,sm8350-mpss-pas"
>  
>  - interrupts-extended:
>  	Usage: required
> @@ -51,10 +55,14 @@ on the Qualcomm ADSP Hexagon core.
>  	qcom,sm8250-adsp-pas:
>  	qcom,sm8250-cdsp-pas:
>  	qcom,sm8250-slpi-pas:
> +	qcom,sm8350-adsp-pas:
> +	qcom,sm8350-cdsp-pas:
> +	qcom,sm8350-slpi-pas:
>  		    must be "wdog", "fatal", "ready", "handover", "stop-ack"
>  	qcom,qcs404-wcss-pas:
>  	qcom,sc7180-mpss-pas:
>  	qcom,sm8150-mpss-pas:
> +	qcom,sm8350-mpss-pas:
>  		    must be "wdog", "fatal", "ready", "handover", "stop-ack",
>  		    "shutdown-ack"
>  
> @@ -113,14 +121,18 @@ on the Qualcomm ADSP Hexagon core.
>  	qcom,sdm845-cdsp-pas:
>  	qcom,sm8150-adsp-pas:
>  	qcom,sm8150-cdsp-pas:
> +	qcom,sm8250-cdsp-pas:

This should be sm8350, I fixed this up and applied the patch.

Thanks,
Bjorn

>  	qcom,sm8250-cdsp-pas:
>  		    must be "cx", "load_state"
>  	qcom,sc7180-mpss-pas:
>  	qcom,sm8150-mpss-pas:
> +	qcom,sm8350-mpss-pas:
>  		    must be "cx", "load_state", "mss"
>  	qcom,sm8250-adsp-pas:
> +	qcom,sm8350-adsp-pas:
>  	qcom,sm8150-slpi-pas:
>  	qcom,sm8250-slpi-pas:
> +	qcom,sm8350-slpi-pas:
>  		    must be "lcx", "lmx", "load_state"
>  
>  - memory-region:
> -- 
> 2.26.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs
  2021-02-11 18:52 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Bjorn Andersson
@ 2021-02-12  4:37   ` Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-12  4:37 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: linux-arm-msm, Andy Gross, Ohad Ben-Cohen, Rob Herring,
	linux-remoteproc, devicetree, linux-kernel

On 11-02-21, 12:52, Bjorn Andersson wrote:
> On Wed 10 Feb 04:45 CST 2021, Vinod Koul wrote:
> 
> > Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS
> > DT binding.
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  .../devicetree/bindings/remoteproc/qcom,adsp.txt     | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> > index 54737024da20..41eaa2466aab 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> > @@ -25,6 +25,10 @@ on the Qualcomm ADSP Hexagon core.
> >  		    "qcom,sm8250-adsp-pas"
> >  		    "qcom,sm8250-cdsp-pas"
> >  		    "qcom,sm8250-slpi-pas"
> > +		    "qcom,sm8350-adsp-pas"
> > +		    "qcom,sm8350-cdsp-pas"
> > +		    "qcom,sm8350-slpi-pas"
> > +		    "qcom,sm8350-mpss-pas"
> >  
> >  - interrupts-extended:
> >  	Usage: required
> > @@ -51,10 +55,14 @@ on the Qualcomm ADSP Hexagon core.
> >  	qcom,sm8250-adsp-pas:
> >  	qcom,sm8250-cdsp-pas:
> >  	qcom,sm8250-slpi-pas:
> > +	qcom,sm8350-adsp-pas:
> > +	qcom,sm8350-cdsp-pas:
> > +	qcom,sm8350-slpi-pas:
> >  		    must be "wdog", "fatal", "ready", "handover", "stop-ack"
> >  	qcom,qcs404-wcss-pas:
> >  	qcom,sc7180-mpss-pas:
> >  	qcom,sm8150-mpss-pas:
> > +	qcom,sm8350-mpss-pas:
> >  		    must be "wdog", "fatal", "ready", "handover", "stop-ack",
> >  		    "shutdown-ack"
> >  
> > @@ -113,14 +121,18 @@ on the Qualcomm ADSP Hexagon core.
> >  	qcom,sdm845-cdsp-pas:
> >  	qcom,sm8150-adsp-pas:
> >  	qcom,sm8150-cdsp-pas:
> > +	qcom,sm8250-cdsp-pas:
> 
> This should be sm8350, I fixed this up and applied the patch.

Sorry for missing this and thanks for fixing it up

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-12  4:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 10:45 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Vinod Koul
2021-02-10 10:45 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8350 PAS remoteprocs Vinod Koul
2021-02-11 18:52 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Bjorn Andersson
2021-02-12  4:37   ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).