archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <>
To: Stanimir Varbanov <>,
	Andy Gross <>,
	Bjorn Andersson <>,
	Mauro Carvalho Chehab <>
	"Gustavo A. R. Silva" <>,
Subject: [PATCH][next] media: venus: hfi_cmds.h: Replace one-element array with flexible-array member
Date: Wed, 10 Feb 2021 16:57:20 -0600	[thread overview]
Message-ID: <20210210225720.GA13710@embeddedor> (raw)

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].

Use flexible-array member in struct hfi_sys_set_property_pkt instead of
one-element array.

Also, this helps with the ongoing efforts to enable -Warray-bounds and
fix the following warnings:

drivers/media/platform/qcom/venus/hfi_cmds.c: In function ‘pkt_sys_coverage_config’:
drivers/media/platform/qcom/venus/hfi_cmds.c:57:11: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds]
   57 |  pkt->data[1] = mode;
      |  ~~~~~~~~~^~~


Build-tested-by: kernel test robot <>
Signed-off-by: Gustavo A. R. Silva <>
 drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
index 83705e237f1c..327ed90a2788 100644
--- a/drivers/media/platform/qcom/venus/hfi_cmds.h
+++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
@@ -68,7 +68,7 @@ struct hfi_sys_release_resource_pkt {
 struct hfi_sys_set_property_pkt {
 	struct hfi_pkt_hdr hdr;
 	u32 num_properties;
-	u32 data[1];
+	u32 data[];
 struct hfi_sys_get_property_pkt {

             reply	other threads:[~2021-02-10 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 22:57 Gustavo A. R. Silva [this message]
2021-03-04  1:42 ` Gustavo A. R. Silva
2021-05-11 15:44 ` Gustavo A. R. Silva
2021-05-12 11:37   ` Stanimir Varbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210225720.GA13710@embeddedor \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][next] media: venus: hfi_cmds.h: Replace one-element array with flexible-array member' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).