From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DFB5C433E0 for ; Fri, 12 Feb 2021 21:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E992B64E08 for ; Fri, 12 Feb 2021 21:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbhBLVZv (ORCPT ); Fri, 12 Feb 2021 16:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbhBLVZs (ORCPT ); Fri, 12 Feb 2021 16:25:48 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EB62C061756 for ; Fri, 12 Feb 2021 13:25:08 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id n8so845778wrm.10 for ; Fri, 12 Feb 2021 13:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YjjHCq+AaBj0XRYyjJcKHPRmimymXfzCaBl7Q8eWwy8=; b=g/+ng38wC9WYIlhYgvh782IXg97sbu5H2bHQg1fy7G4fxRCDUpCXZYdC+JCdpR4XNl Yw5Ma7Df7VSTosK+Dg8OVl4GkjbrkQcBOr9Xiq3HfIy9rrvpOLM2OJiDkwlwkM0SFDI7 UHSwSicLZ6LJXAz3TisYUsBt/xJ8jWyYX8BzM2Lo009dLjxp53FC9tvnepVgjRZMbFd/ bXLNUHrFZbj2ddXflBkWLstEStL9n2VuvHN0mRzmIUfonYou48N1YYdJ+uVOhxISaRBi OG30sLac+3Ch3ksBfi6z1dNsNZnNSXnslZ3W5X7fM7+KJoRbR9grInEhcZoLtiUcbf2V /IZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YjjHCq+AaBj0XRYyjJcKHPRmimymXfzCaBl7Q8eWwy8=; b=QwACKKEaLp2w1bUVR/YAcnSbzqND6yPmkVZff1xQ4Fji3c4HAUl5NLgsKvO6j8a9R/ Dy3lv0G73826d73r1vb44OwQogF0qHTxhSxtKOjKPeFIKY+GcJFO5BFBKBSI/16aQij1 WSeeAk9FoKoxFOxX7cTIRl7H7SjOaUWpHWzC73hAZ5KqEtL/ZaRLppH4gplU3/ip9Qk6 JeiU0vau3SBJqxpnTpA0tey49Vta8aFLUvV1sFGAdUXdPSGNhz9WdNLXIuIUhg/YICtU i2hKuPvxkTg4uXGmiPj2Ajt4cK5/t+pm9iQyLVOkcUZ1xLwQsiq4asavupfxxdEAix65 6RIg== X-Gm-Message-State: AOAM533dVPn4Zzd6Wm6JUW/xZpKH3rZahjVuKGhOZw3QEDygERwEbB0M wZI8a+XAljBQooXyYnw1oF0dGg== X-Google-Smtp-Source: ABdhPJyceRwViwNbQKYFvMrDwH6pKxFiN51zbBbWqHy07haY7AmOeuB1Eg6qPAAr61Zco1QGQRaiqQ== X-Received: by 2002:a5d:6a89:: with SMTP id s9mr5614295wru.407.1613165106841; Fri, 12 Feb 2021 13:25:06 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id a16sm11571760wrr.89.2021.02.12.13.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 13:25:06 -0800 (PST) Date: Fri, 12 Feb 2021 21:25:03 +0000 From: Lee Jones To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ahmad Fatoum , Andy Gross , Avi Fishman , Benjamin Fair , Bjorn Andersson , Boris BREZILLON , Chen-Yu Tsai , Emilio =?iso-8859-1?Q?L=F3pez?= , Fabio Estevam , Geert Uytterhoeven , Jan Kotas , Jernej Skrabec , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Loc Ho , Maxime Ripard , Michael Turquette , Michal Simek , Nancy Yuen , Nuvoton Technologies , NXP Linux Team , openbmc@lists.ozlabs.org, Patrick Venture , Pengutronix Kernel Team , Peter De Schrijver , Philipp Zabel , Prashant Gaikwad , Rajan Vaja , Rajeev Kumar , Richard Woodruff , Russell King , Sascha Hauer , Shawn Guo , Shiraz Hashim , =?iso-8859-1?Q?S=F6ren?= Brinkmann , Tali Perry , Tero Kristo , Thierry Reding , Tomer Maimon , Viresh Kumar Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Message-ID: <20210212212503.GC179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 12 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-12 01:20:16) > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > Quoting Lee Jones (2021-02-11 13:10:54) > > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > niggly little warnings. > > > > > > > > > > > > This is the last set. Clock is clean after this. > > > > > > > > > > Is it possible to slam in some patch that makes W=1 the default for the > > > > > clk directory? I'm trying to avoid seeing this patch series again. > > > > > > > > One of my main goals of this project is that everyone (contributors, > > > > maintainers auto-builder robots etc) will be enabling W=1 builds > > > > *locally*. > > > > > > > > This isn't something you'll want to do at a global (i.e. in Mainline) > > > > level. That's kinda the point of W=1. > > > > > > > > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile? > > > > That would circumvent the point of W=1. Level-1 warnings are deemed, > > and I'm paraphrasing/making this up "not worth rejecting pull-requests > > over". In contrast, if Linus catches any W=0 warnings at pull-time, > > he will reject the pull-request as 'untested'. > > > > W=1 is defiantly something you'll want to enable locally though, and > > subsequently push back on contributors submitting code adding new > > ones. > > > > Why should I install a land mine for others to trip over? Won't that > just take them more time because they won't know to compile with W=1 and > then will have to go for another round of review while I push back on > them submitting new warnings? The alternative is to not worry about it and review the slow drip of fixes that will occur as a result. The issues I just fixed were built up over years. They won't get to that level again. In my mind contributors should be compiling their submissions with W=1 enabled by default. I'm fairly sure the auto-builders do this now. Once W=1 warnings are down to an acceptable level in the kernel as a whole, we can provide some guidance in SubmittingPatches (or similar) on how to enable them (hint: you add "W=1" on the compile line). Enabling W=1 in the default build will only serve to annoy Linus IMHO. If he wants them to be enabled by default, they wouldn't be W=1 in the first place, they'd be W=0 which *is* the default build. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog