linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add dt bindings for sm8250 venus
@ 2021-02-15 16:02 Bryan O'Donoghue
  2021-02-15 16:02 ` [PATCH v2 1/2] dt-bindings: clock: Add missing SM8250 videoc clock indices Bryan O'Donoghue
  2021-02-15 16:02 ` [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
  0 siblings, 2 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-02-15 16:02 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-arm-msm, stanimir.varbanov, agross,
	bjorn.andersson
  Cc: bryan.odonoghue

V2:
- Adds a dependency patch already present in clk/clk-next for reference
  9ba80d849c83 - dt-bindings: clock: Add missing SM8250 videoc clock indices
 
- Fixes yaml clanger
  I completely neglected to run dt_binding_check on v1, my mistake, fixed now.

Bryan O'Donoghue (2):
  dt-bindings: clock: Add missing SM8250 videoc clock indices
  dt-bindings: media: venus: Add sm8250 dt schema

 .../bindings/media/qcom,sm8250-venus.yaml     | 165 ++++++++++++++++++
 .../dt-bindings/clock/qcom,videocc-sm8250.h   |   2 +
 2 files changed, 167 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml

-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] dt-bindings: clock: Add missing SM8250 videoc clock indices
  2021-02-15 16:02 [PATCH v2 0/2] Add dt bindings for sm8250 venus Bryan O'Donoghue
@ 2021-02-15 16:02 ` Bryan O'Donoghue
  2021-02-15 16:02 ` [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
  1 sibling, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-02-15 16:02 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-arm-msm, stanimir.varbanov, agross,
	bjorn.andersson
  Cc: bryan.odonoghue

Two indexes need to be added to videocc-sm8250.h for venus to function
properly. Rather than adding the missing indexes when used we add them
separately here to keep checkpatch.pl happy.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 include/dt-bindings/clock/qcom,videocc-sm8250.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/dt-bindings/clock/qcom,videocc-sm8250.h b/include/dt-bindings/clock/qcom,videocc-sm8250.h
index 2b2b3867af25..8d321ac3b1fa 100644
--- a/include/dt-bindings/clock/qcom,videocc-sm8250.h
+++ b/include/dt-bindings/clock/qcom,videocc-sm8250.h
@@ -16,6 +16,8 @@
 #define VIDEO_CC_MVS1C_DIV2_DIV_CLK_SRC	6
 #define VIDEO_CC_PLL0			7
 #define VIDEO_CC_PLL1			8
+#define VIDEO_CC_MVS0_DIV_CLK_SRC	9
+#define VIDEO_CC_MVS0_CLK		10
 
 /* VIDEO_CC resets */
 #define VIDEO_CC_CVP_INTERFACE_BCR	0
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema
  2021-02-15 16:02 [PATCH v2 0/2] Add dt bindings for sm8250 venus Bryan O'Donoghue
  2021-02-15 16:02 ` [PATCH v2 1/2] dt-bindings: clock: Add missing SM8250 videoc clock indices Bryan O'Donoghue
@ 2021-02-15 16:02 ` Bryan O'Donoghue
  2021-03-05 21:45   ` Rob Herring
  2021-04-01 16:35   ` Rob Herring
  1 sibling, 2 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-02-15 16:02 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-arm-msm, stanimir.varbanov, agross,
	bjorn.andersson
  Cc: bryan.odonoghue

Add a schema description for the venus video encoder/decoder on the sm8250.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 .../bindings/media/qcom,sm8250-venus.yaml     | 167 ++++++++++++++++++
 1 file changed, 167 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml

diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
new file mode 100644
index 000000000000..7b81bd7f2399
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/media/qcom,sm8250-venus.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Venus video encode and decode accelerators
+
+maintainers:
+  - Stanimir Varbanov <stanimir.varbanov@linaro.org>
+
+description: |
+  The Venus IP is a video encode and decode accelerator present
+  on Qualcomm platforms
+
+properties:
+  compatible:
+    const: qcom,sm8250-venus
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  power-domains:
+    minItems: 2
+    maxItems: 3
+
+  power-domain-names:
+    minItems: 2
+    maxItems: 3
+    items:
+      - const: venus
+      - const: vcodec0
+      - const: mx
+
+  clocks:
+    maxItems: 3
+
+  clock-names:
+    items:
+      - const: iface
+      - const: core
+      - const: vcodec0_core
+
+  iommus:
+    maxItems: 1
+
+  memory-region:
+    maxItems: 1
+
+  interconnects:
+    maxItems: 2
+
+  interconnect-names:
+    items:
+      - const: cpu-cfg
+      - const: video-mem
+
+  resets:
+    maxItems: 2
+
+  reset-names:
+    items:
+      - const: bus
+      - const: core
+
+  video-decoder:
+    type: object
+
+    properties:
+      compatible:
+        const: venus-decoder
+
+    required:
+      - compatible
+
+    additionalProperties: false
+
+  video-encoder:
+    type: object
+
+    properties:
+      compatible:
+        const: venus-encoder
+
+    required:
+      - compatible
+
+    additionalProperties: false
+
+  video-firmware:
+    type: object
+
+    description: |
+      Firmware subnode is needed when the platform does not
+      have TrustZone.
+
+    properties:
+      iommus:
+        maxItems: 1
+
+    required:
+      - iommus
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - power-domains
+  - power-domain-names
+  - clocks
+  - clock-names
+  - interconnects
+  - interconnect-names
+  - iommus
+  - memory-region
+  - resets
+  - reset-names
+  - video-decoder
+  - video-encoder
+
+additionalProperties: false
+
+examples:
+  - |
+        #include <dt-bindings/interrupt-controller/arm-gic.h>
+        #include <dt-bindings/clock/qcom,videocc-sm8250.h>
+        #include <dt-bindings/interconnect/qcom,sm8250.h>
+        #include <dt-bindings/clock/qcom,gcc-sm8250.h>
+        #include <dt-bindings/power/qcom-rpmpd.h>
+
+        venus: video-codec@aa00000 {
+            compatible = "qcom,sm8250-venus";
+            reg = <0x0aa00000 0xff000>;
+            interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+            power-domains = <&videocc MVS0C_GDSC>,
+                            <&videocc MVS0_GDSC>,
+                            <&rpmhpd SM8250_MX>;
+            power-domain-names = "venus", "vcodec0", "mx";
+
+            clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+                     <&videocc VIDEO_CC_MVS0C_CLK>,
+                     <&videocc VIDEO_CC_MVS0_CLK>;
+            clock-names = "iface", "core", "vcodec0_core";
+
+            interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc SLAVE_VENUS_CFG>,
+                            <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI_CH0>;
+            interconnect-names = "cpu-cfg", "video-mem";
+
+            iommus = <&apps_smmu 0x2100 0x0400>;
+            memory-region = <&video_mem>;
+
+            resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>,
+                     <&videocc VIDEO_CC_MVS0C_CLK_ARES>;
+            reset-names = "bus", "core";
+
+            video-decoder {
+                compatible = "venus-decoder";
+            };
+
+            video-encoder {
+                compatible = "venus-encoder";
+            };
+        };
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema
  2021-02-15 16:02 ` [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
@ 2021-03-05 21:45   ` Rob Herring
  2021-04-01 16:35   ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-03-05 21:45 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: devicetree, agross, linux-arm-msm, bjorn.andersson,
	stanimir.varbanov, robh+dt

On Mon, 15 Feb 2021 16:02:54 +0000, Bryan O'Donoghue wrote:
> Add a schema description for the venus video encoder/decoder on the sm8250.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../bindings/media/qcom,sm8250-venus.yaml     | 167 ++++++++++++++++++
>  1 file changed, 167 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema
  2021-02-15 16:02 ` [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
  2021-03-05 21:45   ` Rob Herring
@ 2021-04-01 16:35   ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-04-01 16:35 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: linux-arm-msm, stanimir.varbanov, agross, bjorn.andersson,
	devicetree, robh+dt

On Mon, 15 Feb 2021 16:02:54 +0000, Bryan O'Donoghue wrote:
> Add a schema description for the venus video encoder/decoder on the sm8250.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../bindings/media/qcom,sm8250-venus.yaml     | 167 ++++++++++++++++++
>  1 file changed, 167 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-01 17:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 16:02 [PATCH v2 0/2] Add dt bindings for sm8250 venus Bryan O'Donoghue
2021-02-15 16:02 ` [PATCH v2 1/2] dt-bindings: clock: Add missing SM8250 videoc clock indices Bryan O'Donoghue
2021-02-15 16:02 ` [PATCH v2 2/2] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
2021-03-05 21:45   ` Rob Herring
2021-04-01 16:35   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).