From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org,
carl.yin@quectel.com, mpearson@lenovo.com, cchen50@lenovo.com,
jwjiang@lenovo.com, ivan.zhang@quectel.com,
naveen.kumar@quectel.com, ivan.mikhanchuk@quectel.com
Subject: Re: [PATCH v3 1/2] mhi: pci_generic: Parametrable element count for events
Date: Wed, 24 Feb 2021 15:02:10 +0530 [thread overview]
Message-ID: <20210224093210.GN27945@work> (raw)
In-Reply-To: <1613497948-26424-1-git-send-email-loic.poulain@linaro.org>
On Tue, Feb 16, 2021 at 06:52:27PM +0100, Loic Poulain wrote:
> Not all hardwares need to use the same number of event ring elements.
> This change makes this parametrable.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> v2: add this change to the series
> v3: no change
>
> drivers/bus/mhi/pci_generic.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 8187fcf..c58bf96 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -71,9 +71,9 @@ struct mhi_pci_dev_info {
> .doorbell_mode_switch = false, \
> }
>
> -#define MHI_EVENT_CONFIG_CTRL(ev_ring) \
> +#define MHI_EVENT_CONFIG_CTRL(ev_ring, el_count) \
> { \
> - .num_elements = 64, \
> + .num_elements = el_count, \
> .irq_moderation_ms = 0, \
> .irq = (ev_ring) + 1, \
> .priority = 1, \
> @@ -114,9 +114,9 @@ struct mhi_pci_dev_info {
> .doorbell_mode_switch = true, \
> }
>
> -#define MHI_EVENT_CONFIG_DATA(ev_ring) \
> +#define MHI_EVENT_CONFIG_DATA(ev_ring, el_count) \
> { \
> - .num_elements = 128, \
> + .num_elements = el_count, \
> .irq_moderation_ms = 5, \
> .irq = (ev_ring) + 1, \
> .priority = 1, \
> @@ -127,9 +127,9 @@ struct mhi_pci_dev_info {
> .offload_channel = false, \
> }
>
> -#define MHI_EVENT_CONFIG_HW_DATA(ev_ring, ch_num) \
> +#define MHI_EVENT_CONFIG_HW_DATA(ev_ring, el_count, ch_num) \
> { \
> - .num_elements = 2048, \
> + .num_elements = el_count, \
> .irq_moderation_ms = 1, \
> .irq = (ev_ring) + 1, \
> .priority = 1, \
> @@ -156,12 +156,12 @@ static const struct mhi_channel_config modem_qcom_v1_mhi_channels[] = {
>
> static struct mhi_event_config modem_qcom_v1_mhi_events[] = {
> /* first ring is control+data ring */
> - MHI_EVENT_CONFIG_CTRL(0),
> + MHI_EVENT_CONFIG_CTRL(0, 64),
> /* DIAG dedicated event ring */
> - MHI_EVENT_CONFIG_DATA(1),
> + MHI_EVENT_CONFIG_DATA(1, 128),
> /* Hardware channels request dedicated hardware event rings */
> - MHI_EVENT_CONFIG_HW_DATA(2, 100),
> - MHI_EVENT_CONFIG_HW_DATA(3, 101)
> + MHI_EVENT_CONFIG_HW_DATA(2, 1024, 100),
> + MHI_EVENT_CONFIG_HW_DATA(3, 2048, 101)
> };
>
> static struct mhi_controller_config modem_qcom_v1_mhiv_config = {
> --
> 2.7.4
>
prev parent reply other threads:[~2021-02-24 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 17:52 [PATCH v3 1/2] mhi: pci_generic: Parametrable element count for events Loic Poulain
2021-02-16 17:52 ` [PATCH v3 2/2] mhi: pci_generic: Introduce quectel EM1XXGR-L support Loic Poulain
2021-02-24 9:34 ` Manivannan Sadhasivam
2021-02-24 9:32 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224093210.GN27945@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=carl.yin@quectel.com \
--cc=cchen50@lenovo.com \
--cc=hemantk@codeaurora.org \
--cc=ivan.mikhanchuk@quectel.com \
--cc=ivan.zhang@quectel.com \
--cc=jwjiang@lenovo.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mpearson@lenovo.com \
--cc=naveen.kumar@quectel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).