From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFDAC433DB for ; Thu, 11 Mar 2021 08:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C434B64F47 for ; Thu, 11 Mar 2021 08:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbhCKIsn (ORCPT ); Thu, 11 Mar 2021 03:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231630AbhCKIsf (ORCPT ); Thu, 11 Mar 2021 03:48:35 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F59EC061760 for ; Thu, 11 Mar 2021 00:48:35 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id q6-20020a17090a4306b02900c42a012202so8997713pjg.5 for ; Thu, 11 Mar 2021 00:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9ipk2X1DXQbAZMqLuc39QzOVpw53dOdrjEf9bVo9r78=; b=ysKzyEa9LkPeHGGfGDHaoKtD/NlsHHOKvYlLFOKUXSvAfQW8DJQ7oRoJ5mHzhiJrPi MaZTx31QzpMbeix9zjzzSzaM5OYtnXvtlGJsF0qsG4NtrdhMwy2yHRB6sCfMBb11/WM8 HfLMotmU7nLxgLKBGFNTsDQ6jB8J8xcbgcMN2jxNck9pQIknJ0ToJFOlDVzO0VOyzkSI oUAWEiO5KylOAw538KAF5shZ7yzl3A/nSO9IpLmtQP/RXEvUrlyNmANX+xVJL2QFb2BY PlcKSiiKtOBkxK+Q21EmTKdK2EbNr86XYxaOUIxXYboJlnTjh9Q2QPLA+cI9CLtpCteU bCIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9ipk2X1DXQbAZMqLuc39QzOVpw53dOdrjEf9bVo9r78=; b=GbUO666J1EFhKcXoEDZ2cP3RNbNzscM6ofXbnTP7scjZWvHH7PZXJ3FgzeI3zU1AY5 0r4rVxbwbN4GuekfoXN2MHCq1zx2fe5fDOiLkNL6Sj19qvFaRm7ifoRMa5G4KO4HN9GL hyzHcQJ6ISoNPKJwfJLaGKY9yNHnKUgZHLvDxHV9lz3Wp9LIdQNaQS8dvZBni5iAohNR 36WuIobnaJjoLebjf6vd1j3QXXQOv7A+A+xptza6hw8LBFmZWa9VcD+gdJ8KNbmgIiFE opfWS5QrlBfMwnCzJReDlDHNrOjSpYvCuxCP0fFlcZ/NpaQK+0htUu5l75hWf2nq95SK YfrA== X-Gm-Message-State: AOAM532SadboFObkvZRfqkbff8zyyxQF2d011mD3zwPbwds7ooByZ4qA to9112B67gvuefisR3JgpjMOSg== X-Google-Smtp-Source: ABdhPJyahd78ops5WrqbAEWWT6uaYEfmCV/g97/NAiieFbMByIyXE+cKLHlvjji6+BamNcpHjYFlMw== X-Received: by 2002:a17:90a:f28e:: with SMTP id fs14mr7799886pjb.100.1615452514661; Thu, 11 Mar 2021 00:48:34 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id na8sm1519663pjb.2.2021.03.11.00.48.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Mar 2021 00:48:34 -0800 (PST) Date: Thu, 11 Mar 2021 16:48:29 +0800 From: Shawn Guo To: Sergei Shtylyov Cc: Felipe Balbi , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: qcom: skip interconnect init for ACPI probe Message-ID: <20210311084828.GV17424@dragon> References: <20210311060318.25418-1-shawn.guo@linaro.org> <94984a60-444f-a2f5-1928-3eeba2342f2e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94984a60-444f-a2f5-1928-3eeba2342f2e@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 11, 2021 at 11:32:01AM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.03.2021 9:03, Shawn Guo wrote: > > > The ACPI probe starts failing since commit bea46b981515 ("usb: dwc3: > > qcom: Add interconnect support in dwc3 driver"), because there is no > > interconnect support for ACPI, and of_icc_get() call in > > dwc3_qcom_interconnect_init() will just return -EINVAL. > > > > Fix the problem by skipping interconnect init for ACPI probe, and then > > the NULL icc_path_ddr will simply just scheild all ICC calls. > > Scheild? s/scheild/shield Shawn