From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64534C43381 for ; Mon, 15 Mar 2021 17:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23EC264F0C for ; Mon, 15 Mar 2021 17:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbhCORjv (ORCPT ); Mon, 15 Mar 2021 13:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbhCORjY (ORCPT ); Mon, 15 Mar 2021 13:39:24 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50788C06174A for ; Mon, 15 Mar 2021 10:39:24 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id a188so7051949pfb.4 for ; Mon, 15 Mar 2021 10:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=actTwiUWVnuBfKNd4eo6gsL+oSGlooW2XvlXpiME//U=; b=TjU+3b33taeIPvWCr9LrJRwKbASE5h/1/36mQFFG1Qs8q/KUQTkLEDqcc5umt693c7 b2E0PUBO/+KGvsfuKr4Zsh+NP8XbpV58I8seCvJ4I62+8bAjVvBg/6uY13HOElmvcAat GmRfGLGvnSyHmOY6C49esiHAN+YHHDDla8G7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=actTwiUWVnuBfKNd4eo6gsL+oSGlooW2XvlXpiME//U=; b=s/U1m37sKGXOY1AEoV/JLg7IGolAm1DG/9uWz7WKEBEboUZQVZ+2bK++jVgdk7vStC fLM8KVf44aSkX6R9cD0ANTitjb9hHNwNGXTRtkRqDlG1uTUIvFGR81yUPqzvThUKl0uc BBUTgChqIFpCGIuhLAozTCEYPB4APxLtXdZRbkA0/QsBu6L9V2MyuNAj9XzDEZWqGXDy qR5wn7gLRr4Q9f5uvWXkPQq2vYEIeixRvVNpIc12nJgKi59Igtv3i7buqDJyNZVhnDU6 vnh2z2pV2Ds+mRU6misbXcLSsiXoSQdXtQSiyPmBhVxXzfaw09rSyDRLuIVe6DqmWeQg WcMw== X-Gm-Message-State: AOAM5302MVPzKKcNe6KsGRsEXyfaUkhtVmo4pTiJ6BBNqT7IaUQxvGFM M8nAYM3X8RGfCuc1wIUMJzRAycdByNB+qQ== X-Google-Smtp-Source: ABdhPJxWHs2gi96AZyoEt/UwvdmHSnaKsqZDHZItliL+Gimic0yreRUGnvwYj1XiQCMcGkN+0GATRA== X-Received: by 2002:a05:6a00:1585:b029:203:6bc9:3ca6 with SMTP id u5-20020a056a001585b02902036bc93ca6mr11233370pfk.79.1615829963877; Mon, 15 Mar 2021 10:39:23 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:14ce:2d12:6a1f:f42]) by smtp.gmail.com with ESMTPSA id x4sm13638430pfn.134.2021.03.15.10.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 10:39:14 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Douglas Anderson , Stephen Boyd , Jeykumar Sankaran , Chandan Uddaraju , Vara Reddy , Tanmay Shah , Rob Clark , Dmitry Baryshkov , Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes Date: Mon, 15 Mar 2021 10:38:54 -0700 Message-Id: <20210315103836.1.I9a97120319d43b42353aeac4d348624d60687df7@changeid> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As per Dmitry Baryshkov [1]: a) The 2nd "reg" should be 0x3c because "Offset 0x38 is USB3_DP_COM_REVISION_ID3 (not used by the current driver though)." b) The 3rd "reg" "is a serdes region and qmp_v3_dp_serdes_tbl contains registers 0x148 and 0x154." I think because the 3rd "reg" is a serdes region we should just use the same size as the 1st "reg"? [1] https://lore.kernel.org/r/ee5695bb-a603-0dd5-7a7f-695e919b1af1@linaro.org Cc: Stephen Boyd Cc: Jeykumar Sankaran Cc: Chandan Uddaraju Cc: Vara Reddy Cc: Tanmay Shah Cc: Rob Clark Fixes: 58fd7ae621e7 ("arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy") Reported-by: Dmitry Baryshkov Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 83fbb481cae5..61732e5efe62 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2754,8 +2754,8 @@ usb_1_hsphy: phy@88e3000 { usb_1_qmpphy: phy-wrapper@88e9000 { compatible = "qcom,sc7180-qmp-usb3-dp-phy"; reg = <0 0x088e9000 0 0x18c>, - <0 0x088e8000 0 0x38>, - <0 0x088ea000 0 0x40>; + <0 0x088e8000 0 0x3c>, + <0 0x088ea000 0 0x18c>; status = "disabled"; #address-cells = <2>; #size-cells = <2>; -- 2.31.0.rc2.261.g7f71774620-goog