From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Elliot Berman <eberman@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Brian Masney <masneyb@onstation.org>,
Stephan Gerhold <stephan@gerhold.net>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM
Date: Tue, 23 Mar 2021 13:46:15 -0500 [thread overview]
Message-ID: <20210323184615.GI5254@yoga> (raw)
In-Reply-To: <c0dbcf6c-9f6f-2103-68bd-3d06420f309a@codeaurora.org>
On Tue 23 Mar 13:27 CDT 2021, Elliot Berman wrote:
> On 3/22/2021 8:36 PM, Stephen Boyd wrote:
> > Quoting Bjorn Andersson (2021-03-07 09:42:45)
> > > On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote:
> > >
> > > > Quoting Elliot Berman (2021-03-05 10:18:09)
> > > > > On 3/3/2021 10:14 PM, Stephen Boyd wrote:
> > > > > > Quoting Elliot Berman (2021-03-03 19:35:08)
> > > > >
> > > > > > + desc.args[0] = flags;
> > > > > > + desc.args[1] = virt_to_phys(entry);
> > > > > > +
> > > > > > + return scm_legacy_call_atomic(NULL, &desc, NULL);
> > > > > > +}
> > > > > > +EXPORT_SYMBOL(qcom_scm_set_cold_boot_addr);
> > > > >
> > > > > This should still be qcom_scm_call.
> > > >
> > > > You mean s/scm_legacy_call_atomic/qcom_scm_call/ right?
> > > >
> > > > I don't really want to resend the rest of the patches if this last one
> > > > is the only one that needs an update. This was a semi-RFC anyway so
> > > > maybe it's fine if the first 5 patches get merged and then I can resend
> > > > this one? Otherwise I will resend this again next week or so with less
> > > > diff for this patch.
> > >
> > > I'm fine with merging the first 5, but was hoping that Elliot could
> > > provide either a "Reviewed-by" or at least an "Acked-by" on these.
> > >
> >
> > I'll take the silence as I should resend the whole series?
> >
>
> I thought Bjorn was accepting the first 5 already, my apologies.
>
> Patches 1-5:
> Acked-by: Elliot Berman <eberman@codeaurora.org>
Thanks Elliot. I'll pick up the first 5, so please skip these in your
repost, Stephen.
Regards,
Bjorn
prev parent reply other threads:[~2021-03-23 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 21:45 [PATCH 0/6] firmware: qcom_scm: Fix SMCCC detection on sc7180 Stephen Boyd
2021-02-23 21:45 ` [PATCH 1/6] firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool Stephen Boyd
2021-03-06 0:44 ` Bjorn Andersson
2021-02-23 21:45 ` [PATCH 2/6] firmware: qcom_scm: Reduce locking section for __get_convention() Stephen Boyd
2021-02-23 21:45 ` [PATCH 3/6] firmware: qcom_scm: Workaround lack of "is available" call on SC7180 Stephen Boyd
2021-02-23 23:38 ` Jeffrey Hugo
2021-02-23 23:46 ` Stephen Boyd
2021-02-23 21:45 ` [PATCH 4/6] firmware: qcom_scm: Suppress sysfs bind attributes Stephen Boyd
2021-02-23 21:45 ` [PATCH 5/6] firmware: qcom_scm: Fix kernel-doc function names to match Stephen Boyd
2021-02-23 21:45 ` [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM Stephen Boyd
2021-03-04 3:35 ` Elliot Berman
2021-03-04 6:14 ` Stephen Boyd
2021-03-05 18:18 ` Elliot Berman
2021-03-06 6:18 ` Stephen Boyd
2021-03-07 17:42 ` Bjorn Andersson
2021-03-23 3:36 ` Stephen Boyd
2021-03-23 18:27 ` Elliot Berman
2021-03-23 18:46 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323184615.GI5254@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dianders@chromium.org \
--cc=eberman@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=stephan@gerhold.net \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).