From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
carl.yin@quectel.com, naveen.kumar@quectel.com,
loic.poulain@linaro.org
Subject: Re: [PATCH v5 2/2] bus: mhi: core: Move to polling method to wait for MHI ready
Date: Wed, 31 Mar 2021 18:34:51 +0530 [thread overview]
Message-ID: <20210331130451.GJ15610@work> (raw)
In-Reply-To: <1617047583-12104-3-git-send-email-bbhatt@codeaurora.org>
On Mon, Mar 29, 2021 at 12:53:03PM -0700, Bhaumik Bhatt wrote:
> In certain devices, it is likely that there is no incoming MHI
> interrupt for a transition to MHI READY state. One such example
> is the move from Pass Through to an SBL or AMSS execution
> environment. In order to facilitate faster bootup times as there
> is no need to wait until timeout_ms completes, MHI host can poll
> every 25 milliseconds to check if device has entered MHI READY
> until a maximum timeout of twice the timeout_ms is reached.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
> drivers/bus/mhi/core/pm.c | 32 +++++++++++++++-----------------
> 1 file changed, 15 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index 681960c..dcc7fe0 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -153,34 +153,32 @@ static void mhi_toggle_dev_wake(struct mhi_controller *mhi_cntrl)
> /* Handle device ready state transition */
> int mhi_ready_state_transition(struct mhi_controller *mhi_cntrl)
> {
> - void __iomem *base = mhi_cntrl->regs;
> struct mhi_event *mhi_event;
> enum mhi_pm_state cur_state;
> struct device *dev = &mhi_cntrl->mhi_dev->dev;
> - u32 reset = 1, ready = 0;
> + u32 interval_us = 25000; /* poll register field every 25 milliseconds */
> int ret, i;
>
> - /* Wait for RESET to be cleared and READY bit to be set by the device */
> - wait_event_timeout(mhi_cntrl->state_event,
> - MHI_PM_IN_FATAL_STATE(mhi_cntrl->pm_state) ||
> - mhi_read_reg_field(mhi_cntrl, base, MHICTRL,
> - MHICTRL_RESET_MASK,
> - MHICTRL_RESET_SHIFT, &reset) ||
> - mhi_read_reg_field(mhi_cntrl, base, MHISTATUS,
> - MHISTATUS_READY_MASK,
> - MHISTATUS_READY_SHIFT, &ready) ||
> - (!reset && ready),
> - msecs_to_jiffies(mhi_cntrl->timeout_ms));
> -
> /* Check if device entered error state */
> if (MHI_PM_IN_FATAL_STATE(mhi_cntrl->pm_state)) {
> dev_err(dev, "Device link is not accessible\n");
> return -EIO;
> }
>
> - /* Timeout if device did not transition to ready state */
> - if (reset || !ready) {
> - dev_err(dev, "Device Ready timeout\n");
> + /* Wait for RESET to be cleared and READY bit to be set by the device */
> + ret = mhi_poll_reg_field(mhi_cntrl, mhi_cntrl->regs, MHICTRL,
> + MHICTRL_RESET_MASK, MHICTRL_RESET_SHIFT, 0,
> + interval_us);
> + if (ret) {
> + dev_err(dev, "Device failed to clear MHI Reset\n");
> + return -ETIMEDOUT;
You should return the actual error code since there are couple of error
paths.
Thanks,
Mani
> + }
> +
> + ret = mhi_poll_reg_field(mhi_cntrl, mhi_cntrl->regs, MHISTATUS,
> + MHISTATUS_READY_MASK, MHISTATUS_READY_SHIFT, 1,
> + interval_us);
> + if (ret) {
> + dev_err(dev, "Device failed to enter MHI Ready\n");
> return -ETIMEDOUT;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2021-03-31 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 19:53 [PATCH v5 0/2] Polling for MHI ready Bhaumik Bhatt
2021-03-29 19:53 ` [PATCH v5 1/2] bus: mhi: core: Introduce internal register poll helper function Bhaumik Bhatt
2021-03-31 13:03 ` Manivannan Sadhasivam
2021-03-31 17:09 ` Bhaumik Bhatt
2021-03-29 19:53 ` [PATCH v5 2/2] bus: mhi: core: Move to polling method to wait for MHI ready Bhaumik Bhatt
2021-03-31 13:04 ` Manivannan Sadhasivam [this message]
2021-03-31 17:23 ` Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331130451.GJ15610@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=carl.yin@quectel.com \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=naveen.kumar@quectel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).