From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: satya priya <skakit@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
kgunda@codeaurora.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants
Date: Thu, 1 Apr 2021 10:25:12 -0500 [thread overview]
Message-ID: <20210401152512.GP904837@yoga> (raw)
In-Reply-To: <1617280546-9583-2-git-send-email-skakit@codeaurora.org>
On Thu 01 Apr 07:35 CDT 2021, satya priya wrote:
> Add PM7325, PM8350c, PMK8350 and PMR735A compatibles for GPIO
> support.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Changes in V2:
> - No change.
>
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 9801c71..90f4f78 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1131,6 +1131,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
> /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
> { .compatible = "qcom,pmx55-gpio", .data = (void *) 11 },
> + { .compatible = "qcom,pm7325-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
> + { .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
Please try to keep the list sorted alphabetically, that way you'd see
that linux-next already has pm8350c and pmk8350 defined - or at least
Linus would notice when he tries to apply your patch.
Regards,
Bjorn
> + { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
> { },
> };
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2021-04-01 17:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya
2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya
2021-04-01 15:25 ` Bjorn Andersson [this message]
2021-04-01 12:35 ` [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants satya priya
2021-04-01 15:26 ` Bjorn Andersson
2021-04-01 12:35 ` [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML satya priya
2021-04-08 20:53 ` Rob Herring
2021-05-06 4:48 ` skakit
2021-04-08 13:48 ` [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A Linus Walleij
2021-04-09 8:20 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401152512.GP904837@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).