From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A013C433B4 for ; Fri, 2 Apr 2021 14:27:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4488E6113E for ; Fri, 2 Apr 2021 14:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235789AbhDBO1h (ORCPT ); Fri, 2 Apr 2021 10:27:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235608AbhDBO1h (ORCPT ); Fri, 2 Apr 2021 10:27:37 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61F0C0613E6 for ; Fri, 2 Apr 2021 07:27:35 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id m11so1069748pfc.11 for ; Fri, 02 Apr 2021 07:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T3DVNLHJQeSHfhXNKz9gWp+Tv1DR+kLOwzGQWhc+nWA=; b=P7PnM9/F2Rzjf71XMFNGpkG+o4amPJ9qgD+JRcXsUoz805jFetgua3n/+Fqp6EggUt VRLWl6TP2Wqr+yiujTkrQVaeDNyU9PVkvxtWRQNmecAoMARtvVOE2cmr33ke26IMPQoC ONeD+8CXvvl5IQkINWc8dBBxsSpsNY+JsmW4gbxCIhDrVmkwoNmeyQ6HNoHqe50Add9y etKmbMJVsYI/8KKCoH12VcRrwrBGbWzZuN7Z1PzZO1qY1D0J9dXWYSiJpWwCXfrPgDBr MMYbeWXhev1YdG+Meukulm71mxAMMi9TLWgKLsrcegnKrxsA5tfTZevKmAYt9Gm+hRnH s5Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T3DVNLHJQeSHfhXNKz9gWp+Tv1DR+kLOwzGQWhc+nWA=; b=gvRgkv6UxeXhiLbKTX3WcSza09zL7Yj60YPBGLxBtYMpxplD3BLw5vIyH20xooakjp VAnpFxTJAbf6OJ2YMxOTsm5TD8pI94PMkeqFJ82T0xTGqeULrLWKXX3DdAWpSzBhJhel Pjx1VY6YUleGQW1R89rv/vKF0qj2M8p9jKeiUDc9IoeWmJEuRSq7nlNSshmsr6zPZbeT TRFtl2xkIF92ej3Tzykv7WloroWSzma6cA/zFq3JAnay2mXEKOYZnxfTSiw2MmKirHwI jd7DKn9hoWiVIo5SpacrAC4tWWywfHMEEWjKtICwPJ/5WJbHPt9Z9vilLg9HQRQlj9J9 Nl6A== X-Gm-Message-State: AOAM5331Fg1cRO+KSZLhn4YwKVzz6r9xRe8dNqLJ5KgNenrfZeQmmFdR zz3cheDAiD9Fw0x9hF/CYsG8 X-Google-Smtp-Source: ABdhPJyg2TA0SpbCUUf/oOc4ML06NB7wRTSDPCziI9Y/12+4l5psy1DKY3L9m8r9PO487eIRbvnaGw== X-Received: by 2002:a63:d7:: with SMTP id 206mr12092114pga.30.1617373655350; Fri, 02 Apr 2021 07:27:35 -0700 (PDT) Received: from work ([103.77.37.174]) by smtp.gmail.com with ESMTPSA id w4sm8187408pjk.55.2021.04.02.07.27.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Apr 2021 07:27:34 -0700 (PDT) Date: Fri, 2 Apr 2021 19:57:30 +0530 From: Manivannan Sadhasivam To: Boris Brezillon Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v10 3/4] mtd: rawnand: Add support for secure regions in NAND memory Message-ID: <20210402142730.GA10498@work> References: <20210401151955.143817-1-manivannan.sadhasivam@linaro.org> <20210401151955.143817-4-manivannan.sadhasivam@linaro.org> <20210401175421.65db63bf@collabora.com> <20210401161622.GH14052@work> <20210402105154.0a2a3af5@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210402105154.0a2a3af5@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Apr 02, 2021 at 10:51:54AM +0200, Boris Brezillon wrote: > On Thu, 1 Apr 2021 21:46:22 +0530 > Manivannan Sadhasivam wrote: > > > On Thu, Apr 01, 2021 at 05:54:21PM +0200, Boris Brezillon wrote: > > > On Thu, 1 Apr 2021 20:49:54 +0530 > > > Manivannan Sadhasivam wrote: > > > > > > > @@ -565,6 +608,11 @@ static int nand_block_isreserved(struct mtd_info *mtd, loff_t ofs) > > > > > > > > if (!chip->bbt) > > > > return 0; > > > > + > > > > + /* Check if the region is secured */ > > > > + if (nand_region_is_secured(chip, ofs, 0)) > > > > + return -EIO; > > > > > > That would is still wrong, you should never pass a 0 size to > > > nand_region_is_secured(). > > > > > > > Size doesn't matter here, that's why I passed 0. Maybe 1 would be > > appropriate? > > You're checking if a block is reserved, so I think passing the > eraseblock size would make more sense, but I actually don't understand > why you need to check if the region is secure here (looks like > nand_block_isreserved() does not access the flash). > Ah yes indeed, brain fade... Thanks, Mani