linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	carl.yin@quectel.com, naveen.kumar@quectel.com,
	loic.poulain@linaro.org
Subject: Re: [PATCH v8 4/9] bus: mhi: core: Update debug messages to use client device
Date: Wed, 7 Apr 2021 11:57:05 +0530	[thread overview]
Message-ID: <20210407062705.GF8675@work> (raw)
In-Reply-To: <1617311778-1254-5-git-send-email-bbhatt@codeaurora.org>

On Thu, Apr 01, 2021 at 02:16:13PM -0700, Bhaumik Bhatt wrote:
> Debug messages dealing with client devices use the generic MHI
> controller or parent device along with a channel number. It would
> be better to instead use the client device directly and enable
> better log messages for channel updates.
> 
> Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/main.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 710ca0f..94fdbf7 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1238,7 +1238,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
>  				    struct mhi_chan *mhi_chan,
>  				    enum mhi_ch_state_type to_state)
>  {
> -	struct device *dev = &mhi_cntrl->mhi_dev->dev;
> +	struct device *dev = &mhi_chan->mhi_dev->dev;
>  	enum mhi_cmd_type cmd = MHI_CMD_NOP;
>  	int ret;
>  
> @@ -1316,7 +1316,7 @@ static void __mhi_unprepare_channel(struct mhi_controller *mhi_cntrl,
>  				    struct mhi_chan *mhi_chan)
>  {
>  	int ret;
> -	struct device *dev = &mhi_cntrl->mhi_dev->dev;
> +	struct device *dev = &mhi_chan->mhi_dev->dev;
>  
>  	mutex_lock(&mhi_chan->mutex);
>  
> @@ -1340,13 +1340,11 @@ int mhi_prepare_channel(struct mhi_controller *mhi_cntrl,
>  			struct mhi_chan *mhi_chan)
>  {
>  	int ret = 0;
> -	struct device *dev = &mhi_cntrl->mhi_dev->dev;
> +	struct device *dev = &mhi_chan->mhi_dev->dev;
>  
>  	if (!(BIT(mhi_cntrl->ee) & mhi_chan->ee_mask)) {
> -		dev_err(dev,
> -			"Current EE: %s Required EE Mask: 0x%x for chan: %s\n",
> -			TO_MHI_EXEC_STR(mhi_cntrl->ee), mhi_chan->ee_mask,
> -			mhi_chan->name);
> +		dev_err(dev, "Current EE: %s Required EE Mask: 0x%x\n",
> +			TO_MHI_EXEC_STR(mhi_cntrl->ee), mhi_chan->ee_mask);
>  		return -ENOTCONN;
>  	}
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2021-04-07  6:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 21:16 Bhaumik Bhatt
2021-04-01 21:16 ` [PATCH v8 1/9] bus: mhi: core: Allow sending the STOP channel command Bhaumik Bhatt
2021-05-04 17:40   ` Jeffrey Hugo
2021-05-26 19:03   ` patchwork-bot+linux-arm-msm
2021-04-01 21:16 ` [PATCH v8 2/9] bus: mhi: core: Clear context for stopped channels from remove() Bhaumik Bhatt
2021-05-04 17:41   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 3/9] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2021-04-07  6:26   ` Manivannan Sadhasivam
2021-05-04 17:43   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 4/9] bus: mhi: core: Update debug messages to use client device Bhaumik Bhatt
2021-04-07  6:27   ` Manivannan Sadhasivam [this message]
2021-05-04 17:45   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 5/9] bus: mhi: core: Hold device wake for channel update commands Bhaumik Bhatt
2021-04-07  6:31   ` Manivannan Sadhasivam
2021-05-04 17:46   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 6/9] bus: mhi: core: Clear configuration from channel context during reset Bhaumik Bhatt
2021-05-04 17:48   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 7/9] bus: mhi: core: Check channel execution environment before issuing reset Bhaumik Bhatt
2021-05-04 17:49   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 8/9] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2021-05-04 17:50   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 9/9] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2021-05-04 17:51   ` Jeffrey Hugo
2021-04-07  6:56 ` your mail Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210407062705.GF8675@work \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=bbhatt@codeaurora.org \
    --cc=carl.yin@quectel.com \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=naveen.kumar@quectel.com \
    --subject='Re: [PATCH v8 4/9] bus: mhi: core: Update debug messages to use client device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).