From: Sebastian Reichel <sebastian.reichel@collabora.com> To: satya priya <skakit@codeaurora.org> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, David Collins <collinsd@codeaurora.org>, kgunda@codeaurora.org, Vinod Koul <vkoul@kernel.org>, Courtney Cavin <courtney.cavin@sonymobile.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml Date: Thu, 8 Apr 2021 15:00:01 +0200 [thread overview] Message-ID: <20210408130001.k3qbq3vvwkiyykzv@earth.universe> (raw) In-Reply-To: <1617881469-31965-4-git-send-email-skakit@codeaurora.org> [-- Attachment #1: Type: text/plain, Size: 3965 bytes --] Hi, On Thu, Apr 08, 2021 at 05:01:08PM +0530, satya priya wrote: > Convert qcom PON binding from .txt to .yaml format. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- Thanks for doing this. > Changes in V2: > - As per Rob's comments, converted the main PON binding and added in V2. > > .../devicetree/bindings/power/reset/qcom,pon.txt | 49 ---------------------- > .../devicetree/bindings/power/reset/qcom,pon.yaml | 41 ++++++++++++++++++ > 2 files changed, 41 insertions(+), 49 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt > create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt > deleted file mode 100644 > index 0c0dc3a..0000000 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt > +++ /dev/null > @@ -1,49 +0,0 @@ > -Qualcomm PON Device > - > -The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey > -and resin along with the Android reboot-mode. > - > -This DT node has pwrkey and resin as sub nodes. > - > -Required Properties: > --compatible: Must be one of: > - "qcom,pm8916-pon" > - "qcom,pms405-pon" > - "qcom,pm8998-pon" > - > --reg: Specifies the physical address of the pon register > - > -Optional subnode: > --pwrkey: Specifies the subnode pwrkey and should follow the > - qcom,pm8941-pwrkey.txt description. > --resin: Specifies the subnode resin and should follow the > - qcom,pm8xxx-pwrkey.txt description. > - > -The rest of the properties should follow the generic reboot-mode description > -found in reboot-mode.txt > - > -Example: > - > - pon@800 { > - compatible = "qcom,pm8916-pon"; > - > - reg = <0x800>; > - mode-bootloader = <0x2>; > - mode-recovery = <0x1>; > - > - pwrkey { > - compatible = "qcom,pm8941-pwrkey"; > - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > - debounce = <15625>; > - bias-pull-up; > - linux,code = <KEY_POWER>; > - }; > - > - resin { > - compatible = "qcom,pm8941-resin"; > - interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > - debounce = <15625>; > - bias-pull-up; > - linux,code = <KEY_VOLUMEDOWN>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > new file mode 100644 > index 0000000..40eea5f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/qcom,pon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PON Device > + > +maintainers: > + - Vinod Koul <vkoul@kernel.org> > + > +description: | > + The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey > + and resin along with the Android reboot-mode. > + > + This DT node has pwrkey and resin as sub nodes. > + > +properties: > + compatible: > + enum: > + - qcom,pm8916-pon > + - qcom,pms405-pon > + - qcom,pm8998-pon > + > + reg: > + description: Specifies the physical address of the pon register That description is obvious and pointless. Instead add maxItems: 1 > + pwrkey: > + type: object > + $ref: "../../input/qcom,pm8941-pwrkey.yaml#" > + > + resin: > + type: object > + $ref: "../../input/qcom,pm8941-pwrkey.yaml#" > + > +required: > + - compatible > + - reg > + > +additionalProperties: true Instead of allowing arbitrary properties, only valid modes should be allowed. So drop additionalProperties and do this instead: allOf: - $ref: reboot-mode.yaml# unevaluatedProperties: false > +... Please do not drop the example :) -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-08 13:00 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 11:31 [PATCH V2 0/4] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya 2021-04-08 11:31 ` [PATCH V2 1/4] input: pm8941-pwrkey: add " satya priya 2021-04-13 3:00 ` Bjorn Andersson 2021-04-08 11:31 ` [PATCH V2 2/4] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya 2021-04-09 18:46 ` Rob Herring 2021-04-08 11:31 ` [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml satya priya 2021-04-08 13:00 ` Sebastian Reichel [this message] 2021-04-09 8:18 ` skakit 2021-04-09 11:57 ` Sebastian Reichel 2021-04-09 13:38 ` skakit 2021-04-27 6:15 ` skakit 2021-04-27 8:37 ` Sebastian Reichel 2021-05-05 5:08 ` skakit 2021-05-07 9:45 ` skakit 2021-05-07 11:29 ` Sebastian Reichel 2021-04-08 11:31 ` [PATCH V2 4/4] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key " satya priya 2021-04-09 18:50 ` Rob Herring 2021-04-21 6:23 ` skakit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210408130001.k3qbq3vvwkiyykzv@earth.universe \ --to=sebastian.reichel@collabora.com \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=collinsd@codeaurora.org \ --cc=courtney.cavin@sonymobile.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=kgunda@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=skakit@codeaurora.org \ --cc=vkoul@kernel.org \ --subject='Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).