From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3342C433ED for ; Thu, 8 Apr 2021 13:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBA29610CB for ; Thu, 8 Apr 2021 13:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbhDHNVF (ORCPT ); Thu, 8 Apr 2021 09:21:05 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:44867 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbhDHNVE (ORCPT ); Thu, 8 Apr 2021 09:21:04 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D1EF85C005F; Thu, 8 Apr 2021 09:20:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 08 Apr 2021 09:20:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=0TFilmNYZpoCo33PfFme0OURG/N +KN8UabeU9/+7fdE=; b=JI112mzVaWEoeArZuX4uv8DdTh+sQPcUOq4mlocAiB/ ywSiPJ0t7dU2uJgt8zuV1L0fK1AaUdLW8RrKIh06LkW7GGjazlogqsflLXkuxSQz AtxUtF5UbTvSbHnL8uMxQpOwM/IUTmI7qL6QvCR/ZsURBUBtrk7GrwO1aLIFbxWd 8+m0wzek0sslQq/6PkVfFhguE1aRqP/WTsIisZ2BauUadj7BhNcv47TxcRdWSpVv DibfZjJkWf9PqEyIwqgWUKw9lKPsgHSyCiAHF9A5rnF99ghcNJmSdUCl1bZ/zv2Z IP8gR8JtDvbJKh+frZz/pJnVBz6GZrxtTXJrggIhzEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0TFilm NYZpoCo33PfFme0OURG/N+KN8UabeU9/+7fdE=; b=X2mwxHCRyQhp861nPzs3aS DUdsLY8C/9Up5AJn3IyXAnEmbPJgbIoSF9go/Aqh+0zPvMNWiYPx/fEZaC0MPN+a 9WSNvyA1yDMR5JUwf4fQ5ELoAq60fvu3aUh5FJYhJm48bWF/NDbGnSd3zyDuB+cn tFcqYdSZHDtaBPp2h3TrJDBVAkLL2S6WjPxTnCCySIAfRoz7XdpikePk3drRkD6x pF7ApzTfCJRU3+xBNq5RfgY2gNycYc/XFz4t+aYw3jedlGJukQmkZ1MdsdczyLFx 6fR3Mx1tCszPM9yqze2pYeqwFePb7brGKMIFi2RYGNqI3ETzrFd7BJGd55VRM2Kw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejledgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 9D08224005B; Thu, 8 Apr 2021 09:20:50 -0400 (EDT) Date: Thu, 8 Apr 2021 15:20:48 +0200 From: Maxime Ripard To: Stephen Boyd Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Rob Clark , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer Message-ID: <20210408132048.gifhgtkmoeuplhcz@gilmour> References: <20210219120032.260676-1-maxime@cerno.tech> <20210219120032.260676-10-maxime@cerno.tech> <161706912161.3012082.17313817257247946143@swboyd.mtv.corp.google.com> <20210330153527.gw33t4o2b35wwzbg@gilmour> <161713057558.2260335.5422873422021430866@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3mz6ep45tw3nrcn" Content-Disposition: inline In-Reply-To: <161713057558.2260335.5422873422021430866@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --u3mz6ep45tw3nrcn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stephen, On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-03-30 08:35:27) > > Hi Stephen, > >=20 > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > Trimming Cc list way down, sorry if that's too much. > > >=20 > > > Quoting Maxime Ripard (2021-02-19 04:00:30) > > > > Many drivers reference the plane->state pointer in order to get the > > > > current plane state in their atomic_update or atomic_disable hooks, > > > > which would be the new plane state in the global atomic state since > > > > _swap_state happened when those hooks are run. > > >=20 > > > Does this mean drm_atomic_helper_swap_state()? > >=20 > > Yep. Previous to that call in drm_atomic_helper_commit, plane->state is > > the state currently programmed in the hardware, so the old state (that's > > the case you have with atomic_check for example) > >=20 > > Once drm_atomic_helper_swap_state has run, plane->state is now the state > > that needs to be programmed into the hardware, so the new state. >=20 > Ok, and I suppose that is called by drm_atomic_helper_commit()? Yep :) > So presumably a modeset is causing this? I get the NULL pointer around > the time we switch from the splash screen to the login screen. I think > there's a modeset during that transition. It's very likely yeah. I really don't get how that pointer could be null though :/ Maxime --u3mz6ep45tw3nrcn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYG8DMAAKCRDj7w1vZxhR xY8YAPwM+ZLdEm9/yUl0l3VZZpCUYMChQiPmq+Q6C5PwcRmbbAD/XYf6+RRF3hq1 do4BnroDx59ckCB5eKNUKMG9v46NUAI= =gzYE -----END PGP SIGNATURE----- --u3mz6ep45tw3nrcn--